mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
	Neal Cardwell <ncardwell@google.com>
Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev,
	linux-kernel@vger.kernel.org, Jerry Chu <hkchu@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	David Ahern <dsahern@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	Kuniyuki Iwashima <kuniyu@amazon.com>
Subject: Re: [PATCH net v2 0/2] tcp: restrict crossed SYN specific actions to SYN-ACK
Date: Tue, 23 Jul 2024 10:10:15 +0200	[thread overview]
Message-ID: <a2f181c3-92d7-4874-b402-50a54b6d289c@redhat.com> (raw)
In-Reply-To: <20240718-upstream-net-next-20240716-tcp-3rd-ack-consume-sk_socket-v2-0-d653f85639f6@kernel.org>

On 7/18/24 12:33, Matthieu Baerts (NGI0) wrote:
> A recent commit in TCP affects TFO and MPTCP in some cases. The first
> patch fixes that.
> 
> The second one applies the same fix to another crossed SYN specific
> action just before.
> 
> These two fixes simply restrict what should be done only for crossed SYN
> cases to packets with SYN-ACK flags.
> 
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> Changes in v2:
> - Patch 1/2 has a simpler and generic check (Kuniyuki), and an updated
>    comment.
> - New patch 2/2: a related fix
> - Link to v1: https://lore.kernel.org/r/20240716-upstream-net-next-20240716-tcp-3rd-ack-consume-sk_socket-v1-1-4e61d0b79233@kernel.org

Re-adding Neal for awareness. It would be great if this could go through 
some packetdrill testing,

Thanks!

Paolo


  parent reply	other threads:[~2024-07-23  8:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18 10:33 Matthieu Baerts (NGI0)
2024-07-18 10:33 ` [PATCH net v2 1/2] tcp: process the 3rd ACK with sk_socket for TFO/MPTCP Matthieu Baerts (NGI0)
2024-07-23 14:37   ` Eric Dumazet
2024-07-23 14:58     ` Matthieu Baerts
2024-07-23 15:38       ` Eric Dumazet
2024-07-23 16:08         ` Matthieu Baerts
2024-07-23 16:42           ` Eric Dumazet
2024-07-23 19:09             ` Matthieu Baerts
2024-07-23 21:41               ` Kuniyuki Iwashima
2024-07-23 22:01               ` Neal Cardwell
2024-07-24  8:15                 ` Matthieu Baerts
2024-07-23 21:27         ` Kuniyuki Iwashima
2024-07-18 10:33 ` [PATCH net v2 2/2] tcp: limit wake-up for crossed SYN cases to SYN-ACK Matthieu Baerts (NGI0)
2024-07-23 14:32   ` Eric Dumazet
2024-07-23 14:40     ` Matthieu Baerts
2024-07-23  8:10 ` Paolo Abeni [this message]
2024-07-23  8:22   ` [PATCH net v2 0/2] tcp: restrict crossed SYN specific actions " Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2f181c3-92d7-4874-b402-50a54b6d289c@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=hkchu@google.com \
    --cc=kuba@kernel.org \
    --cc=kuniyu@amazon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®