From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: mathias.nyman@intel.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [BUG] usb: xhci: Two possible sleep-in-atomic-context bugs
Date: Wed, 20 Jun 2018 11:12:14 +0800 [thread overview]
Message-ID: <a2f62eac-b3e1-bd1e-3993-83e2f6adef03@gmail.com> (raw)
The driver may sleep with holding a spinlock.
The function call paths (from bottom to top) in Linux-4.16.7 are:
[FUNC] schedule
drivers/base/power/runtime.c, 741: schedule in rpm_resume
drivers/base/power/runtime.c, 1322: rpm_resume in pm_runtime_forbid
drivers/usb/host/xhci-hub.c, 647: pm_runtime_forbid in xhci_enter_test_mode
drivers/usb/host/xhci-hub.c, 632: _raw_spin_lock_irqsave in
xhci_enter_test_mode
[FUNC] schedule
drivers/base/power/runtime.c, 570: schedule in rpm_suspend
drivers/base/power/runtime.c, 434: rpm_suspend in rpm_idle
drivers/base/power/runtime.c, 1343: rpm_idle in pm_runtime_allow
drivers/usb/host/xhci-hub.c, 670: pm_runtime_allow in xhci_exit_test_mode
drivers/usb/host/xhci-hub.c, 1387: xhci_exit_test_mode in xhci_hub_control
drivers/usb/host/xhci-hub.c, 1038: _raw_spin_lock_irqsave in
xhci_hub_control
These bugs are found by my static analysis tool (DSAC-2) and checked by my
code review.
I do not know how to correctly fix these bugs, so I just report them.
Best wishes,
Jia-Ju Bai
next reply other threads:[~2018-06-20 3:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 3:12 Jia-Ju Bai [this message]
2018-06-20 3:28 ` Peter Chen
2018-06-20 9:15 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2f62eac-b3e1-bd1e-3993-83e2f6adef03@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome