From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C85E21C16D for ; Thu, 17 Oct 2024 19:11:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729192279; cv=none; b=DYgmu/WHiqQ+RzlRA2Vxye9ZKkgALZooyHVNYJiaC59DaxGAIysRl5h0WRHnycTifjfs7esm1R8IRZ4H2XaLDCPTD1G/EpXWYFdxNHs5wtckSrZ4oODD99coaYZ+N2q4mbvKo0YoM7PPnPL2qbpsFlFJSjolQwTDvNMyrr4h2n0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729192279; c=relaxed/simple; bh=v8Avf/NnuFpi/P6Ct8b/Z7JTnVtN3W+381UpOAK9q+4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k1tsrYHTt60uDwyX/4sLddjLtIACJiEtPt3OoW+XUggKnE5Ifp6ittn90jVQTfgtr47TsvpqHeTqwA94/dpUuHjHobBrFM0JqSsFQZxh+XzXAmk7KUYfJw8ifOtnuJLDrqEEyJIe4rC9TUjQ/MEpTDQRGWLevFbOIAv+Vl2YAa0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com; spf=fail smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=k5X3ORMk; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="k5X3ORMk" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49HHTlLh007469 for ; Thu, 17 Oct 2024 19:11:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hz0ZnAe11pZokPDhFpVE6U0qSp4/P5YMh+MPxjixj3s=; b=k5X3ORMkj/+oxak8 uiANbnoJlZRbpIgNtSx1qujwTcU/JN0ZlcU2fGQ6imcTeGUqo/2NZ9a0Lo6/6MOf nbaF08rpjk9Uxi1V+FL78DBtEx0D8uPonK274J9PxXY2jq23OO0qgvm37U7HWI0H Qtb/dYIv3K+ubiVUc0VjAzoAiavtjUeHKH3eBjBq0AFwlPQzmFsnbFbSYzYEmxCR ts9Q2x97mNQeE1J5KKpy4FIAt5b6WnesvltOXGz7MyThz0AuMoOyyWw3YqDf0wht ho05nRwA0xTplaxmMTU+Cz3/aN8r/PQC9ylUPWiXpe5DGMRBitIBcIuTJmjZsVWP Cdbz4Q== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 429mjy9b47-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 17 Oct 2024 19:11:13 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6cbd0a3f253so2330456d6.3 for ; Thu, 17 Oct 2024 12:11:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729192272; x=1729797072; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hz0ZnAe11pZokPDhFpVE6U0qSp4/P5YMh+MPxjixj3s=; b=lwv+Er0dgRu8pBIOOyHz3pIGrb6iK83KOuCudCWC+DbK2os0Tpt+7FtG4e1KFyq/+4 VfxCNtk+shShp/BobgfblO/DPqGKo+CywB9tvUUtIFtwM/7KOQcr7QH3eRnWzNGc0Bte OjISISWhgrWHSDFWNSg+fugsNpivr7Zhne5wD5/eOu2YWgzfO7m5OsFB0t6FvcPj9q1g 2GYlS/yHh8t52WWv1/hLy033vUUirdQPzHcc31GwDDlLlktxuUPsRt0ixHX/0ikR12HA uuYeDep+baRoi183qedVtGTareCEg0OnxuakdKy0kfau2Dm1QcUfE6ceNWShb2RP/NEg kX+A== X-Forwarded-Encrypted: i=1; AJvYcCVua9by4j53rYraOyKc+mQp8LajkZ8PKORK4K14PMxFWMIar9D2Yqr0x5qN/oEklMBtUGJoA4XeUFKJGFw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6PVXS2P3si3R0/Vehum3SNvkSSv/NMaMZF5MeIzRTjGLwmlaq J/dwgOP7rrPROYa3yvA8cH7cDauDOxvx8kSYIAsuvRFEtqSJfsuDi+vIEnluY7RPilmYkxJI/6e y0wews4u0j8HD0Zd1YW/JJl2oIO8aQY2zIlKua7E00tfm3G0RsC/rY+f053Mozwg= X-Received: by 2002:a05:6214:1304:b0:6cb:38bf:40b7 with SMTP id 6a1803df08f44-6cc37a3155dmr27106856d6.2.1729192272265; Thu, 17 Oct 2024 12:11:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEbwq4tqffDANVWUds9nyhXoagPQKQd5WCsDNUqDF5cZJEeTl0EOL2AZl9FT/AkJ44UU3VpNA== X-Received: by 2002:a05:6214:1304:b0:6cb:38bf:40b7 with SMTP id 6a1803df08f44-6cc37a3155dmr27106696d6.2.1729192271847; Thu, 17 Oct 2024 12:11:11 -0700 (PDT) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c98d4d6324sm3026405a12.14.2024.10.17.12.11.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Oct 2024 12:11:11 -0700 (PDT) Message-ID: Date: Thu, 17 Oct 2024 21:11:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/14] clk: qcom: rpmh: add support for SAR2130P To: Dmitry Baryshkov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Neil Armstrong , Philipp Zabel , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241017-sar2130p-clocks-v1-0-f75e740f0a8d@linaro.org> <20241017-sar2130p-clocks-v1-10-f75e740f0a8d@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241017-sar2130p-clocks-v1-10-f75e740f0a8d@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: TLSnxcJJSEEcQX3xWXTPQ77HdDgMSJHs X-Proofpoint-ORIG-GUID: TLSnxcJJSEEcQX3xWXTPQ77HdDgMSJHs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 phishscore=0 mlxscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 clxscore=1015 spamscore=0 suspectscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410170128 On 17.10.2024 6:57 PM, Dmitry Baryshkov wrote: > Define clocks as supported by the RPMh on the SAR2130P platform. It > seems that on this platform RPMh models only CXO clock. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/clk/qcom/clk-rpmh.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c > index 4acde937114af3d7fdc15f3d125a72d42d0fde21..8cb15430d0171a8ed6b05e51d1901af63a4564c4 100644 > --- a/drivers/clk/qcom/clk-rpmh.c > +++ b/drivers/clk/qcom/clk-rpmh.c > @@ -389,6 +389,16 @@ DEFINE_CLK_RPMH_BCM(ipa, "IP0"); > DEFINE_CLK_RPMH_BCM(pka, "PKA0"); > DEFINE_CLK_RPMH_BCM(qpic_clk, "QP0"); > > +static struct clk_hw *sar2130p_rpmh_clocks[] = { > + [RPMH_CXO_CLK] = &clk_rpmh_bi_tcxo_div1.hw, > + [RPMH_CXO_CLK_A] = &clk_rpmh_bi_tcxo_div1_ao.hw, > +}; > + > +static const struct clk_rpmh_desc clk_rpmh_sar2130p = { > + .clks = sar2130p_rpmh_clocks, > + .num_clks = ARRAY_SIZE(sar2130p_rpmh_clocks), > +}; This is identical to the QDU1000 setup. Perhaps you can rename it to something generic (bi_tcxo_div1_clocks[]) and reference it in both compatible strings (as the compatibility seems rather incidental) Konrad