From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Md Sadre Alam <quic_mdalam@quicinc.com>,
andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: quic_srichara@quicinc.com, quic_varada@quicinc.com
Subject: Re: [PATCH 2/3] arm64: dts: qcom: ipq9574: Enable TRNG instead PRNG
Date: Fri, 13 Dec 2024 00:55:42 +0100 [thread overview]
Message-ID: <a2f80840-75d4-4380-aa85-d83242db08a9@oss.qualcomm.com> (raw)
In-Reply-To: <20241206072057.1508459-3-quic_mdalam@quicinc.com>
On 6.12.2024 8:20 AM, Md Sadre Alam wrote:
> RNG hardware versions greater than 3.0 are Truly
> Random Number Generators (TRNG). In IPQ95xx RNG
> block is TRNG. Update the corresponding compatible
> property to ensure the hardware block is registered
> with the hw_random framework, which feeds the Linux
> entropy pool.
Line wrapping should be around 72 chars, this looks funny
Please change the commit title to 'update TRNG compatible', as
'enable' implies the functionality is not present as of current.
The latter part of the last sentence is misleading, as both
compatibles do the same thing in the driver. Instead, put emphasis
on the wrong compatible being used and the patch making sure the
hardware is described properly, without functional changes.
Same for patch 3
Konrad
next prev parent reply other threads:[~2024-12-12 23:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 7:20 [PATCH 0/3] Enable TRNG support Md Sadre Alam
2024-12-06 7:20 ` [PATCH 1/3] arm64: dts: qcom: ipq5424: Add TRNG node Md Sadre Alam
2024-12-12 23:56 ` Konrad Dybcio
2024-12-06 7:20 ` [PATCH 2/3] arm64: dts: qcom: ipq9574: Enable TRNG instead PRNG Md Sadre Alam
2024-12-12 23:55 ` Konrad Dybcio [this message]
2024-12-13 8:44 ` Md Sadre Alam
2024-12-06 7:20 ` [PATCH 3/3] arm64: dts: qcom: ipq5332: Enable TRNG instead of PRNG Md Sadre Alam
2024-12-06 7:29 ` [PATCH 0/3] Enable TRNG support Manikanta Mylavarapu
2024-12-09 5:32 ` Md Sadre Alam
2024-12-13 8:46 ` Md Sadre Alam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2f80840-75d4-4380-aa85-d83242db08a9@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mdalam@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®