From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751327AbdBSABq (ORCPT ); Sat, 18 Feb 2017 19:01:46 -0500 Received: from mx2.suse.de ([195.135.220.15]:51760 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212AbdBSABp (ORCPT ); Sat, 18 Feb 2017 19:01:45 -0500 Subject: Re: [PATCH] DTS: Linksys Board: Add default trigger for sata led To: Jason Cooper , Ansuel Smith References: <1487364137-3008-1-git-send-email-ansuelsmth@gmail.com> <20170218141213.GK25924@io.lakedaemon.net> Cc: gregory.clement@free-electrons.com, andrew@lunn.ch, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: Date: Sun, 19 Feb 2017 01:01:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170218141213.GK25924@io.lakedaemon.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am 18.02.2017 um 15:12 schrieb Jason Cooper: > On Fri, Feb 17, 2017 at 09:42:17PM +0100, Ansuel Smith wrote: >> In others board we have the sata led set to funcion with the sata led trigger by default. >> This patch makes the same for these board that have sata led but disabled by not associating it to any trigger > > Please line wrap the commit message. The subject could also use some love, like mentioning "ARM:" and "armada" and dropping "Board". Compare git log --oneline. Regards, Andreas > Other than that, > >> >> Signed-off-by: Ansuel Smith > > Acked-by: Jason Cooper > > thx, > > Jason. > >> --- >> arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 + >> arch/arm/boot/dts/armada-385-linksys-cobra.dts | 1 + >> arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 1 + >> 3 files changed, 3 insertions(+) -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)