From: Reinette Chatre <reinette.chatre@intel.com>
To: "Luck, Tony" <tony.luck@intel.com>, Babu Moger <bmoger@amd.com>,
"Babu Moger" <babu.moger@amd.com>,
"Dave.Martin@arm.com" <Dave.Martin@arm.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Cc: "x86@kernel.org" <x86@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"peternewman@google.com" <peternewman@google.com>,
"Eranian, Stephane" <eranian@google.com>,
"gautham.shenoy@amd.com" <gautham.shenoy@amd.com>
Subject: Re: [PATCH v2] x86/resctrl: Fix buggy overflow when reactivating previously Unavailable RMID
Date: Thu, 9 Oct 2025 13:48:39 -0700 [thread overview]
Message-ID: <a303c08d-f05d-41e5-932d-20bc96a17efd@intel.com> (raw)
In-Reply-To: <SJ1PR11MB6083BBB7FE524ADBE01C5DB6FCEEA@SJ1PR11MB6083.namprd11.prod.outlook.com>
Hi Tony,
On 10/9/25 11:39 AM, Luck, Tony wrote:
>> Here is what I do to check for non-ascii characters:
>> $ b4 am <message ID>
>> $ grep -P '[^\t\n\x20-\x7E]' <downloaded patch>
>>
>> Could you please try it out on this patch and fix the matches?
>
> Does the non-ascii rule include the cover letter? Or just the patches
> that will be applied and included into the Linux GIT repository?
>
> My AET patches are "clean", but the cover letter has some output
> from the tree(1) command. So the grep kicks out this:
>
> ├── mon_PERF_PKG_00
> │ ├── activity
> │ └── core_energy
> └── mon_PERF_PKG_01
> ├── activity
> └── core_energy
I think this is fine. I do not know if there is an official rule about this but in
this case the problem is the subtle differences in the text when it, like in
this changelog, switches between ascii and non-ascii for the "same" character.
For example, like when this changelog switches the quotes between "Unavailable" and
“Unavailable”. This is unnecessary obfuscation.
Reinette
prev parent reply other threads:[~2025-10-09 20:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 19:39 Babu Moger
2025-10-09 2:00 ` Reinette Chatre
2025-10-09 18:15 ` Babu Moger
2025-10-09 18:39 ` Luck, Tony
2025-10-09 20:48 ` Reinette Chatre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a303c08d-f05d-41e5-932d-20bc96a17efd@intel.com \
--to=reinette.chatre@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=bmoger@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=gautham.shenoy@amd.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peternewman@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®