From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90C02C433F5 for ; Mon, 18 Apr 2022 06:47:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236859AbiDRGuB (ORCPT ); Mon, 18 Apr 2022 02:50:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231321AbiDRGt6 (ORCPT ); Mon, 18 Apr 2022 02:49:58 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A27CDDC1; Sun, 17 Apr 2022 23:47:20 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 06A1AED1; Sun, 17 Apr 2022 23:47:20 -0700 (PDT) Received: from [192.168.225.231] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7C62B3F7B4; Sun, 17 Apr 2022 23:47:14 -0700 (PDT) Message-ID: Date: Mon, 18 Apr 2022 12:17:53 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH V5 0/8] perf: Expand perf_branch_entry Content-Language: en-US From: Anshuman Khandual To: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, peterz@infradead.org, acme@kernel.org Cc: Robin Murphy , Suzuki Poulose , James Clark , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Will Deacon , linux-arm-kernel@lists.infradead.org References: <20220404045046.634522-1-anshuman.khandual@arm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/11/22 11:16, Anshuman Khandual wrote: > > > On 4/4/22 10:20, Anshuman Khandual wrote: >> Branch Record Buffer Extension (BRBE) implementation on arm64 captures more >> branch type classification which cannot be accommodated in the current perf >> branch record format via perf_branch_entry.type element (4 bit field). Also >> it captures privilege information which does not have a corresponding slot >> in perf_branch_entry. This series expands struct perf_branch_entry, to meet >> both these requirements without breaking the existing user space ABI for >> perf tools. >> >> All architecture specific branch types added via perf_branch_entry.new_type >> field in [PATCH 3/4] will be used in BRBE implementation on arm64 platform >> later on with the following map. >> >> #ifdef CONFIG_ARM64 >> #define PERF_BR_FIQ PERF_BR_NEW_ARCH_1 >> #define PERF_BR_DEBUG_HALT PERF_BR_NEW_ARCH_2 >> #define PERF_BR_DEBUG_EXIT PERF_BR_NEW_ARCH_3 >> #define PERF_BR_DEBUG_INST PERF_BR_NEW_ARCH_4 >> #define PERF_BR_DEBUG_DATA PERF_BR_NEW_ARCH_5 >> #endif >> >> This actually combines following patches and series into a single series. >> >> - https://lore.kernel.org/all/1642998653-21377-12-git-send-email-anshuman.khandual@arm.com/ >> - https://lore.kernel.org/all/1643348653-24367-1-git-send-email-anshuman.khandual@arm.com/ >> - https://lore.kernel.org/all/1645681014-3346-1-git-send-email-anshuman.khandual@arm.com/ >> >> This series applies on v5.18-rc1 >> >> perf API >> >> The series being applied >> >> - Clean : tools/perf/check-headers.sh >> - Clean : diff -u tools/include/uapi/linux/perf_event.h include/uapi/linux/perf_event.h >> >> Todo >> >> - Update perf report tool to process PERF_BR_EXTEND_ABI (when available), >> then fetch and report branch types from perf_branch_entry.new_type field. >> >> References >> >> - BRBE captured branch record information >> >> https://developer.arm.com/documentation/ddi0601/2021-12/AArch64-Registers/BRBINF-n--EL1--Branch-Record-Buffer-Information-Register--n-?lang=en >> >> - BRBE based perf branch stack implementation on arm64 platform >> >> https://lore.kernel.org/all/1642998653-21377-1-git-send-email-anshuman.khandual@arm.com/ >> >> Changes in V5: >> >> - Dropped patches [PATCH 1/10] and [PATCH 6/10] related to PERF_BR_[RET|IRQ] - merged >> via the commit cedd3614e5d9c809 ("perf: Add irq and exception return branch types") >> >> - Rebased series on v5.18-rc1 > > Gentle ping, any updates on this series ? Gentle ping, any updates on this series ? I have posted BRBE RFC V2 accommodating all these new perf ABI changes being proposed here. I would really appreciate reviews and/or suggestions on this series, which is essential and also prerequisite for the BRBE driver itself. https://lore.kernel.org/all/20220412115455.293119-1-anshuman.khandual@arm.com/ - Anshuman