From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753408AbcIAIkm (ORCPT <rfc822;w@1wt.eu>);
        Thu, 1 Sep 2016 04:40:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54800 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751521AbcIAIkj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Sep 2016 04:40:39 -0400
Subject: Re: [linux-sunxi] Re: [PATCH v3] ARM: dts: sun8i: enable UART1 for
 iNet D978 Rev2 board
To: Maxime Ripard <maxime.ripard@free-electrons.com>,
        Icenowy Zheng <icenowy@aosc.xyz>
References: <20160829141832.10566-1-icenowy@aosc.xyz>
 <20160831162240.GJ14379@lukather>
Cc: Russell King <linux@armlinux.org.uk>, Chen-Yu Tsai <wens@csie.org>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
From: Hans de Goede <hdegoede@redhat.com>
Message-ID: <a3097f99-a761-76e7-1405-2574c56ac94d@redhat.com>
Date: Thu, 1 Sep 2016 10:40:32 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <20160831162240.GJ14379@lukather>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 01 Sep 2016 08:40:39 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 31-08-16 18:22, Maxime Ripard wrote:
> On Mon, Aug 29, 2016 at 10:18:32PM +0800, Icenowy Zheng wrote:
>> UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card
>> on iNet D978 Rev2 board.
>>
>> Enable the UART1 to make it possible to use the modified hciattach by
>> Realtek to drive the BT part of RTL8723BS.
>>
>> On the board no r_uart pins are found now (the onboard RX/TX pins are
>> wired to PF2/PF4, which is muxed with mmc0), so also disabled it.
>>
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>
> I'll make the same comments than in the v2.
> https://www.spinics.net/lists/arm-kernel/msg527001.html

I've a feeling there is a bit of miscommunication here,
let me try to clarify things:

Icenowy, Maxime wants you to split this into 2 patches:

1) Adding just the uart1_pins_a and uart1_pins_cts_rts_a nodes to
sun8i-a23-a33.dtsi; and
2) Another patch with the sun8i-a33-inet-d978-rev2.dts changes

And for 2. Maxime wants you to change:

	aliases {
		/delete-property/serial0;
		serial1 = &uart1;
	};

to:

	aliases {
		serial0 = &uart1;
	};

There is no serial0 and Maxime wants the serial-s
to be numbered starting at 0 (iow there is no reason
to make the bluetooth uart serial1).

Regards,

Hans