mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xi Ruoyao <xry111@xry111.site>
To: Youling Tang <tangyouling@loongson.cn>, loongarch@lists.linux.dev
Cc: linux-kernel@vger.kernel.org, WANG Xuerui <kernel@xen0n.name>,
	Huacai Chen <chenhuacai@kernel.org>,
	Jinyang He <hejinyang@loongson.cn>
Subject: Re: [PATCH v3 0/4] LoongArch: Support new relocation types
Date: Fri, 29 Jul 2022 10:29:53 +0800	[thread overview]
Message-ID: <a30e39a1b41dc63fff32b8d350fecb92dfe27d09.camel@xry111.site> (raw)
In-Reply-To: <879dc428-0407-3280-617d-840352aa6d08@loongson.cn>

On Fri, 2022-07-29 at 10:23 +0800, Youling Tang wrote:
> Hi, Ruoyao
> 
> On 07/29/2022 10:07 AM, Xi Ruoyao wrote:
> > The version 2.00 of LoongArch ELF ABI specification introduced new
> > relocation types, and the development tree of Binutils and GCC has
> > started to use them.  If the kernel is built with the latest snapshot of
> > Binutils or GCC, it will fail to load the modules because of unrecognized
> > relocation types in modules.
> > 
> > Add support for GOT and new relocation types for the module loader, so
> > the kernel (with modules) can be built with the "normal" code model and
> > function properly.
> > 
> > This series does not break the compatibility with old toolchain using
> > stack-based relocation types, so with the patches applied the kernel can
> > be be built with both old and new toolchains.
> > 
> > Tested by building the kernel with both Binutils & GCC master branch and
> > my system Binutils & GCC (without new relocation type support), running
> > both the builds with 35 in-tree modules loaded, and loading one module
> > with 20 GOT loads (loaded addresses verified by comparing with
> > /proc/kallsyms).
> > 
> > Changes from v2 to v3:
> > 
> > - Use `union loongarch_instruction` instead of explicit bit shifts
> >   applying the relocation.  Suggested by Youling.
> > - For R_LARCH_B26, move the alignment check before the range check to be
> >   consistent with stack pop relocations.  Suggested by Youling.
> > - Reword the commit message of the 3rd patch.  Suggested by Huacai.
> 
> The log of changes from v1 to v2 should be preserved.
> 
Retroactively, append the changes from v1 to v2:

- Fix a stupid programming error (confusion between the number of PLT
  entries and the number of GOT entries).  (Bug spotted by Youling).
- Synthesize the _GLOBAL_OFFSET_TABLE_ symbol with module.lds, instead
  of faking it at runtime.  The 3rd patch from V1 is now merged into
  the 1st patch because it would be a one-line change.  (Suggested by
  Jinyang).
- Keep reloc_rela_handlers[] ordered by the relocation type ID.
  (Suggested by Youling).
- Remove -fplt along with -Wa,-mla-* options because it's the default.
  (Suggested by Youling).

-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University

      reply	other threads:[~2022-07-29  2:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-29  2:07 Xi Ruoyao
2022-07-29  2:08 ` [PATCH v3 1/4] LoongArch: Add section of GOT for kernel module Xi Ruoyao
2022-07-29  2:08 ` [PATCH v3 2/4] LoongArch: Support R_LARCH_SOP_PUSH_GPREL relocation type in " Xi Ruoyao
2022-07-29  2:09 ` [PATCH v3 3/4] LoongArch: Remove -fplt and -Wa,-mla-* from CFLAGS Xi Ruoyao
2022-07-29  2:50   ` Xi Ruoyao
2022-07-29  2:10 ` [PATCH v3 4/4] LoongArch: Support modules with new relocation types Xi Ruoyao
2022-07-29  2:23 ` [PATCH v3 0/4] LoongArch: Support " Youling Tang
2022-07-29  2:29   ` Xi Ruoyao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a30e39a1b41dc63fff32b8d350fecb92dfe27d09.camel@xry111.site \
    --to=xry111@xry111.site \
    --cc=chenhuacai@kernel.org \
    --cc=hejinyang@loongson.cn \
    --cc=kernel@xen0n.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=tangyouling@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®