From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA2BE33997 for ; Mon, 20 Jan 2025 04:09:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737346166; cv=none; b=fZ508GetG9hKCebr8RqJokmNNqiTwaEIqErGEI2Hfi32QqcHTybVMSMojEqeGEkzB9hW8E0f/WfScubY3QHF+mxKpXXr+8ti8W760Jg0TKPG+nobk7HwZ4qGAgmE+guoyBaIVuonQcy3YxBRWhouO1FgbjiMx96rqMRP6YckYNA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737346166; c=relaxed/simple; bh=5K/X2LrPT5KeZduj3QaCE8DpfYMm/SeNCy8YGkbgHag=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EmW6k3Y53o1mB4btlE3sC0Pf8/YgxV3xnwAPxatl8AwNRdr2OdwNAj7eZHtg82PnmdVKGOy4YC6mHjrPfq5ZDIUq8MP2kpVc8PFeaUk8E+bofQMDotIfT+KeEVZO0D4cz4TOSo5VsgWobVoYt+gfxmCDARur9hVQYw9L4yuumeA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=kh58gmb2; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="kh58gmb2" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50K18Vhv030641; Mon, 20 Jan 2025 04:08:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=OVVGSD e7eGliM7xbVbpxTfQM8OjpFKyLRgmIhZjSzQo=; b=kh58gmb2sGl05BWg/neW2m tT6lG5NciYRjSiqPx4Dgxgy9UQmUTUHSOdt+Oeebn6efiC3TLDnAmhZEos95zScQ O9STAWpnkcUFl8YFUhJ41zhyVHhCz/BsOzgUfeaaHoiamFn6/lG9mu0ae8c60eUh Xfq8JPQdNiEjLuTMXttC3TzmFwWoJoU8NNMEDEd5vMScSSVrXnJ3R6qcW9niEqRA hl1oOBvwbXgBc5kBtmAhzNau3KBfq9FEt6Bc6W0jkCpDZMe+B+pDZKKTP8gEpsVM crjfrJFIf+udvOUjuJHRX+nai9xSxpVF/0nd5fh2neIJ5TS3Wg8UpCTUCbK8MoYQ == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 449cj90h06-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Jan 2025 04:08:42 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 50K48foK012020; Mon, 20 Jan 2025 04:08:41 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 449cj90h02-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Jan 2025 04:08:41 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 50K3UASC029604; Mon, 20 Jan 2025 04:08:40 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 448qmn4hrp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Jan 2025 04:08:40 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 50K48cKj30146862 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jan 2025 04:08:38 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7D59120040; Mon, 20 Jan 2025 04:08:38 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A2DAE20043; Mon, 20 Jan 2025 04:08:36 +0000 (GMT) Received: from [9.109.215.252] (unknown [9.109.215.252]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 20 Jan 2025 04:08:36 +0000 (GMT) Message-ID: Date: Mon, 20 Jan 2025 09:38:35 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched: Fixes typos in comments and error message To: Atul Kumar Pant Cc: dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org References: <20250118092026.17406-1-atulpant.linux@gmail.com> From: Shrikanth Hegde Content-Language: en-US In-Reply-To: <20250118092026.17406-1-atulpant.linux@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: WITVzdMfmsf8wDQKJLIe7t-W04XNIbAB X-Proofpoint-GUID: stiJd4QAyRKmKvzcaqX5CgX9P5Buo34q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-20_01,2025-01-16_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 spamscore=0 impostorscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501200030 On 1/18/25 14:50, Atul Kumar Pant wrote: Not even a single line in changelog? Also, did you do this manually or using any tool? > Signed-off-by: Atul Kumar Pant > --- > kernel/sched/core.c | 2 +- > kernel/sched/cputime.c | 2 +- > kernel/sched/topology.c | 2 +- > kernel/sched/wait_bit.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 3e5a6bf58..451e30249 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -8998,7 +8998,7 @@ void sched_release_group(struct task_group *tg) > * that tg_unthrottle_up() won't add decayed cfs_rq's to it. > * > * We therefore defer calling unregister_fair_sched_group() to > - * sched_unregister_group() which is guarantied to get called only after the > + * sched_unregister_group() which is guaranteed to get called only after the > * current RCU grace period has expired. > */ > spin_lock_irqsave(&task_group_lock, flags); > diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c > index 0bed0fa1a..f8ada8239 100644 > --- a/kernel/sched/cputime.c > +++ b/kernel/sched/cputime.c > @@ -584,7 +584,7 @@ void cputime_adjust(struct task_cputime *curr, struct prev_cputime *prev, > stime = mul_u64_u64_div_u64(stime, rtime, stime + utime); > /* > * Because mul_u64_u64_div_u64() can approximate on some > - * achitectures; enforce the constraint that: a*b/(b+c) <= a. > + * architectures; enforce the constraint that: a*b/(b+c) <= a. fine. > */ > if (unlikely(stime > rtime)) > stime = rtime; > diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c > index 9748a4c8d..a9f4fe81a 100644 > --- a/kernel/sched/topology.c > +++ b/kernel/sched/topology.c > @@ -2337,7 +2337,7 @@ static struct sched_domain *build_sched_domain(struct sched_domain_topology_leve > > if (!cpumask_subset(sched_domain_span(child), > sched_domain_span(sd))) { > - pr_err("BUG: arch topology borken\n"); > + pr_err("BUG: arch topology broken\n"); This is intended. Please look up its meaning and see the earlier mails on lkml. > #ifdef CONFIG_SCHED_DEBUG > pr_err(" the %s domain not a subset of the %s domain\n", > child->name, sd->name); > diff --git a/kernel/sched/wait_bit.c b/kernel/sched/wait_bit.c > index b410b61ce..4197f5ed2 100644 > --- a/kernel/sched/wait_bit.c > +++ b/kernel/sched/wait_bit.c > @@ -204,7 +204,7 @@ EXPORT_SYMBOL(init_wait_var_entry); > * given variable to change. wait_var_event() can be waiting for an > * arbitrary condition to be true and associates that condition with an > * address. Calling wake_up_var() suggests that the condition has been > - * made true, but does not strictly require the condtion to use the > + * made true, but does not strictly require the condition to use the fine. > * address given. > * > * The wake-up is sent to tasks in a waitqueue selected by hash from a