From: Guenter Roeck <linux@roeck-us.net>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>,
jdelvare@suse.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, corbet@lwn.net, wenliang202407@163.com,
jre@pengutronix.de
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 3/4] hwmon: (ina238) Add ina238_config fields
Date: Fri, 29 Aug 2025 08:56:11 -0700 [thread overview]
Message-ID: <a3131832-414a-47c8-8dd3-93af7283c516@roeck-us.net> (raw)
In-Reply-To: <20250829030512.1179998-4-chris.packham@alliedtelesis.co.nz>
On 8/28/25 20:05, Chris Packham wrote:
> In preparation for adding INA780 support add some required fields to
> ina238_config and set the appropriate values for the existing chips.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>
> Notes:
> Changes in v3:
> - New. Split config struct changes from main patch
>
We should have fields for curent_lsb, power_lsb, and energy_lsb in both
struct ina238_config and struct ina238_data, and pre-calculate the values
for chips where it is dynamic. I started writing that code, but while
writing unit test code I found that the driver has more problems similar
to the one you fixed with an earlier patch of this series. We'll have to
address that first. I hope I can find and fix those issues over the weekend.
Guenter
next prev parent reply other threads:[~2025-08-29 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 3:05 [PATCH v3 0/4] hwmon: Add support for INA780 Chris Packham
2025-08-29 3:05 ` [PATCH v3 1/4] dt-bindings: hwmon: ti,ina2xx: Add INA780 device Chris Packham
2025-08-31 22:35 ` Guenter Roeck
2025-08-29 3:05 ` [PATCH v3 2/4] hwmon: (ina238) Correctly clamp temperature Chris Packham
2025-08-29 9:55 ` Guenter Roeck
2025-08-31 21:12 ` Chris Packham
2025-08-31 22:09 ` Guenter Roeck
2025-08-31 22:34 ` Guenter Roeck
2025-08-29 3:05 ` [PATCH v3 3/4] hwmon: (ina238) Add ina238_config fields Chris Packham
2025-08-29 15:56 ` Guenter Roeck [this message]
2025-08-29 3:05 ` [PATCH v3 4/4] hwmon: (ina238) Add support for INA780 Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3131832-414a-47c8-8dd3-93af7283c516@roeck-us.net \
--to=linux@roeck-us.net \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=jre@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wenliang202407@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®