From: Markus Elfring <Markus.Elfring@web.de>
To: Eric Dumazet <edumazet@google.com>,
netdev <netdev@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
Hideaki Yoshifuji <yoshfuji@linux-ipv6.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Aditya Pakki <pakki001@umn.edu>,
Kangjie Lu <kjlu@umn.edu>, Navid Emamdoost <emamd001@umn.edu>,
Stephen McCamant <smccaman@umn.edu>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: tcp: Checking a kmemdup() call in tcp_time_wait()
Date: Mon, 14 Oct 2019 19:19:27 +0200 [thread overview]
Message-ID: <a31967be-b59e-0da8-1119-633c4927a904@web.de> (raw)
In-Reply-To: <CANn89i+WzeMhCysz7QngWM7iMMv1GAuzVez0Gviiud5MZoKO-w@mail.gmail.com>
> This is coding style for newly submitted code.
>
> We do not refactor code to the latest coding style, this would cost a lot.
Were any update candidates left over also in this function implementation?
>> How do you think about to return an error code like “-ENOMEM” at this place?
>
> tcp_time_wait() is void,
Can the function return type be eventually changed?
> the caller won't care.
Will any other software developers (and source code reviewers) start to
care more for unchecked function calls?
> I told you time_wait is best effort.
Can this approach still be improved another bit?
> What is the problem you want to solve _exactly_ ?
I became curious if the software situation can be adjusted around
a possibly ignored return value from a call of a function like kmemdup().
Regards,
Markus
prev parent reply other threads:[~2019-10-14 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 14:51 Markus Elfring
2019-10-13 19:45 ` Eric Dumazet
2019-10-14 6:51 ` Markus Elfring
2019-10-14 12:33 ` Eric Dumazet
2019-10-14 12:50 ` Markus Elfring
2019-10-14 13:15 ` Eric Dumazet
2019-10-14 17:19 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a31967be-b59e-0da8-1119-633c4927a904@web.de \
--to=markus.elfring@web.de \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=emamd001@umn.edu \
--cc=eric.dumazet@gmail.com \
--cc=kafai@fb.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=smccaman@umn.edu \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®