From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A49233CEB0 for ; Sun, 17 May 2026 17:01:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779037296; cv=none; b=p2WOVg/cNvn2lhENz58/+9bl7lRFJ6DIHhv4CKoYwWOm8CS6lvw4vaDpa4vgtGE5m/X4X10mMunheGN1axAWn6LFpM5mHWk+qS/9n0uYmtNydD5y/UWO6I2D4Ck5CCBHchYxsGBEDaORWGAG2UFHWA+/YJGfrKl/zwNewPMIYMs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779037296; c=relaxed/simple; bh=97g/NdktaIsfmzcUs7B3fZAs/ud1qLpVVqapGtwmntw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Te4idU1VYO62hfGepjjdbvmpxNeuUrlouhw9CmMEWtKXBEs6+KABRX/EPb27w9dmNTaBwAEO1hyEMvm40sC6AsAL10SUvj9ohuELt8W5F/Q/pIUv9SuOA8g/p4IOEPcPE26GoUjvaDFzjBQ/XaBLUX1PxAed8aaC3XHtMXUn+28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DPSKucqd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QA8ZiHla; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DPSKucqd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QA8ZiHla" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64H5JS1Q2566976 for ; Sun, 17 May 2026 17:01:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +xRzeH96dtwyj2Z5WMwnZyLEFHICTIHnJvR10SSBCzg=; b=DPSKucqdOpkA8zhl f5TYHIXNv5YMsgwOibwUCJd6SE6lBZatsSAd4CQD8coNkgGneC0kxdkCCgIWxKFS j2zpDvOoIb8V+ha4eJfhW2bkTM6NxJ0W68Bd/Gc/6EmHA/jQBfgr1MGEQwyL99Qt SBWxRSlUNofr2ec1TNzbmW/1l+43Bbw+AuCoeyUuGYvKrzk+MyUs76NBP1gIJgT9 iu+g1xp+vf3X72gQByT1rPzC3eh4S2EmpTLTZpZCqrZQIl4f8OKuVTOXE+oz/0Lz Jgv1HteWLh+AevDerqNcIP8HQkzjHcLr34Jhkhg1U2p2Yu3eLzksg0L99jSmGk8r ICyNhA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e6gvqu7jk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 17 May 2026 17:01:34 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ba718173d1so38934335ad.0 for ; Sun, 17 May 2026 10:01:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779037293; x=1779642093; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+xRzeH96dtwyj2Z5WMwnZyLEFHICTIHnJvR10SSBCzg=; b=QA8ZiHla08Yxykdk5baymhBkGyn+nSsBHccjZsmlriV2cGCBqkuRrSGxvbi9uUbqZu ctFkBCVrRdkhnC21VFmSmnbgyrBPZSyO53FTxLX6YEo5wrJSNaeNHot2Q6Xcg9Dfz3z7 fjbGR2cR8kTVFMrtrbRAXwVt0q4cbfDVo1FsRaMoS6tZCiaoLw2YDlZ52SY8EHnxL7ur wmr7ldWe22bm+vFpAgtxONiY5356etYGYhccW8yqgQVeczuiqBcidgQ1h4OgP8BT2HDc aYTC2VzZJZs4IeBgWrKQzPzyrwaei+9YDsFHRth6Lqh5HmSjAx4L2386oRLZ9GZqqGj7 gN8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779037293; x=1779642093; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+xRzeH96dtwyj2Z5WMwnZyLEFHICTIHnJvR10SSBCzg=; b=KUSDi+GxujEk/woSTOtZDCElv9h9xgmLYwphyHykxXzaGV/+hKN4qKH1X+VjMP2CDQ bA9THtbIQPpnijxbi5wsJsldilxk2t9kyqO63/etV91MBbF5SH7HY9kg8x5w2do4c4JL OIdb+oFDMHpAdQMq8U07fVABQEjZGSYE+j4mwesxKNkYZ6jMQ2nlCD9Joj2E+CQWzCq4 j0CIr2Fk2qMu+hVTjkq83Cb59qizJ2JqlJD6LV3KFJ1A2rj5BwcaENl3qndhwraAvJsx 5f/nsF64KuYpsS3h2ob1pFnLieZhnJ643dqlLym2cstK1TukTwcpJD/kCPFFOFhVK7YJ G9mQ== X-Forwarded-Encrypted: i=1; AFNElJ+PXVhxGfmoA16PNhfSWEzndnp/m4BIFhLjeOg2z6YIJZXqVURRHKAbFy2J8/vD0E0WWwm0CoQ12chXEC4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0uXpvlErpnwG6z23rORpLdlJM3ACQJUdMCUD3DHqtO/4CSmMp s9te1mLHwoImfWdbK9jZzzGriOPbbDG7FxI5kmqu/NxHABG13gHHCmjqtTz6cs/ZpI+fWgoGppV WIHAVyc6Ow8hjKm94cNnHx/n7nwAopXymD8ko4vU7XqXvaiOI9FaQESwdM/lH/BSYExY= X-Gm-Gg: Acq92OE9RkgNfanBd+F3y8irVW1AGAhQe95hTrbWKID8sziRbjmm8tnnMmWAqIKy2Kx FAWCcHxzD0AaYM3VPPIdGJ1F62qlGJQrbiQO9GVcrT0DVwtvTJ4ltVCtpFQQigpUuaDKyUAe6mM 1IBGYICohBog9cK8BquPD5iz2NnFBFHRyBnUrUoUWlfvUwtRlakrgg2z6qcnUcMImtUJZk/d7CF 3KQN7FvTc/d3nBDgkLmzzL/498Vvklsc8s6WyU2ZYEPmGlKS8NWTs/j20eSxi0Fq7kVva8nonFO 8UyiLqLZOBlrtTkOMNDftiky1+KcKduPdq4Zo4LbXsotcNtLcE2G/uvXSUa21QlvaEN6Jl4ybHU lBjrR0VrbKzJ3p2XwOViXbnhJ/wIlSflgOZNRIvIFBaplx6KOReA= X-Received: by 2002:a17:903:240e:b0:2bd:3bfd:74f2 with SMTP id d9443c01a7336-2bd7e831c89mr127658515ad.10.1779037293141; Sun, 17 May 2026 10:01:33 -0700 (PDT) X-Received: by 2002:a17:903:240e:b0:2bd:3bfd:74f2 with SMTP id d9443c01a7336-2bd7e831c89mr127657885ad.10.1779037292600; Sun, 17 May 2026 10:01:32 -0700 (PDT) Received: from [192.168.29.166] ([49.43.235.85]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5c0600a4sm115580535ad.30.2026.05.17.10.01.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 May 2026 10:01:32 -0700 (PDT) Message-ID: Date: Sun, 17 May 2026 22:31:24 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] dt-bindings: arm: qcom: Document Shikra and its EVK boards To: Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Neil Armstrong , Wesley Cheng , Ulf Hansson , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-mmc@vger.kernel.org References: <20260512-shikra-dt-v1-0-716438330dd0@oss.qualcomm.com> <20260512-shikra-dt-v1-1-716438330dd0@oss.qualcomm.com> <20260515-pumpkin-cuscus-of-expression-cec1ea@quoll> Content-Language: en-US From: Komal Bajaj In-Reply-To: <20260515-pumpkin-cuscus-of-expression-cec1ea@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 4M3dPPhLy4QPAEKEHia5JtmOVQ34rScV X-Proofpoint-ORIG-GUID: 4M3dPPhLy4QPAEKEHia5JtmOVQ34rScV X-Authority-Analysis: v=2.4 cv=LKJWhpW9 c=1 sm=1 tr=0 ts=6a09f46e cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=g4/7f0GlZvY0MGcqtTB0Sw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=QP8ThlpALwkLgMcBQ0MA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE3MDE4NCBTYWx0ZWRfX2o+wlAVlARLU T5AV6+TaB7IL4LwVUuI93h5eymUy/TjZE37VQCwvp0/xSHztb55lNyjzGpQozP9e04qNWP3ZHIp WXk56ZgBaxFkv3KbNqyh4V1xRsI7oUsAjj+lUHQmUxPQqbhY+f1mNVgvq5gr3bBNT8ci91RQ749 llJRpZULCzjLN3vN5fN0GRfepveerAlnR/qMUk/DNsMRvumcMWNgPdu8MpRWeVtUCvA4POWz1zA eyob1N8PlqnIxCO+vfxT1avR7Jv/adgdOnpDR8yNWZZk6J0iCM6yWOcb4KmKrvCsKCuFpnXqrLF 7LZNG2GXkeiwG9s2s5YlhbnGKa1q9yfze/8A1HtQXiKYkF2YZYnajSlbdIb6OvC94BkzL9ndFOo sOBYtJjClr+qpZuFWxtskmxSdMzNH9QCSDwydHOrSiWjmYFZZiy9cmSQRPGErN9oUCUlViItqDE Qc0Qp0Wll9/Gvvc3RtQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-17_04,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 spamscore=0 adultscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605170184 On 5/15/2026 2:21 PM, Krzysztof Kozlowski wrote: > On Tue, May 12, 2026 at 09:38:04AM +0530, Komal Bajaj wrote: >> Shikra is a Qualcomm IoT SoC available in a System-on-Module (SoM) >> form factor. The SoM integrates the Shikra SoC, PMICs, and essential >> passives, and is designed to be mounted on carrier boards. >> >> One SoM variant is introduced: >> - CQM: retail variant with integrated modem (PM4125 PMIC) >> >> Two EVK boards are supported: >> - shikra-cqm-evk: pairs with the CQM SoM >> - shikra-cqs-evk: pairs with the CQM SoM, with no modem support > s/CQM/CQS/ Right, will fix this typo. > > but anyway I would prefer to use full product names from > include/dt-bindings/arm/qcom,ids.h (so CQXXXXM). Sure, I'll update both CQM and CQS to their corresponding full name. > >> Each EVK provides debug UART, USB, and other peripheral interfaces. >> >> Add compatible strings for the CQM SoM variant and its two >> corresponding EVK boards. >> >> Signed-off-by: Komal Bajaj >> --- >> Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >> index 2741c07e9f41..f041d71d7957 100644 >> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >> @@ -963,6 +963,13 @@ properties: >> - const: qcom,qcs9100 >> - const: qcom,sa8775p >> >> + - items: >> + - enum: >> + - qcom,shikra-cqm-evk >> + - qcom,shikra-cqs-evk >> + - const: qcom,shikra-cqm-som > This is not accurate. The SoM has physically different SoC - either CQM > or CQS. You either need two lists, like Toradex is doing (e.g. > toradex,verdin-imx95), or enum in the middle of the lists, like Renesas > is doing (e.g. renesas,rzt2h-evk). > > I prefer the first option, so Toradex choice. > > But for sure you do not get the third solution... Really, you are not > supposed to invent these things, but look at existing solutions (and I > was mentioning Toradex during internal meetings whenever someone asked > me how the SoM and carrier should be organized). Sure, I’ll follow the Toradex approach and restructure this with separate compatible lists for each EVK/SoM combination, as below: - items:       - enum:           - qcom,shikra-cqm-evk       - const: qcom,shikra-cqm-som       - const: qcom,shikra   - items:       - enum:           - qcom,shikra-cqs-evk       - const: qcom,shikra-cqs-som       - const: qcom,shikra Thanks Komal