From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750929AbdE2HpW (ORCPT ); Mon, 29 May 2017 03:45:22 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:37361 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750838AbdE2HpV (ORCPT ); Mon, 29 May 2017 03:45:21 -0400 Subject: Re: [PATCH] clocksource/drivers/fttmr010: Fix aspeed-2500 initialization To: Andrew Jeffery Cc: joel@jms.id.au, ryan_chen@aspeedtech.com, mark.rutland@arm.com, linus.walleij@linaro.org, jonas.jensen@gmail.com, Thomas Gleixner , "open list:CLOCKSOURCE, CLOCKEVENT DRIVERS" References: <1495761138.7794.11.camel@aj.id.au> <1495788523-26051-1-git-send-email-daniel.lezcano@linaro.org> <1496037951.8159.0.camel@aj.id.au> From: Daniel Lezcano Message-ID: Date: Mon, 29 May 2017 09:45:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1496037951.8159.0.camel@aj.id.au> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/05/2017 08:05, Andrew Jeffery wrote: > On Fri, 2017-05-26 at 10:48 +0200, Daniel Lezcano wrote: >> The recent changes made the fttmr010 to be more generic and support different >> timers with a very few differences like moxart or aspeed. >> >> The aspeed timer uses a countdown and there is a test against the aspeed2400 >> compatible string to set a flag. >> >> With the previous patch, we added the aspeed2500 compatible string but without >> taking care of setting the countdown flag. >> >> Fix this by specifiying a init function and pass the aspeed flag to a common >> init function. >> >> Signed-off-by: Daniel Lezcano > > Tested-by: Andrew Jeffery > Reviewed-by: Andrew Jeffery > Thanks for testing. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog