From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 382571AF0A1 for ; Mon, 25 Nov 2024 14:24:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732544669; cv=none; b=MtUybdfo5n78Sku6OfQVMg5aEKSOc96WVxMQk6ZjQ3zo0NzKIPhSLJSa72Dsh9xHpCEhx++OL2ynO1+9EL+4o7EBLna/8UcfI/ehqnbIPGa9VlxzERZtpcOUU+0Sf+9xHjM1YDpSL75YiWOEWa6xK0VhASgh6N8ScIfNCF79SzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732544669; c=relaxed/simple; bh=PAApblf5/yOuk9I4BzfC+hcjl0lxlkL+IWpwS5snJeE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OkWwpxElgZZ48GBOBVKX6XEqbJWPbtqL+938fs1AiPh17PnZJMfSy5DYJ9tkHRtiFxKF9vqnsHF4jaCLn4hhlfPZh9G2w/6dcJ6kHOPGomBg+8KFaY7uxGC1Ymz3uq3YOk436m5Zlfb6VcTCQT9TwV/tDsESUBZxx9EfrE0Rkg4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RWul6A7Z; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RWul6A7Z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732544666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OAej4OPlBRSwRD5hkCmUtBDLkFXG4Wh3poAJBOLJFhM=; b=RWul6A7ZYPPS8a2sxq+lD/MpD4oDa82ZEkOV+ptOGHhLYQd/5+eeBu+KOn42yKvDsIjd66 ES0vimhSfPzr9jPI10mpPmt9tolwuhlEn+9Uy401L9mXlSw7HoLTweMGLo4BibkWh8R/hX t8ZDjAd1HY9D3q8LwJNdryT08nDVRhw= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-381-IgkAagQ3PAaiDPT0SfWkzw-1; Mon, 25 Nov 2024 09:24:24 -0500 X-MC-Unique: IgkAagQ3PAaiDPT0SfWkzw-1 X-Mimecast-MFC-AGG-ID: IgkAagQ3PAaiDPT0SfWkzw Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-aa52bfbdfebso167458466b.3 for ; Mon, 25 Nov 2024 06:24:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732544663; x=1733149463; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OAej4OPlBRSwRD5hkCmUtBDLkFXG4Wh3poAJBOLJFhM=; b=nsFmz3fjwTyDeBZGYVSnO8KJJ7eus2Iv8Ne5wjrfboZcnBGH1ZnbvOZc5m0SrCaQX+ tDTFzZG4MBc8AIAvk6gptEVxS5M5LKjDo4VVxuUwloygWer/4gjAuawLxrE+WgvbLOYh mE6YfMAO5vaOcVy2uD6FuL0+SpjV+alttua5LZM6Ks3OStAH/GgGz7jgXD+qEP/JlMTZ MyFJJ/+jdkYH3Wz9g9mYrAEQ7eE61E5enejj8lD5LD+8+IRSgE/8R5lV6wssMkAA4IbD +QqyVwJEZZfsEfogiP/j+UF/MbvCkxUa5W+M+WysJWwLz0uoCXNmLc3nqfoXqJcA3ryA 6HyA== X-Forwarded-Encrypted: i=1; AJvYcCUbHe8A0JEVh5yJJl7K3/qgTD4CIEthuI2fq5W61LZpx4UB90UX9zqXXJbGy2M1IbOWB4K+PSYukFMT1CM=@vger.kernel.org X-Gm-Message-State: AOJu0YyCA+PJ7fmTUMHC/QZj72MII0P4lBmFN8ws1o522fFPTsYsxeCJ 86RhmxV33zM5wZ9ozelEhY9UTdxvb/fJGWNmdchr5ywGECpVqXUnOfDzkfKqPV0U0KQT3abiBwa 2DOIWlw3e+m/0dUI8UfZM+Y8AgTR74giiTWy6vBM2kRRUAer2hLKrZ2q923aPLg== X-Gm-Gg: ASbGncsgDlIrbPfRExLSxlINsFlqw1x5+FSzJPgbi92/g+Sps3983nJXizl1Px/31UU HMbTVPeyAH92lwVvuCVfGdtcFnJK5T/WaO26G22Y+scjNaWQUEv0X1VW9Q9OolCg7Fdo0XCTONH LHwG8LLcBhHsutNi2MESYmWPz4ZU1hMjmZIci5x3noEQduK7ulOP1ZTMlORwnOxPvWXPeiu5jni UMdtj6fL/4Csgy/1uA5vlemFI4OzREQCHkJGIUXy5dJCTtXwT77qR1ce/AHg4DIRqRhyGDV+JfC 77N2e31aUT6GZhmsTbyiwZOF64cM8CgN2BrWlXZ7LYvHEBGCNFiNq4OM0MVohQJvo52h778uqvs ugoW0srDmmHuLpZtU8OHe2Szk X-Received: by 2002:a17:906:3194:b0:aa5:274b:60ee with SMTP id a640c23a62f3a-aa5274b69famr1018207466b.39.1732544663471; Mon, 25 Nov 2024 06:24:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHoGDD47dfwy9wZFvAqX4WMcfksgKqNJCU6tx7BOnVPBVTlVWMX5EUDMfzlOkKD2trMBOUnQw== X-Received: by 2002:a17:906:3194:b0:aa5:274b:60ee with SMTP id a640c23a62f3a-aa5274b69famr1018205166b.39.1732544663087; Mon, 25 Nov 2024 06:24:23 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa537b4eae7sm302808966b.99.2024.11.25.06.24.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Nov 2024 06:24:22 -0800 (PST) Message-ID: Date: Mon, 25 Nov 2024 15:24:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/2] media: uvcvideo: Support partial control reads and minor changes To: Ricardo Ribalda , Laurent Pinchart , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Sakari Ailus , stable@vger.kernel.org References: <20241120-uvc-readless-v4-0-4672dbef3d46@chromium.org> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20241120-uvc-readless-v4-0-4672dbef3d46@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Ricardo, On 20-Nov-24 4:26 PM, Ricardo Ribalda wrote: > Some cameras do not return all the bytes requested from a control > if it can fit in less bytes. Eg: returning 0xab instead of 0x00ab. > Support these devices. > > Also, now that we are at it, improve uvc_query_ctrl() logging. > > Signed-off-by: Ricardo Ribalda Thank you for your patches, I have pushed both patches to: https://gitlab.freedesktop.org/linux-media/users/uvc/-/commits/next/ now. Regards, Hans > --- > Changes in v4: > - Improve comment. > - Keep old likely(ret == size) > - Link to v3: https://lore.kernel.org/r/20241118-uvc-readless-v3-0-d97c1a3084d0@chromium.org > > Changes in v3: > - Improve documentation. > - Do not change return sequence. > - Use dev_ratelimit and dev_warn_once > - Link to v2: https://lore.kernel.org/r/20241008-uvc-readless-v2-0-04d9d51aee56@chromium.org > > Changes in v2: > - Rewrite error handling (Thanks Sakari) > - Discard 2/3. It is not needed after rewriting the error handling. > - Link to v1: https://lore.kernel.org/r/20241008-uvc-readless-v1-0-042ac4581f44@chromium.org > > --- > Ricardo Ribalda (2): > media: uvcvideo: Support partial control reads > media: uvcvideo: Add more logging to uvc_query_ctrl() > > drivers/media/usb/uvc/uvc_video.c | 22 +++++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > --- > base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc > change-id: 20241008-uvc-readless-23f9b8cad0b3 > > Best regards,