From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934982AbdKPNkg (ORCPT ); Thu, 16 Nov 2017 08:40:36 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:33874 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934951AbdKPNkQ (ORCPT ); Thu, 16 Nov 2017 08:40:16 -0500 X-Google-Smtp-Source: AGs4zMYQBH0qYHWG9csjWcFGCmaFeAw8hptV8aM74DB9+o3cOOQ4c6ucrhFBZS5uXCr98c0gYx6H6Q== Subject: Re: [PATCH v7 02/13] dt-bindings: Add SLIMbus bindings To: Vinod Koul Cc: gregkh@linuxfoundation.org, broonie@kernel.org, alsa-devel@alsa-project.org, sdharia@codeaurora.org, bp@suse.de, poeschel@lemonage.de, treding@nvidia.com, andreas.noever@gmail.com, alan@linux.intel.com, mathieu.poirier@linaro.org, daniel@ffwll.ch, jkosina@suse.cz, sharon.dvir1@mail.huji.ac.il, joe@perches.com, davem@davemloft.net, james.hogan@imgtec.com, michael.opdenacker@free-electrons.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, arnd@arndb.de References: <20171115141043.29202-1-srinivas.kandagatla@linaro.org> <20171115141043.29202-3-srinivas.kandagatla@linaro.org> <20171116130914.GU3187@localhost> From: Srinivas Kandagatla Message-ID: Date: Thu, 16 Nov 2017 13:40:13 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171116130914.GU3187@localhost> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for the review comments. On 16/11/17 13:09, Vinod Koul wrote: > On Wed, Nov 15, 2017 at 02:10:32PM +0000, srinivas.kandagatla@linaro.org wrote: >> From: Sagar Dharia > >> + >> +Child nodes: >> +Every SLIMbus controller node can contain zero or more child nodes >> +representing slave devices on the bus. Every SLIMbus slave device is >> +uniquely determined by the enumeration address containing 4 fields: >> +Manufacturer ID, Product code, Device index, and Instance value for >> +the device. >> +If child node is not present and it is instantiated after device >> +discovery (slave device reporting itself present). > > So you allow the devices to work even if the respective firmware description > is absent? Yes, As SLIMbus itself itself is discoverable bus. > >> + >> +In some cases it may be necessary to describe non-probeable device >> +details such as non-standard ways of powering up a device. In >> +such cases, child nodes for those devices will be present as >> +slaves of the slimbus-controller, as detailed below. >> + >> +Required property for SLIMbus child node if it is present: >> +- reg - Should be ('Device index', 'Instance ID') from SLIMbus >> + Enumeration Address. >> + Device Index Uniquely identifies multiple Devices within >> + a single Component. >> + Instance ID Is for the cases where multiple Devices of the >> + same type or Class are attached to the bus. >> + >> +- compatible -"slimMID,PID". The textual representation of Manufacturer ID, >> + Product Code, shall be in lower case hexadecimal with leading >> + zeroes suppressed >> + >> + codec: wcd9310@1,0{ >> + compatible = "slim217,60"; >> + reg = <1 0>; >> + }; >> + }; > > Pardon my ignorance as I am not very familiar with DT nodes, but where are > the Manufacturer ID, Product code, Device index, and Instance values here? Manfacturer ID and Product code is part of compatible string Device index and Instance value are part of reg. >