From: Ivo Van Doorn <ivdoorn@gmail.com>
To: rt2x00 Users List <users@rt2x00.serialmonkey.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [rt2x00-users] [PATCH RFC] rt2500usb: disable broken HW encryption by default
Date: Mon, 22 Mar 2010 16:10:07 +0100 [thread overview]
Message-ID: <a32f33a41003220810r3da5a8d3mb4e884fdef03eb89@mail.gmail.com> (raw)
In-Reply-To: <201003221601.36559.linux@rainbow-software.org>
On Mon, Mar 22, 2010 at 4:01 PM, Ondrej Zary <linux@rainbow-software.org> wrote:
> Since HW encryption was added to rt2500usb in 2.6.29, the driver does not
> work. It has been discussed before but never solved:
> http://rt2x00.serialmonkey.com/phpBB/viewtopic.php?f=4&t=4834
> https://bugzilla.redhat.com/show_bug.cgi?id=484888
>
> The problem is caused by this patch:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=dddfb478b26e29a2b47f655ec219e743b8111015
>
> Disable HW encryption by default to fix it.
>
>
> --- linux-2.6.34-rc2-orig/drivers/net/wireless/rt2x00/rt2500usb.c 2010-03-20 02:17:57.000000000 +0100
> +++ linux-2.6.34-rc2/drivers/net/wireless/rt2x00/rt2500usb.c 2010-03-22 15:40:39.000000000 +0100
> @@ -36,11 +36,11 @@
> #include "rt2500usb.h"
>
> /*
> - * Allow hardware encryption to be disabled.
> + * Allow hardware encryption to be enabled.
> */
> -static int modparam_nohwcrypt = 0;
> -module_param_named(nohwcrypt, modparam_nohwcrypt, bool, S_IRUGO);
> -MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption.");
> +static int modparam_hwcrypt = 0;
> +module_param_named(hwcrypt, modparam_hwcrypt, bool, S_IRUGO);
> +MODULE_PARM_DESC(hwcrypt, "Enable hardware encryption.");
Large patch for something which can be done much simpler. How about:
static int modparam_nohwcrypt = 1
That way the module parameter does not have to be renamed, so current
configurations and documentation do not have to be changed. The name
remains consistent with the other rt2x00 modules (and the other
mac80211 modules for that matter).
But I though it was mentioned that disabling HW crypto didn't solve
the issue due to a second bug in a later kernel?
Ivo
next prev parent reply other threads:[~2010-03-22 15:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 15:01 Ondrej Zary
2010-03-22 15:10 ` Ivo Van Doorn [this message]
2010-03-22 15:30 ` [rt2x00-users] " Ondrej Zary
2010-03-22 15:40 ` Ivo Van Doorn
2010-03-23 9:27 ` Ondrej Zary
2010-03-23 9:36 ` Ivo Van Doorn
2010-03-23 15:09 ` Ondrej Zary
2010-03-23 15:15 ` Ivo Van Doorn
2010-03-24 13:12 ` Ondrej Zary
2010-03-24 13:24 ` Ivo Van Doorn
2010-03-24 14:52 ` Ondrej Zary
2010-03-26 11:05 ` Ondrej Zary
2010-03-23 15:41 ` Gertjan van Wingerde
2010-03-24 13:10 ` Ondrej Zary
2010-03-24 22:07 ` [PATCH] rt2500usb: improve powersaving reliability Ondrej Zary
2010-03-24 22:15 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a32f33a41003220810r3da5a8d3mb4e884fdef03eb89@mail.gmail.com \
--to=ivdoorn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome