From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 773801DF73A for ; Mon, 11 May 2026 04:39:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778474371; cv=none; b=bVrglF+iqbJ3MkaCZGQ683mmhu4tdOwrmg4l3DTFl1b0QGwMU3D1jaqwJfdOPT6eMa3ZvQdrKTb+xUKLnEd7scG8GPy7JTZzAh1cqQK3MwGtGrs9bVtdN4FcPZDQifqkuijTfBbF8OaJtJMj9vmpcGl11CT2LR8sQDYwmaS6rHw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778474371; c=relaxed/simple; bh=izNnPT+eNzP59mu8K4DU07JedWp6qBsFDKJ7LKHXwGQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iFYZS+rRGpyBog0uj8c3kj6sjCcpUjXyVYy/dhlIr4zLz2dSbYUSlIg2/PEnqxKU9QvUNBIfYOFEP4jZqTTbYsYJsNquCkuAuE4slhwBGVqBmOVRdWCF9AQ9cRacsx1pDQWuNHXlXMtCC5OrQptk+n7hSNPRSEpt1j/35CoVgQE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iHLIvmKi; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iHLIvmKi" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-2f00a567cfaso2727087eec.0 for ; Sun, 10 May 2026 21:39:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778474369; x=1779079169; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=tFr4ml37iSH7JGVpUrmmoc3/4vkicmtMRvXpv60p2Jw=; b=iHLIvmKi7fLtgKlcRueM3cmSU/rx+hJ3sZzbvzQAWYHyYSEyvZ8aRSiRtotNI8URBp dy2cOx65rc9txe5TDsRsta23QlkN8Vq3T1jwJmhXp/xlxrE0VR4nvu/NwleO519cdZmO 6c9XRLoQrWfrNJc5VkNL9LLYnutqe4J7N4vMT5pcDul1kKX+/KUrYcFal4+GrFYSPgC2 nFBNA+WaHTMbt91J5mTRaQax5hRQPPy08xjZPC93O8fFbEaBXjicJlm9Dcaqsr8iv5jl 3QMn84RLohm0ZAfSp8/KbIptGDKZ/7wifO1gsiCN7sEnTUUYp1FUQuXoDOXfUGpOelKb l4Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778474369; x=1779079169; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tFr4ml37iSH7JGVpUrmmoc3/4vkicmtMRvXpv60p2Jw=; b=MXJHEF8p2C67PdVDU5mx+LARZVEFAY/1Vc8JlgbkcCZGpDnZ4fp0LL2dN7F5GI5sMH 5BEPjD9+xs9+p7vdEvFRZM3bjp7zUke6cIaJr5EXaMO4hQAJErbzP1YBEafBi7rY90/U /TaDwPo4RsWJjyMJAqZ7lVhHZbisvKhEvjr3On6GHz4AStkYegdw/Uvc9+2Pp9j6QlHZ fassf7mvauBWIyRssPwampng7q/c3rNR6Q+mpHdfoirsBjHdQfzrNq56NNOu6p0y2Tr8 ZKOJy0kjhlT+6rXWkLZ3inDGmsvqh+VAoxAM3+0dc4zL7N/0xZY0oEpHicm5kdJ8P1mH ijhA== X-Forwarded-Encrypted: i=1; AFNElJ/+jYUph+eavqLqgoRZMvLdLcGd8q650cx4eHdHZT9zjjxO+peCW3voLyjimFo3mXY2DZ7iykBVL9Cq5ps=@vger.kernel.org X-Gm-Message-State: AOJu0YwioajJMkiGgggSApbqviZSGzRqeXS6qsH9PCY6KjYzChGoFuCH JLzOjlbtyFfis9jpo7WEeYJ5tbo2bLea+FzqnqGdfh9vXRdaV+7T+tOX X-Gm-Gg: Acq92OG82uzj+Cy6ABAqonzcfUH6ShrsK1Q5zuU7UpNvw0SN7zqGHPiwgVZPq2KKvVL 5y3TEzDQLD5aqdl9kxZZ7jJrkaIgcGiSvis/Yw0+eSEfhZyV0+9rc1DQuItZgwWworptlaGYrnK 3G92xgIMPrgrNyjuu0kxfE04sdZvG8zLbbkLJrhBjUxay4PIsDYF1PkBePYCqcGbj9jF9qO/DHB HoP0lXM60F2lyFu8Kbi0vjidA8mzSNm5lh0Zdu2yHNLDIPrO3E+0IDWfq0mrXSO1PBAphDpwTqH kRD3+KSy1JexDoGJ8AlODXjrK4xaBBPl0vVv0+7aW3Q0QQ6lStoD26QcL4Z4/N9ItebBAbNPc8F TZaLqwnXSYSwfXHx4n2LKlYwB6nio6zrGaU4d6Ju7oX+FtpvGRRldivw+qB9sfmuWWv6qcy7SP7 zloXd3gIDdIw+9V9sXlxSq7E7mvcN9+b/TyZ2SPUQwhvPy3MVf9ctT3/tlYqtTQthmTMguK9Vq3 jIKsDXoV0M= X-Received: by 2002:a05:7301:4186:b0:2c0:df3b:ec1e with SMTP id 5a478bee46e88-2f6e3f9012amr6554095eec.11.1778474368600; Sun, 10 May 2026 21:39:28 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f8893441absm16042011eec.31.2026.05.10.21.39.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 May 2026 21:39:28 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Sun, 10 May 2026 21:39:26 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] watchdog: wdt_pci: Fix shared IRQ storm and complete system lockup To: w15303746062 Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Mingyu Wang <25181214217@stu.xidian.edu.cn> References: <20260509121655.275311-1-w15303746062@163.com> <1fc8bb5a.1346.19e14a548fb.Coremail.w15303746062@163.com> <5acea672-0550-478e-8f49-e5e43c72d7e2@roeck-us.net> <15f8c180.3519.19e1501ebbc.Coremail.w15303746062@163.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <15f8c180.3519.19e1501ebbc.Coremail.w15303746062@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 5/10/26 20:08, w15303746062 wrote: > > > From: Mingyu Wang <25181214217@stu.xidian.edu.cn> > > Hi Guenter, > > You are correct; standard QEMU does not support the WDT500/501. > > We observed this issue using DevGen, an automated framework we are developing. It synthesizes QEMU virtual device models directly from Linux driver source code using LLM guidance, allowing us to fuzz legacy or obscure drivers that lack physical hardware or official emulators. > > Because the synthesized device is an imperfect model, it generated unexpected interrupt loads on a heavily shared PCI IRQ line (shared with the i2c-i801 controller in our setup). However, this successfully exposed a real logic flaw: the `wdt_pci` driver registers an `IRQF_SHARED` handler but fails to verify the `WDC_SR_IRQ` bit. It erroneously claimed the interrupts, bypassed the kernel's spurious IRQ defenses, and caused a livelock. > > I understand this hardware is essentially obsolete. The patch provides a purely defensive fix for a legitimate API violation (unverified shared IRQ). > > If applying this adds unnecessary churn, please feel free to drop it, or perhaps consider marking the driver as BROKEN. I leave it entirely to your judgment. > That is entirely not the problem. The problem is that your AI implemented a QEMU emulation without really knowing what the hardware is doing while guessing what status bits unused by the driver mean for the real hardware. We (and the AI) actually don't know what the WDC_SR_IRQ does, or if it is indeed low active. That is just a guess. I can not accept a patch based on a guess, much less one making unconfirmed claims. If the driver is indeed unused or obsolete is a completely different question. Marking it as BROKEN without real evidence that it is indeed broken, just because some AI believes that it is broken, would be inappropriate. Please note that I also find the patch description inappropriate and misleading. It suggests that the problem was observed on real hardware, while it was actually observed with a qemu implementation implemented by AI based on the driver itself, including guesswork about status bits unused by the driver. Guenter