From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AF43253F1A for ; Mon, 25 Aug 2025 12:03:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756123384; cv=none; b=myslxbe3PciZEQikk9vtav/bbzGcMz0pUapgKX0z32ND4P6TkkpvyGHBGzm/8uSVIYzXC/fSRyKl6syF8U8WClLFvsLIPw4RntXWEfBrGWlA2dTjjxEvQDKBKXU5H/HcuhO6qg8YV1pr1qiKexo3LI99YcpOmc7UXDHboJlRCrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756123384; c=relaxed/simple; bh=ZlhfK0/2P69P87bEUDsxJDEFjTWF1f/6DouDWwcAwS8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RwqWEY9Jh3RpOgUe8iPXToz/MXkBlto+6I5oYezLgDpPObHN5k69VDmIiiethTKTF8g4kF38blS4f1JTkpeo007Y0oKFDCIF/WbC9Ov3F3Mnef2pjEpqfFboHXitIlBsJQ3eoUMv9l5qtA5UaS2Z2dmevlS/9ZChtsI7RR6kNuQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Z6pfJwqb; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Z6pfJwqb" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-afcb7ab87ffso49817366b.3 for ; Mon, 25 Aug 2025 05:03:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756123381; x=1756728181; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Mf2mRUvQjEaytK6URbb7jtr9FhugXWYARb3EBCriAq8=; b=Z6pfJwqbfiHq3GLoac4kCBMvI1CmfwXQpFXAOAq/wj8Fi6MSNDzXjxV4hBXgyofizJ uyw2J5IRYJqcuZMv9MnQzoIz2yZ/cfFir35r9TEl/wEZFw36wibJoRSjHTNztMRNII21 0WJMGORd9xucVbxpuOMITPB2JBWOsITWi4aDKysYtyKWY1ygkIhE15lapcuHMTZtYl6L o1ENHP8iQNKgt0L102odXawYa+/y9+zU+nhi35npM8G68c4X8YUA7RBwpoDFY74GLMIB zG4eJBC5GfWZLWLCIa1aKeidPOoBAP986swiwVx5sb75I48wwJlktfsyvGNRwxFmJ5g9 FYuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756123381; x=1756728181; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Mf2mRUvQjEaytK6URbb7jtr9FhugXWYARb3EBCriAq8=; b=WslsE06HJiAPditIXABAkBt4i3AZ6P+FKqY4sTUAx7Z/QGR0bKVTDBFSL7qUjXU4xt G+hyDggaA/AFXk1OUmMpp258IwR+BAm6JTSwCizsWXGdk3LOaRTobA98pl139L2MpTRu RWNSod/DXWxlBfKqkRh+o0+otzEldClFoeuHm8IfTWIhKoIr+Rf9cTDj3HsThMWSETBQ KaMPRjM+kFTHlFRhI1S04Q7bweAVYuCS7Dm2EkVf/FSXQQ7ZYS02rbRa7Z5Ojc70Tw71 UvptZkkObHPeZeMZO7QSOZUCic1NdIseQ+FYMBBWauffaEOhdS3q0iz3xG0dugN3LGQ2 BiVA== X-Forwarded-Encrypted: i=1; AJvYcCVxSjgaPK0zz9HjriimTyTlmpf8KyFP6pdqX/lsAIDqgPV6ZRZc6VUii2c/a18fkdvpnEk76MwcU1qYVf8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0rCBgHEPKsblE0CWtrhFB/U8kyJfFkt/bNXezXcBa7Y9NdwRd Pps13MsgzilVA25oC96Q+6WyDgIvqTi8cEZSShGXxmjFb6Ogy+RO2tezVqojLmJm9ck= X-Gm-Gg: ASbGnctK81bN1NcjQsJRnJqVWpYhqhkyFox0mLTAQsXsmYQdDTYSlxKRWfHSBzzFOuy 58F/KfqVvrKKej2rBZ8AHbPFJFAQEww8tiuInjnxkmxKCII2rGTqwFrihDmAyg/mQ850pq7Xtm7 +dht7ToGxt+uK1yp7gVb1q2VGMSizjGk1+osPCuKIP8YkZUyyIWrOGUYxERtsAuGFPawB5wrYUP HNKR7ye5qoAqopyA1Tl6g1RQH7OQkIEvOdD8Zlp1BTaNZmvqaIojI2IoOb3kJkbsKLkU9xLHGjI x83mTNfSRdCL+R1WarNEt7OJtATxb2GxpVZrF2jdoJXp1v9PCMKgUKBxY2p+UI86XwB3Ul84CF6 VMfbuIfQcOXzLxo7gW0hD6htmcz4VbsBd+MuIxk57 X-Google-Smtp-Source: AGHT+IEcBuCR6/r62UtCPJs3co2BNMFrVufjLm66B/o1rQQRjxpq5swzg4+kfnX48ZQUbQibdBprzw== X-Received: by 2002:a17:906:64d:b0:afe:7575:df0e with SMTP id a640c23a62f3a-afe7575e61fmr190506266b.11.1756123381153; Mon, 25 Aug 2025 05:03:01 -0700 (PDT) Received: from [10.41.1.12] ([213.244.170.152]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe48fc3d82sm538000466b.44.2025.08.25.05.02.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Aug 2025 05:03:00 -0700 (PDT) Message-ID: Date: Mon, 25 Aug 2025 14:02:56 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: dt-bindings: qcom,sm8550-iris: Do not reference legacy venus properties To: Mukesh Ojha Cc: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250823155349.22344-2-krzysztof.kozlowski@linaro.org> <20250825113734.iekrgyvctamhb5y7@hu-mojha-hyd.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+AhsD BQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmgXUEoF CRaWdJoACgkQG5NDfTtBYpudig/+Inb3Kjx1B7w2IpPKmpCT20QQQstx14Wi+rh2FcnV6+/9 tyHtYwdirraBGGerrNY1c14MX0Tsmzqu9NyZ43heQB2uJuQb35rmI4dn1G+ZH0BD7cwR+M9m lSV9YlF7z3Ycz2zHjxL1QXBVvwJRyE0sCIoe+0O9AW9Xj8L/dmvmRfDdtRhYVGyU7fze+lsH 1pXaq9fdef8QsAETCg5q0zxD+VS+OoZFx4ZtFqvzmhCs0eFvM7gNqiyczeVGUciVlO3+1ZUn eqQnxTXnqfJHptZTtK05uXGBwxjTHJrlSKnDslhZNkzv4JfTQhmERyx8BPHDkzpuPjfZ5Jp3 INcYsxgttyeDS4prv+XWlT7DUjIzcKih0tFDoW5/k6OZeFPba5PATHO78rcWFcduN8xB23B4 WFQAt5jpsP7/ngKQR9drMXfQGcEmqBq+aoVHobwOfEJTErdku05zjFmm1VnD55CzFJvG7Ll9 OsRfZD/1MKbl0k39NiRuf8IYFOxVCKrMSgnqED1eacLgj3AWnmfPlyB3Xka0FimVu5Q7r1H/ 9CCfHiOjjPsTAjE+Woh+/8Q0IyHzr+2sCe4g9w2tlsMQJhixykXC1KvzqMdUYKuE00CT+wdK nXj0hlNnThRfcA9VPYzKlx3W6GLlyB6umd6WBGGKyiOmOcPqUK3GIvnLzfTXR5DOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92Vcmzn/jaEBcq yT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbThLsSN1AuyP8wF KChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH5lSCjhP4VXiG q5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpFc1D/9NV/zIWB G1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzePt/SvC0RhQXNj XKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60RtThnhKc2kLI zd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7qVT41xdJ6KqQM NGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZv+PKIVf+zFKu h0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1qwom6QbU06ltb vJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHpcwzYbmi/Et7T 2+47PN9NZAOyb771QoVr8A== In-Reply-To: <20250825113734.iekrgyvctamhb5y7@hu-mojha-hyd.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 25/08/2025 13:37, Mukesh Ojha wrote: > On Sat, Aug 23, 2025 at 05:53:50PM +0200, Krzysztof Kozlowski wrote: >> The Qualcomm SoC Iris video codec is an evolution of previous Venus and >> it comes with its own Iris Linux drivers. These new drivers were >> accepted under condition they actually improve state of afairs, instead >> of duplicating old, legacy solutions. >> >> Unfortunately binding still references common parts of Venus without >> actual need and benefit. For example Iris does not use fake >> "video-firmware" device node (fake because there is no actual device >> underlying it and it was added only to work around some Linux issues >> with IOMMU mappings). >> >> Stop referencing venus-common schema in the new Qualcomm Iris bindings >> and move all necessary properties, except unused "video-firmware" (no >> driver usage, no DTS). >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../devicetree/bindings/media/qcom,sm8550-iris.yaml | 13 ++++++++++++- >> 1 file changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml >> index c79bf2101812..320227f437a1 100644 >> --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml >> +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml >> @@ -26,6 +26,9 @@ properties: >> - qcom,sm8550-iris >> - qcom,sm8650-iris >> >> + reg: >> + maxItems: 1 >> + >> power-domains: >> maxItems: 4 >> >> @@ -45,6 +48,12 @@ properties: >> - const: core >> - const: vcodec0_core >> >> + firmware-name: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> interconnects: >> maxItems: 2 >> >> @@ -69,6 +78,9 @@ properties: >> >> dma-coherent: true >> >> + memory-region: >> + maxItems: 1 >> + >> operating-points-v2: true >> >> opp-table: >> @@ -85,7 +97,6 @@ required: >> - dma-coherent >> >> allOf: >> - - $ref: qcom,venus-common.yaml# >> - if: > > Saw your reply on > https://lore.kernel.org/lkml/59951c47-1015-4598-a885-25f8f1a27c64@kernel.org/ > > Just trying to understand ABI here, how all of a sudden we remove a binding > for a hardware just because it did not get noticed until yet that as it is > not a real device and we always say device tree binding should not depend on > drivers but the device but we are saying Iris does not use fake "video-firmware" > device node for removal. I am a bit confused. About what? What is unclear in standard DT ABI rules? > > Whether removing will not break any ABI as initial binding enables the IRIS > related code to use video-firmware, now we are removing it. > I believe, removing binding always break ABI ? or is it depend on driver > code not using it ? There is no single user of this, out of tree (I briefly checked) and in-tree, so there is no ABI impact. I am changing the documentation of the ABI, but there is no actual ABI break because impact is 0. I am really sorry but it seems you ask about basics of DT, so please first get into docs and other existing discussions. Best regards, Krzysztof