mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xi Ruoyao <xry111@xry111.site>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
	Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Huacai Chen <chenhuacai@kernel.org>,
	WANG Xuerui <kernel@xen0n.name>,
	 linux-crypto@vger.kernel.org, loongarch@lists.linux.dev,
	 linux-kernel@vger.kernel.org, Jinyang He <hejinyang@loongson.cn>,
	Arnd Bergmann <arnd@arndb.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Christophe Leroy <christophe.leroy@csgroup.eu>
Subject: Re: [PATCH v5] LoongArch: vDSO: Wire up getrandom() vDSO implementation
Date: Thu, 29 Aug 2024 22:06:47 +0800	[thread overview]
Message-ID: <a3373ad5f92a4120bd0c8e0c751eb7617e035cf6.camel@xry111.site> (raw)
In-Reply-To: <ZtB5pqfp0Lg6lzz6@zx2c4.com>

On Thu, 2024-08-29 at 15:37 +0200, Jason A. Donenfeld wrote:
> On Thu, Aug 29, 2024 at 03:27:33PM +0200, Jason A. Donenfeld wrote:
> > One small question just occurred to me:
> > 
> > > +static __always_inline const struct vdso_rng_data *__arch_get_vdso_rng_data(
> > > +	void)
> > > +{
> > > +	return (const struct vdso_rng_data *)(
> > > +		get_vdso_data() +
> > > +		VVAR_LOONGARCH_PAGES_START * PAGE_SIZE +
> > > +		offsetof(struct loongarch_vdso_data, rng_data));
> > > +}
> > 
> > Did you test this in a TIMENS? On x86, I had to deal with the page
> > offsets switching around depending on whether there was a TIMENS. I
> > tested this in my test harness with some basic code like:
> > 
> >        if (argc == 1) {
> >                if (unshare(CLONE_NEWTIME))
> >                        panic("unshare(CLONE_NEWTIME)");
> >                if (!fork()) {
> >                        if (execl(argv[0], argv[0], "now-in-timens"))
> >                                panic("execl");
> >                }
> >                wait(NULL);
> >                poweroff();
> >        }
> > 
> > Because unlike other namespaces, the time one only becomes active after
> > fork/exec.
> > 
> > But maybe loongarch is more organized and you don't need any special
> > handling in __arch_get_vdso...data() functions like I needed on x86.
> > Just thought I should check.
> 
> Normal results:
> 
>    vdso: 25000000 times in 0.287330836 seconds
>    libc: 25000000 times in 4.480710835 seconds
> syscall: 25000000 times in 4.411098048 seconds
> 
> After applying
> 
> diff --git a/arch/x86/include/asm/vdso/getrandom.h b/arch/x86/include/asm/vdso/getrandom.h
> index ff5334ad32a0..5cb1b318ebe3 100644
> --- a/arch/x86/include/asm/vdso/getrandom.h
> +++ b/arch/x86/include/asm/vdso/getrandom.h
> @@ -32,8 +32,6 @@ static __always_inline ssize_t getrandom_syscall(void *buffer, size_t len, unsig
> 
>  static __always_inline const struct vdso_rng_data *__arch_get_vdso_rng_data(void)
>  {
> -	if (IS_ENABLED(CONFIG_TIME_NS) && __vdso_data->clock_mode == VDSO_CLOCKMODE_TIMENS)
> -		return (void *)&__vdso_rng_data + ((void *)&__timens_vdso_data - (void *)&__vdso_data);
>  	return &__vdso_rng_data;
>  }
> 
> the results are:
> 
>    vdso: 25000000 times in 4.403789593 seconds
>    libc: 25000000 times in 4.466771093 seconds
> syscall: 25000000 times in 4.428145416 seconds
> 
> The difference is that when it finds the shared data in the wrong place,
> it thinks the RNG is uninitialized, so it always falls back to the
> syscall, hence all three times being the same.
> 
> If you're unsure how timens handling works on loongarch, try this test
> yourself and see what you get.

$ unshare -r -T --boottime $((365*24*3600))
# uptime
 21:54:36 up 365 days,  5:38,  0 user,  load average: 0.05, 0.08, 2.82
# /home/xry111/git-repos/linux/tools/testing/selftests/vDSO/vdso_test_getrandom bench-single
   vdso: 25000000 times in 0.499528591 seconds
   libc: 25000000 times in 6.968980040 seconds
syscall: 25000000 times in 6.987357071 seconds

So it seems normal in a time ns.

And from a comment in arch/loongarch/include/asm/vdso/vdso.h:

/*
 * The layout of vvar:
 *
 *                      high
 * +---------------------+--------------------------+
 * | loongarch vdso data | LOONGARCH_VDSO_DATA_SIZE |
 * +---------------------+--------------------------+
 * |  time-ns vdso data  |        PAGE_SIZE         |
 * +---------------------+--------------------------+
 * |  generic vdso data  |        PAGE_SIZE         |
 * +---------------------+--------------------------+
 *                      low
 */

And VVAR_LOONGARCH_PAGES_START is 2:

enum vvar_pages {
    VVAR_GENERIC_PAGE_OFFSET,
    VVAR_TIMENS_PAGE_OFFSET,
    VVAR_LOONGARCH_PAGES_START,
    VVAR_LOONGARCH_PAGES_END = VVAR_LOONGARCH_PAGES_START +
LOONGARCH_VDSO_DATA_PAGES - 1,
    VVAR_NR_PAGES,
};

So get_vdso_data() + VVAR_LOONGARCH_PAGES_START * PAGE_SIZE should have
already "jumped over" the time-ns vdso data.

OTOH it seems we are wasting a page if !CONFIG_TIME_NS.	Maybe:

enum vvar_pages {
    VVAR_GENERIC_PAGE_OFFSET,
#ifdef CONFIG_TIME_NS
    VVAR_TIMENS_PAGE_OFFSET,
#endif
    VVAR_LOONGARCH_PAGES_START,
    VVAR_LOONGARCH_PAGES_END = VVAR_LOONGARCH_PAGES_START +
LOONGARCH_VDSO_DATA_PAGES - 1,
    VVAR_NR_PAGES,
};

Tiezhu: how do you think?


-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University

  reply	other threads:[~2024-08-29 14:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-29 12:56 Xi Ruoyao
2024-08-29 13:01 ` Xi Ruoyao
2024-08-29 13:05   ` Jason A. Donenfeld
2024-08-29 13:13 ` Jason A. Donenfeld
2024-08-29 13:18 ` Huacai Chen
2024-08-31  6:40   ` Xi Ruoyao
2024-08-31  7:10     ` Huacai Chen
2024-08-31  8:54       ` Christophe Leroy
2024-08-29 13:27 ` Jason A. Donenfeld
2024-08-29 13:37   ` Jason A. Donenfeld
2024-08-29 14:06     ` Xi Ruoyao [this message]
2024-08-29 14:44       ` Jason A. Donenfeld
2024-08-30  9:05         ` Xi Ruoyao
2024-08-30 12:24           ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3373ad5f92a4120bd0c8e0c751eb7617e035cf6.camel@xry111.site \
    --to=xry111@xry111.site \
    --cc=Jason@zx2c4.com \
    --cc=arnd@arndb.de \
    --cc=chenhuacai@kernel.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=hejinyang@loongson.cn \
    --cc=kernel@xen0n.name \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=tglx@linutronix.de \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®