From: Yunfeng Ye <yeyunfeng@huawei.com>
To: Herbert Xu <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<catalin.marinas@arm.com>, <will@kernel.org>
Cc: <linux-crypto@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
"hushiyuan@huawei.com" <hushiyuan@huawei.com>,
"linfeilong@huawei.com" <linfeilong@huawei.com>
Subject: [PATCH] crypto: arm64/aes-neonbs - remove redundant code in __xts_crypt()
Date: Tue, 22 Oct 2019 14:42:11 +0800 [thread overview]
Message-ID: <a33932c9-2975-4fcc-ba07-7c54df4eae27@huawei.com> (raw)
A warning is found by the static code analysis tool:
"Identical condition 'err', second condition is always false"
Fix this by removing the redundant condition @err.
Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
---
arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c
index ea873b8904c4..7b342db428b0 100644
--- a/arch/arm64/crypto/aes-neonbs-glue.c
+++ b/arch/arm64/crypto/aes-neonbs-glue.c
@@ -387,7 +387,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
skcipher_walk_done(&walk, nbytes);
}
- if (err || likely(!tail))
+ if (likely(!tail))
return err;
/* handle ciphertext stealing */
--
2.7.4.3
next reply other threads:[~2019-10-22 6:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 6:42 Yunfeng Ye [this message]
2019-10-22 6:52 ` Ard Biesheuvel
2019-10-22 7:14 ` Yunfeng Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a33932c9-2975-4fcc-ba07-7c54df4eae27@huawei.com \
--to=yeyunfeng@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hushiyuan@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®