From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A68E3AEF27 for ; Mon, 30 Mar 2026 08:52:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774860770; cv=none; b=jzIAmPiu/Q99l+MdyB4PGDF7SgnZ+kQoGb2ydpS566FwustX6CUzJHp8FO/cmOjqrVNcHCkbhQrSkLRyn2z7lISmu2J4fzJFHfOL/oX2smCoEQ+MD2hQRnSB3TtTEUb1x3dRpSrBOgJaXpXqyRenUMxUul9tPz+D/nzWef9y3l8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774860770; c=relaxed/simple; bh=AA2BdMUW7VfEiqAUAzVMsm0H/MPU3SGAH/WOlBUEhSw=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=GsJ30ngAqks7b0aO7IEw4YtmWPWXa72KjAHR5GXLa7ZB0dhQn+LGZU7XeLExZHd0EF2hZGkpOzWP7UXXBuomRhQHaGYceBgTycjYx4LS93spsPu/32QG6Kz6ic83qJ5q+Mu0yxnj+F4bYxZAOupZ778cEyKho+HXFBsNNzrxlLU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gaXT2rAb; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gaXT2rAb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774860768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=or/KOdTHYhj19Ns3SWZkcQKqCJUJy40IjMw5ydB3GXk=; b=gaXT2rAb7CengjQhcQal0jhd1gWyE1wOGiIVdUGyHlkei7Wj9wKI8HJmoSJo3amW6+yPbS 5pSnJ6miHr2YeJTeylrRwoluMLJosovA391qkeY1X9SY+1C6xa+k7dzGkvU4cuOhixK4pF wHweXfLDnMHA5vwLV66z0ipVoHVUNl8= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-548-PbSe9W_gOB-x8qrN-X81PA-1; Mon, 30 Mar 2026 04:52:45 -0400 X-MC-Unique: PbSe9W_gOB-x8qrN-X81PA-1 X-Mimecast-MFC-AGG-ID: PbSe9W_gOB-x8qrN-X81PA_1774860763 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 873F51800610; Mon, 30 Mar 2026 08:52:42 +0000 (UTC) Received: from [10.44.33.70] (unknown [10.44.33.70]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1E5FC1800107; Mon, 30 Mar 2026 08:52:37 +0000 (UTC) Message-ID: Date: Mon, 30 Mar 2026 10:52:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/3] dpll: add actual frequency monitoring callback ops From: Ivan Vecera To: Vadim Fedorenko , netdev@vger.kernel.org Cc: Arkadiusz Kubalewski , Jiri Pirko , Jonathan Corbet , Shuah Khan , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Donald Hunter , Prathosh Satish , Petr Oros , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260325193914.124898-1-ivecera@redhat.com> <20260325193914.124898-3-ivecera@redhat.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On 3/26/26 6:48 PM, Ivan Vecera wrote: > On 3/26/26 12:21 PM, Vadim Fedorenko wrote: >> On 25/03/2026 19:39, Ivan Vecera wrote: >> >>> +static int dpll_msg_add_actual_freq(struct sk_buff *msg, struct >>> dpll_pin *pin, >>> +                    struct dpll_pin_ref *ref, >>> +                    struct netlink_ext_ack *extack) >>> +{ >>> +    const struct dpll_device_ops *dev_ops = dpll_device_ops(ref->dpll); >>> +    const struct dpll_pin_ops *ops = dpll_pin_ops(ref); >>> +    struct dpll_device *dpll = ref->dpll; >>> +    enum dpll_feature_state state; >>> +    u64 actual_freq; >>> +    int ret; >>> + >>> +    if (!ops->actual_freq_get) >>> +        return 0; >>> +    if (dev_ops->freq_monitor_get) { >>> +        ret = dev_ops->freq_monitor_get(dpll, dpll_priv(dpll), >>> +                        &state, extack); >>> +        if (ret) >>> +            return ret; >>> +        if (state == DPLL_FEATURE_STATE_DISABLE) >>> +            return 0; >> >> I think we have to signal back to user that frequency monitoring is >> disabled via extack. > > Hi Vadim, > > This would break pin-get operation... Do or dump pin-get operation would > fail with this extack message. > > Here we can check if the freq-monitoring is enabled and conditionally > call actual_freq_get() or measured_freq_get() > > -or- > > Call this callback unconditionally and check for return code and if a > driver returns e.g. -ENODATA then skip nla_put_64bit() but return > success. > > WDYT? Vadim?