From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D0771DED49 for ; Mon, 1 Dec 2025 15:12:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764601960; cv=none; b=WTTUT3Btwn9QVnsvW46FiHZeM6LDRc4TfM74zz2iOsGE67zPAjWcs4yTHA0FRSf0tQyi4h3UxBPhcrcjjHTszjBGcgRWNx9ONJ5LGJT7GOHlrLD+HzHil56soaB4nWsQY/NKZZJCJbI8f2x9K0ugDwY3Rcspbo6a/B21HVjjZes= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764601960; c=relaxed/simple; bh=nOY0/y7styDnD1DLlbEZhSbI1ectNWmIqY63A4VdhqU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lzmdidw/X6ReM4g3bDXddLZ7ZdXV9eNwF53GN4ha+ZnMBiSnbq9UAfPZv15A52jbQnrI/cypc9atFmaWeBuBgFAW7QWnW8LsyIqycvo7kWn06QlkFJc+fglVuICimINkLGb2XF2X75jXK85U9dFIo3zhKDBAUc3QWdtTT3BBbrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N4fIZyuo; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PeZID7vx; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N4fIZyuo"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PeZID7vx" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B1CG9BU060560 for ; Mon, 1 Dec 2025 15:12:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ArX95p0olkqkaVsj5g0Z/zNtOL40uj04LFD5XFTRZSE=; b=N4fIZyuojX0XPbBE 99qrhenl/vgSuvEXYtbufahR71I2BA26mRSvP7oqae2jD1/c7zjFhYROPnqgIHR6 z0qkEVcRmthxBQOndmNRWGqgkKIausqSMj2AoYp1yJzFf+9Hpi2MuzXncH2wBmt/ sRlF1yF13CGn9MbEhuQn46hjUldN1GvgtwqEQ8y16rugP0Gmf0InxeQ46s3bIs71 rLgyhYePrxkKsO8knvXyuMnAWzo9M/h2+Sa130Xux8WAAoh+fA4IDOvIJRkhTbDS NqkeEFgRygWV0RgD4ITrHWIKlU5tLvwFVcmw44FecvipXdL9b+WOl3m05ulJ3pkC YtXfxQ== Received: from mail-yx1-f70.google.com (mail-yx1-f70.google.com [74.125.224.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4asavh8gkm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 01 Dec 2025 15:12:37 +0000 (GMT) Received: by mail-yx1-f70.google.com with SMTP id 956f58d0204a3-64203afd866so7765979d50.0 for ; Mon, 01 Dec 2025 07:12:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764601957; x=1765206757; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ArX95p0olkqkaVsj5g0Z/zNtOL40uj04LFD5XFTRZSE=; b=PeZID7vx8AtU1o1IHBZc2hjbKy6lZUgmmFk8tny4XjAqbOLwFllk5NgfbaUGOKhB/T Zi+AylAZNjl3QSSgIBYOKfWXBEHanOZ2G9aulWt6HmENKzmkNZ0AGmjigtpfxZr7br4w 4lSW067rjXL3Azye8qyM1ocpd8pEzKIJqMLzB1Uhkijm3f8XTDgfx+TUwZjZl1TKFYu2 K6Nwmypjl3FsTQHVS2Q0RyMNiiZPx3o/jm475k91C0hgr5DFJsBrOv/8tgJI0i2LKXBL pEIGg3Q1a9kOuThteUSgdnr6qiWl9qVpGTXv6KbGAsHXxmNJs+azOG3UmH1GxkklMRuN ayqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764601957; x=1765206757; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ArX95p0olkqkaVsj5g0Z/zNtOL40uj04LFD5XFTRZSE=; b=EMBgIpCjKhox8eantsslCa+pd415032qB0vPmIi2iMuYXcl402zFwqJpQiFxCqZO5A R2yt+XdgncrXbuhYy7YEshrqOICYj2ZkNltIEwJNS0xeHkd6U/7vlWgR7dOnbV5G6AQZ kxYZ9hGmYY4PSRtWz0eCqucw8BW+/GbtH7UI5HN+aF/KSXfEjoefOfk1BVDX5pzcFlbF gunE5PRO7iniKzV8AQC7PweStGkbN+f5LHqP5T2X1Hn4mt8znE4u1q1ug9vphSuoqZIV SXekHqAwRV3aiNhr+DIt4WQD83BEnHVJmuYJDsoFuCh7w9EUAg7z4mazw4Ff84muq6h6 ptsA== X-Forwarded-Encrypted: i=1; AJvYcCW6M4GHuMIHlAKAsFbA7AhBkCYtCgoxvZLfHNsKMW9SRz1v/MMMxWszvYX6HYWNV6nryVnKi1dVYmgNNWw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1Rmp66oUGu+8GgnKXey7H45WbGd8XNjb18myaBtp/18FXgvVe bkovXtysftRYGakUYE2vAAGTC47LBy5wFyukB6NbR+OONBIA1eU77l9VUpl3YAKNFCTlH4ZNmaC /GxSOS6A6OIJBINbaniOiCHKjeFmSNkRMKya5VeZ5voAk6AlciqBvBK+dDi83/oU3PjA= X-Gm-Gg: ASbGncsBaDr0bDeMAACbf17MFQm8yAgu/OV9WSl5oN+ZENC6gFXHQ6AawXqa5R04NJV +iSFcTw2m8+7X259CKjPCtzOSB1dfIaPRflq4AuMXW4Nzme1phEhSG/po7nAACr8igwA1VghbuJ BG058+EJ6XMjAhUTA+5Wn0IlU+D7zDfBKfD/axA2GhRHhT7xVRPSvNKTGHTVYYTaR+K0b0Wthhp tvxDQIGVmRRf3JhUlPCyltY95PxVR4e/KPBF3YCmWljTZhuoBw6tHpdc+KA/3oBlRnHt743aKjJ Y9L7xzfzdAK14VIiG5LF3eHmDGusEWdWGUHp46r7QcuQqNPyJcAeSOYYnRbfJEfnWpgaW2H3THy 4e56buxHRf/oaSBQMV8GIUmFoI6v6donpZKxU X-Received: by 2002:a05:690e:1c09:b0:63f:9fd6:94f5 with SMTP id 956f58d0204a3-642f8ddf5e1mr30696899d50.8.1764601956372; Mon, 01 Dec 2025 07:12:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IFRKs5cfkZNWtfP0LkauT9BabZg6EZ8ZhvUWxx4E0ElOqx46RgYc6C3MIrO9BkbG4xWa6dUXg== X-Received: by 2002:a05:690e:1c09:b0:63f:9fd6:94f5 with SMTP id 956f58d0204a3-642f8ddf5e1mr30696855d50.8.1764601955775; Mon, 01 Dec 2025 07:12:35 -0800 (PST) Received: from [192.168.68.121] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4790b0e21e8sm326622805e9.15.2025.12.01.07.12.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Dec 2025 07:12:34 -0800 (PST) Message-ID: Date: Mon, 1 Dec 2025 15:12:33 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/6] ASoC: qcom: Fix confusing cleanup.h To: Krzysztof Kozlowski , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-0-c38b06884e39@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-0-c38b06884e39@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 9KzBkRnuvvpx4GdXTl_BXAf29tftyCl0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAxMDEyNCBTYWx0ZWRfX2umpHz48fq4C W9N72Rg4/+kcrhnbCXmAg6bQOY6G4Ck/JoKNAmLNQ+uKfgxwbS56WlWQ06dZSRCog2ayloHS6nk 0UVOVUEoo9KEXYD/ZmpSpceYU5yk0uhLV0zeZQLZ4pGNCiL5Bw3xNDxfoHCC23B+H83LIydc66q CkhgXBNjPhujKJFK345S1QAOBVjHQJnRXPHCIwDAfZFN6qjaKxlcTV54WEOjGpOpBh6q4mhbHep L5j7+wbeh7sHKU24kwfhEVtZERM+uCIjhGyduQvfLpYCij7uHVGka1Q0PJjQTeDGQ7NYSKe0aF7 kZUWohW9VHlxCsPWK0yYzq0k3qZGSdu8BNKzil+XagwIOlAnmt9aYXf9Kim1Gxzjmbd5Doskv3t C1lz9uRi3teltcNaH4rHckLYBtJHLA== X-Authority-Analysis: v=2.4 cv=QutTHFyd c=1 sm=1 tr=0 ts=692db065 cx=c_pps a=S/uc88zpIJVNbziUnJ6G4Q==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=5cJh8bmIhOOgMbKR4zwA:9 a=QEXdDO2ut3YA:10 a=nd2WpGr1bMy9NW-iytEl:22 X-Proofpoint-GUID: 9KzBkRnuvvpx4GdXTl_BXAf29tftyCl0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512010124 On 11/29/25 1:17 PM, Krzysztof Kozlowski wrote: > Please, please stop ending cleanup.h patches for very simple code like: > > foo = kzalloc(); > kfree(foo); > return; > > ... *if you do not intend to read cleanup.h*. These changes are making > simple code not necessarily simpler. But worse, if you do not read > cleanup.h then you introduce actually undesired, error-prone and wrong > style of having constructors with redundant values (= NULL). > > This is actually worse code. > > If you do not agree in declaration-in-place-of-use (fair!), then do not > use cleanup.h. If you want to use cleanup.h, then please read cleanup.h > before. > > This is second mixup I see recently around Qualcomm files. > > Best regards, > Krzysztof > > --- > Krzysztof Kozlowski (6): > ASoC: qcom: q6prm: Fix confusing cleanup.h syntax > ASoC: qcom: q6asm: Fix confusing cleanup.h syntax > ASoC: qcom: q6apm: Fix confusing cleanup.h syntax > ASoC: qcom: q6afe: Fix confusing cleanup.h syntax > ASoC: qcom: audioreach: Fix confusing cleanup.h syntax > ASoC: qcom: Minor readability improve with new lines > Thanks Krzysztof for fixing the confusing parts, I do agree with you. there are alteast 100+ such instances in just sound/* Reviewed-by: Srinivas Kandagatla --srini > sound/soc/qcom/qdsp6/audioreach.c | 28 +++++++++++++++++----------- > sound/soc/qcom/qdsp6/q6adm.c | 2 ++ > sound/soc/qcom/qdsp6/q6afe.c | 10 ++++++---- > sound/soc/qcom/qdsp6/q6apm.c | 9 ++++++--- > sound/soc/qcom/qdsp6/q6asm.c | 19 +++++++++++++++---- > sound/soc/qcom/qdsp6/q6prm.c | 16 ++++++++-------- > 6 files changed, 54 insertions(+), 30 deletions(-) > --- > base-commit: 92fd6e84175befa1775e5c0ab682938eca27c0b2 > change-id: 20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-ebe8abad6e55 > > Best regards,