From: Chao Yu <chao@kernel.org>
To: Daeho Jeong <daeho43@gmail.com>
Cc: chao@kernel.org, jaegeuk@kernel.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v3 05/12] f2fs: cache: use meta cache
Date: Thu, 27 Aug 2026 14:46:25 +0800 [thread overview]
Message-ID: <a343cdfa-ee3c-4427-97da-bcb9ebfbada0@kernel.org> (raw)
In-Reply-To: <ae411946-e035-4933-878d-721566c95093@kernel.org>
On 8/27/26 10:26, Chao Yu wrote:
> On 8/27/26 04:22, Daeho Jeong wrote:>>> + memcpy(cache_address(tentry), cache_address(sentry), PAGE_SIZE);
>>
>> Use sbi->blocksize or F2FS_BLKSIZE instead?
>
> Sure, I thought about that before, but considering we have supported
> PAGE_SIZE != sbi->blocksize yet, I didn't touch that.
>
> If you want, let me change here.
Seems my change is not inconsistent for several places, let me change to
use sbi->blocksize here.
Thanks,
next prev parent reply other threads:[~2026-08-27 6:46 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 13:01 [PATCH v3 00/12] f2fs: introduce metadata cache Chao Yu
2026-08-25 13:01 ` [PATCH v3 01/12] f2fs: cache: implement " Chao Yu
2026-08-26 19:14 ` [f2fs-dev] " Daeho Jeong
2026-08-27 1:16 ` Chao Yu
2026-08-27 16:56 ` Daeho Jeong
2026-08-28 1:36 ` Chao Yu
2026-08-25 13:01 ` [PATCH v3 02/12] f2fs: cache: initialize meta cache Chao Yu
2026-08-25 13:01 ` [PATCH v3 03/12] f2fs: cache: introduce shrinker Chao Yu
2026-08-26 19:19 ` [f2fs-dev] " Daeho Jeong
2026-08-27 1:19 ` Chao Yu
2026-08-27 17:00 ` Daeho Jeong
2026-08-28 1:59 ` Chao Yu
2026-08-28 2:56 ` Chao Yu
2026-08-28 18:18 ` Daeho Jeong
2026-08-25 13:01 ` [PATCH v3 04/12] f2fs: cache: introduce writeback thread Chao Yu
2026-08-26 19:37 ` [f2fs-dev] " Daeho Jeong
2026-08-27 1:28 ` Chao Yu
2026-08-27 17:03 ` Daeho Jeong
2026-08-25 13:01 ` [PATCH v3 05/12] f2fs: cache: use meta cache Chao Yu
2026-08-26 20:22 ` [f2fs-dev] " Daeho Jeong
2026-08-27 2:26 ` Chao Yu
2026-08-27 6:46 ` Chao Yu [this message]
2026-08-25 13:01 ` [PATCH v3 06/12] f2fs: cache: initialize node cache Chao Yu
2026-08-25 13:01 ` [PATCH v3 07/12] f2fs: cache: use " Chao Yu
2026-08-25 13:01 ` [PATCH v3 08/12] f2fs: cache: initialize compress cache Chao Yu
2026-08-25 13:01 ` [PATCH v3 09/12] f2fs: cache: use " Chao Yu
2026-08-26 20:04 ` [f2fs-dev] " Daeho Jeong
2026-08-26 20:23 ` Daeho Jeong
2026-08-27 2:27 ` Chao Yu
2026-08-27 2:22 ` Chao Yu
2026-08-27 17:12 ` Daeho Jeong
2026-08-27 3:08 ` Chao Yu
2026-08-27 17:13 ` Daeho Jeong
2026-08-27 3:24 ` Chao Yu
2026-08-27 17:20 ` Daeho Jeong
2026-08-28 3:32 ` Chao Yu
2026-08-28 12:00 ` Chao Yu
2026-08-28 12:25 ` Chao Yu
2026-08-28 18:22 ` Daeho Jeong
2026-08-25 13:01 ` [PATCH v3 10/12] f2fs: cache: support fault injection Chao Yu
2026-08-25 13:01 ` [PATCH v3 11/12] f2fs: cache: introduce tracepoints Chao Yu
2026-08-25 13:01 ` [PATCH v3 12/12] f2fs: cache: show per-cache usage in debugfs Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a343cdfa-ee3c-4427-97da-bcb9ebfbada0@kernel.org \
--to=chao@kernel.org \
--cc=daeho43@gmail.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®