From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F4DC4332F for ; Sat, 28 Oct 2023 23:07:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229712AbjJ1XHa (ORCPT ); Sat, 28 Oct 2023 19:07:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjJ1XH2 (ORCPT ); Sat, 28 Oct 2023 19:07:28 -0400 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E110CF; Sat, 28 Oct 2023 16:07:26 -0700 (PDT) Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6be840283ceso3067165b3a.3; Sat, 28 Oct 2023 16:07:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698534446; x=1699139246; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eDlPBkLdn2EAK6+ebgcvjT1S6LOy4Uub2C1Sv2Bx9Lc=; b=PPFEQ2N4WdYE5udC1tpQ9bFxHn2cKSh7wAI6Q06p3HwugYDqAcz5APKCLhEX/K+8I5 wCkgQ2+VxT16pZKPNPOzsypwQGW6JltXQbofN38RwLFaKYiN8Q6uG0gPUQJujpoGAWkp lxH2ruByNzrZvk6E3V/+oXoiCq2gXN7PyXJCNcvNADUfcy5GKSo1hJVR8rkUIdeH24OF f4yXZR0wPeIRErTEphJfOOprGiOGT76tYilJFIxn05DCerKUPhJB7hpu0gPlwWTJU/e3 52jnrsB3nGnzdZVGn/AH2D6PaWBoV8pi3w34lOhiyyHFVyGFcwlCzRV4Q5AgG5DTsxpz anAg== X-Gm-Message-State: AOJu0Yyhd1aW2wf1WyuYuglVIJh7oM/5xSDoiIw/pGar59OzcBhWpN34 aQiLU952al3O5JOmMweF170= X-Google-Smtp-Source: AGHT+IFhJa+1mVncSE0wPTEE2mIe537HRM5rVISqh5B77tiL+T93sCHuen690B6KoaDZGmH83Lkmkg== X-Received: by 2002:a05:6a00:93aa:b0:6be:bf7:fda5 with SMTP id ka42-20020a056a0093aa00b006be0bf7fda5mr6220884pfb.12.1698534445490; Sat, 28 Oct 2023 16:07:25 -0700 (PDT) Received: from ?IPV6:2601:647:4d7e:54f3:667:4981:ffa1:7be1? ([2601:647:4d7e:54f3:667:4981:ffa1:7be1]) by smtp.gmail.com with ESMTPSA id m16-20020aa78a10000000b0068bc6a75848sm3422684pfa.156.2023.10.28.16.07.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Oct 2023 16:07:24 -0700 (PDT) Message-ID: Date: Sat, 28 Oct 2023 16:07:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 1/2] RDMA/rxe: don't allow registering !PAGE_SIZE mr Content-Language: en-US To: Zhu Yanjun , Li Zhijian , zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org, linux-rdma@vger.kernel.org Cc: linux-kernel@vger.kernel.org, rpearsonhpe@gmail.com, matsuda-daisuke@fujitsu.com References: <20231027054154.2935054-1-lizhijian@fujitsu.com> <53c18b2a-c3b2-4936-b654-12cb5f914622@linux.dev> <45c23e30-8405-470b-825c-e5166cd8a313@linux.dev> From: Bart Van Assche In-Reply-To: <45c23e30-8405-470b-825c-e5166cd8a313@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/27/23 19:48, Zhu Yanjun wrote: > In this case, ULP with folio will not work well with current RXE after > this commit is applied. Why not? RDMA ULPs like the SRP initiator driver use ib_map_mr_sg(). The latter function calls rxe_map_mr_sg() if the RXE driver is used. rxe_map_mr_sg() calls ib_sg_to_pages(). ib_sg_to_pages() translates SG-entries that are larger than a virtual memory page into multiple entries with size mr->page_size. Thanks, Bart.