From: Subhash Jadavani <subhashj@codeaurora.org>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Vinayak Holikatti <vinholikatti@gmail.com>,
Christoph Hellwig <hch@lst.de>,
Yaniv Gardi <ygardi@codeaurora.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [scsi 3/4] scsi: ufs: ufshcd_get_max_icc_level fix endianity handling
Date: Tue, 10 Jan 2017 16:59:10 -0800 [thread overview]
Message-ID: <a34d3dfc572a6a6e008e921ca752592e@codeaurora.org> (raw)
In-Reply-To: <1483605912-15041-3-git-send-email-tomas.winkler@intel.com>
On 2017-01-05 00:45, Tomas Winkler wrote:
> Reading big endian value from a buffer requires explicit cast.
> Fix sparse warning:
> drivers/scsi/ufs/ufshcd.c:4825:24: warning: cast to restricted __be16
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 63d7ae2c3be9..fdea08f79b7d 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -4822,7 +4822,7 @@ static u32 ufshcd_get_max_icc_level(int
> sup_curr_uA, u32 start_scan, char *buff)
> u16 unit;
>
> for (i = start_scan; i >= 0; i--) {
> - data = be16_to_cpu(*((u16 *)(buff + 2*i)));
> + data = be16_to_cpup((__be16 *)&buff[2 * i]);
> unit = (data & ATTR_ICC_LVL_UNIT_MASK) >>
> ATTR_ICC_LVL_UNIT_OFFSET;
> curr_uA = data & ATTR_ICC_LVL_VALUE_MASK;
Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-01-11 0:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 8:45 [scsi 1/4] scsi: ufs: ufshcd_query_descriptor_retry should be static Tomas Winkler
2017-01-05 8:45 ` [scsi 2/4] scsi: ufs: unexport descritpor reading functions Tomas Winkler
2017-01-11 0:55 ` Subhash Jadavani
2017-01-05 8:45 ` [scsi 3/4] scsi: ufs: ufshcd_get_max_icc_level fix endianity handling Tomas Winkler
2017-01-11 0:59 ` Subhash Jadavani [this message]
2017-01-05 8:45 ` [scsi 4/4] scsi: ufs: refactor device descriptor reading Tomas Winkler
2017-01-11 1:02 ` Subhash Jadavani
2017-01-11 0:52 ` [scsi 1/4] scsi: ufs: ufshcd_query_descriptor_retry should be static Subhash Jadavani
2017-01-11 4:04 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a34d3dfc572a6a6e008e921ca752592e@codeaurora.org \
--to=subhashj@codeaurora.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tomas.winkler@intel.com \
--cc=vinholikatti@gmail.com \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome