From: Shuah Khan <skhan@linuxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Shuah Khan <shuah@kernel.org>, Andy Lutomirski <luto@kernel.org>,
Borislav Petkov <bp@suse.de>,
Jethro Beekman <jethro@fortanix.com>,
"open list:INTEL SGX" <linux-sgx@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Cc: kernel@collabora.com, kernelci@groups.io,
"kernelci.org bot" <bot@kernelci.org>
Subject: Re: [PATCH 1/2] selftests: x86: allow expansion of $(CC)
Date: Thu, 10 Feb 2022 13:51:51 -0700 [thread overview]
Message-ID: <a34f2fc8-f4aa-fef4-d1dd-f3fdb5114f72@linuxfoundation.org> (raw)
In-Reply-To: <20220210190642.1477814-2-usama.anjum@collabora.com>
On 2/10/22 12:06 PM, Muhammad Usama Anjum wrote:
> CC can have multiple sub-strings like "ccache gcc". Erorr pops up if
> it is treated as single string and double quote are used around it.
> This can be fixed by removing the quotes and not treating CC a single
> string.
>
> Fixes: e9886ace222e ("selftests, x86: Rework x86 target architecture detection")
> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> tools/testing/selftests/x86/check_cc.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/x86/check_cc.sh b/tools/testing/selftests/x86/check_cc.sh
> index 3e2089c8cf549..aff2c15018b53 100755
> --- a/tools/testing/selftests/x86/check_cc.sh
> +++ b/tools/testing/selftests/x86/check_cc.sh
> @@ -7,7 +7,7 @@ CC="$1"
> TESTPROG="$2"
> shift 2
>
> -if "$CC" -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
> +if $CC -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
> echo 1
> else
> echo 0
>
The intent is testing if $CC is set. Does this change work when
$CC is not set?
thanks,
-- Shuah
next prev parent reply other threads:[~2022-02-10 20:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 19:06 [PATCH 0/2] selftests: sgx: Fix build of test_sgx Muhammad Usama Anjum
2022-02-10 19:06 ` [PATCH 1/2] selftests: x86: allow expansion of $(CC) Muhammad Usama Anjum
2022-02-10 20:51 ` Shuah Khan [this message]
2022-02-10 22:41 ` Muhammad Usama Anjum
2022-02-10 22:46 ` Shuah Khan
[not found] ` <99625ceecead4e9eb73de2fc8acb2ae9@AcuMS.aculab.com>
2022-02-11 17:13 ` Shuah Khan
2022-02-14 8:18 ` Muhammad Usama Anjum
2022-02-10 19:06 ` [PATCH 2/2] selftests: sgx: Treat CC as one argument Muhammad Usama Anjum
2022-02-10 20:52 ` Shuah Khan
2022-02-20 20:06 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a34f2fc8-f4aa-fef4-d1dd-f3fdb5114f72@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=bot@kernelci.org \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=jethro@fortanix.com \
--cc=kernel@collabora.com \
--cc=kernelci@groups.io \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@kernel.org \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®