mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Lh Kuo 郭力豪" <lh.Kuo@sunplus.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Li-hao Kuo <lhjeff911@gmail.com>
Cc: "Philipp Zabel" <p.zabel@pengutronix.de>,
	"Mark Brown" <broonie@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	linux-spi <linux-spi@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Wells Lu 呂芳騰" <wells.lu@sunplus.com>
Subject: RE: [PATCH v6 1/2] spi: Add spi driver for Sunplus SP7021
Date: Thu, 20 Jan 2022 09:23:06 +0000	[thread overview]
Message-ID: <a354d7c1dce4463ea57706dd5443fe7a@sphcmbx02.sunplus.com.tw> (raw)
In-Reply-To: <CAHp75VdKc3UDzaqM2G5J5+G90U6Spqyhz_vuOYKhqJ4V-uf=wg@mail.gmail.com>

Hi Andy Shevchenko :

Thanks for your comment, I have some questions as below.

> > +       if (xfer->tx_buf)
> > +               dma_unmap_single(dev, xfer->tx_dma, xfer->len, DMA_TO_DEVICE);
> > +       if (xfer->rx_buf)
> > +               dma_unmap_single(dev, xfer->rx_dma, xfer->len,
> > + DMA_FROM_DEVICE);
> 
> Why can't you use SPI core DMA mapping code?

I didn't find the SPI core DMA mapping code for single maping. 
The method currently used is the general DMA single-map code usage method.


> 
> > +       device_set_node(&ctlr->dev, pdev->dev.fwnode);
> 
> Use dev_fwnode() in the second argument.
>

You mean as below ?

device_set_node(&ctlr->dev, dev_fwnode(dev));

Best Regards,
Li-hao Kuo

  reply	other threads:[~2022-01-20  9:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-18  8:42 [PATCH v6 0/2] Add spi control driver for Sunplus SP7021 SoC Li-hao Kuo
2022-01-18  8:42 ` [PATCH v6 1/2] spi: Add spi driver for Sunplus SP7021 Li-hao Kuo
2022-01-18 17:41   ` Mark Brown
2022-01-20  9:12     ` Lh Kuo 郭力豪
2022-01-19 22:08   ` Andy Shevchenko
2022-01-20  9:23     ` Lh Kuo 郭力豪 [this message]
2022-01-20  9:51       ` Andy Shevchenko
2022-01-21  6:55         ` Lh Kuo 郭力豪
2022-01-21 10:09           ` Andy Shevchenko
2022-01-24  3:27             ` Lh Kuo 郭力豪
2022-01-18  8:42 ` [PATCH v6 2/2] dt-bindings:spi: Add Sunplus SP7021 schema Li-hao Kuo
2022-01-27 15:16   ` Rob Herring
2022-01-25 14:35 ` [PATCH v6 0/2] Add spi control driver for Sunplus SP7021 SoC Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a354d7c1dce4463ea57706dd5443fe7a@sphcmbx02.sunplus.com.tw \
    --to=lh.kuo@sunplus.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lhjeff911@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=wells.lu@sunplus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®