From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD1CDC67871 for ; Thu, 12 Jan 2023 14:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237863AbjALOaj (ORCPT ); Thu, 12 Jan 2023 09:30:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237289AbjALO3z (ORCPT ); Thu, 12 Jan 2023 09:29:55 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5E155D8BA for ; Thu, 12 Jan 2023 06:21:18 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id bf43so28649407lfb.6 for ; Thu, 12 Jan 2023 06:21:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hYPC0xPkD3qfxeDJVAHVJwygajuCgQeK71VnK//yVgE=; b=qWyBCN/YKgeG4SRRDofLnlF56/pjSEaCFpmiJ00jJ3QFJxtA2qZij/aoAJMmH5FmLu 31YwkrKqbOXN6LOCp3Pba8MY0t3/HvWvlY1+FAxdcGw1JYftQm/fiLTYWlhL/7i8ihCM mMSBjrZ/dArekeChC/lUNFnEniGNjc9kDO9W9OaDa6ZmU1XHyCvCbqokFgnF2npotpP9 pMhYfIoh3OARFxQ993lIAj09U9tW/IWtPR3TtPylqusO88A5ug8XPE3QIB5b3E354/7R YYftG9F7x6PqLuipBQsPicz3hcfgkgqT1JTgAmGsibXGeGRCKF/P4MJsTSY/tGyz1Uf3 TRKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hYPC0xPkD3qfxeDJVAHVJwygajuCgQeK71VnK//yVgE=; b=AxOv7o6EWxFA1LlI2dCwDj4Yu85iopfNAhd8Mh9uGqsU/gC4sOaPUUJkWDhV61QzvU MRZ2LPNu4rZE/thnpoCmMSHcW2lVixGfM5FJnNqJZu8Htj+x6USPGwPcmlnKtmeF2itQ fGrX1SUaij3lFNzgOdi0KpL99w6jcLc8pB/un84ytItPjl2xqYrRh+9UsADdup5JwYlo 41VHP98+WVuO7OUxLO24AtOqvF6AiVDtocPBfbGO/5YyEVB1iJ09401ZlwahUzKj25FR ZiuiJbd2nYG/XS1nSayP+uwxZ+xiOBfzD1vUlGbtLXGjhS5UrMfW5AWf/VqmqvS6j18E e0/A== X-Gm-Message-State: AFqh2kqTfQwBO9V9ibMnHmsZQ152SG+fiT+4Aa82jlTzdY+fF7do2LwN pJMp74sgxzOEp2r9zjogm6WtjQ== X-Google-Smtp-Source: AMrXdXsWq9nggSMuDl9Nfc/yAPwiMedsOXe42zJ3D3TUk4lXk1GFTMWZNFh51MEUEHqYcCSHTOeonA== X-Received: by 2002:ac2:4a8a:0:b0:4b5:1545:222b with SMTP id l10-20020ac24a8a000000b004b51545222bmr18813731lfp.47.1673533276802; Thu, 12 Jan 2023 06:21:16 -0800 (PST) Received: from [192.168.1.101] (abym53.neoplus.adsl.tpnet.pl. [83.9.32.53]) by smtp.gmail.com with ESMTPSA id bu31-20020a056512169f00b004b54ca56cf9sm3303452lfb.303.2023.01.12.06.21.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jan 2023 06:21:15 -0800 (PST) Message-ID: Date: Thu, 12 Jan 2023 15:21:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: Vote for CX in USB controllers Content-Language: en-US To: Bjorn Andersson , Bjorn Andersson Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold References: <20230112135117.3836655-1-quic_bjorande@quicinc.com> From: Konrad Dybcio In-Reply-To: <20230112135117.3836655-1-quic_bjorande@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.01.2023 14:51, Bjorn Andersson wrote: > Running GCC_USB30_*_MASTER_CLK at 200MHz requires CX at nominal level, > not doing so results in occasional lockups. This was previously hidden > by the fact that the display stack incorrectly voted for CX (instead of > MMCX). > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") > Signed-off-by: Bjorn Andersson > ---https://git.codelinaro.org/clo/la/kernel/msm-5.4/-/blob/LV.AU.1.2.3.r1-03600-gen3meta.0/drivers/clk/qcom/gcc-direwolf.c#L2703-2725 Maybe in the future there could be some power savings for lower freqs.. Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 2ed17baf50d3..4f4353f84cba 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -2265,6 +2265,7 @@ usb_0: usb@a6f8800 { > "ss_phy_irq"; > > power-domains = <&gcc USB30_PRIM_GDSC>; > + required-opps = <&rpmhpd_opp_nom>; > > resets = <&gcc GCC_USB30_PRIM_BCR>; > > @@ -2319,6 +2320,7 @@ usb_1: usb@a8f8800 { > "ss_phy_irq"; > > power-domains = <&gcc USB30_SEC_GDSC>; > + required-opps = <&rpmhpd_opp_nom>; > > resets = <&gcc GCC_USB30_SEC_BCR>; >