From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752193Ab0CZMAe (ORCPT ); Fri, 26 Mar 2010 08:00:34 -0400 Received: from mail-gx0-f217.google.com ([209.85.217.217]:62414 "EHLO mail-gx0-f217.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751165Ab0CZMAc convert rfc822-to-8bit (ORCPT ); Fri, 26 Mar 2010 08:00:32 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=khr1INtnltH/06ul22kMNystf1zoClGtfXED0yk5fAK+CxU2VBg+6zKQhj7msmAuGj 0mXw5+q2Fx5tjUWUeYimjHzIjFdHUjScL+dAaw9q4RnH4vbN0OyUNrFFJhfoDzpJenVk BBQTu6ukaF2poMnzPgG1YOGmdVr8fWiRtyKhA= MIME-Version: 1.0 In-Reply-To: <84621a61003241635h65687366t6b28148281d529c9@mail.gmail.com> References: <84621a61003241128x3afbcea1w387aeaa68c887320@mail.gmail.com> <84621a61003241635h65687366t6b28148281d529c9@mail.gmail.com> From: Ulrich Drepper Date: Fri, 26 Mar 2010 05:00:11 -0700 Message-ID: Subject: Re: behavior of recvmmsg() on blocking sockets To: Brandon Black Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 24, 2010 at 16:35, Brandon Black wrote: > +                /* MSG_WAITFORONE turns on MSG_DONTWAIT after one packet */ > +               if (!datagrams++ && flags & MSG_WAITFORONE) > +                       flags |= MSG_DONTWAIT; There should be an extra pair of parenthesis around the & operands but aside from that I could imagine this to work. Would be nice if the netdev folks would respond.