From: Andrew Lunn <andrew@lunn.ch>
To: Shenwei Wang <shenwei.wang@nxp.com>
Cc: Wei Fang <wei.fang@nxp.com>, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Clark Wang <xiaoning.wang@nxp.com>,
Stanislav Fomichev <sdf@fomichev.me>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v3 net-next 3/5] net: fec: add rx_frame_size to support configurable RX length
Date: Sun, 24 Aug 2025 18:13:13 +0200 [thread overview]
Message-ID: <a360fadc-0cfc-4d4a-9028-f63e2105634d@lunn.ch> (raw)
In-Reply-To: <PAXPR04MB91851EC6E79D76E8220C5251893CA@PAXPR04MB9185.eurprd04.prod.outlook.com>
> After further consideration, I think we can simply keep MAX_FL set to max_buf_size and
> only update TRUNC_FL as needed. This approach is also sufficient, so the logic introduced
> in patch v2 has been removed. Let me know if you want to add back the above logic.
For me, higher priority is you review all the commit messages and
comments. A lot of the discussion here has been because the comments
don't fit the code, and the commit messages don't give enough details
to explain the changes. They are just as important as the code.
Andrew
next prev parent reply other threads:[~2025-08-24 16:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-23 19:01 [PATCH v3 net-next 0/5] net: fec: add the Jumbo frame support Shenwei Wang
2025-08-23 19:01 ` [PATCH v3 net-next 1/5] net: fec: use a member variable for maximum buffer size Shenwei Wang
2025-08-23 19:04 ` Andrew Lunn
2025-08-25 2:29 ` Wei Fang
2025-08-23 19:01 ` [PATCH v3 net-next 2/5] net: fec: add pagepool_order to support variable page size Shenwei Wang
2025-08-23 19:05 ` Andrew Lunn
2025-08-23 19:01 ` [PATCH v3 net-next 3/5] net: fec: add rx_frame_size to support configurable RX length Shenwei Wang
2025-08-23 19:11 ` Andrew Lunn
2025-08-23 20:09 ` Shenwei Wang
2025-08-23 20:54 ` Andrew Lunn
2025-08-23 21:18 ` Shenwei Wang
2025-08-24 16:13 ` Andrew Lunn [this message]
2025-08-25 2:46 ` Wei Fang
2025-08-25 18:57 ` Shenwei Wang
2025-08-23 19:01 ` [PATCH v3 net-next 4/5] net: fec: add change_mtu to support dynamic buffer allocation Shenwei Wang
2025-08-23 19:17 ` Andrew Lunn
2025-08-23 19:34 ` Shenwei Wang
2025-08-25 3:19 ` Wei Fang
2025-08-23 19:01 ` [PATCH v3 net-next 5/5] net: fec: enable the Jumbo frame support for i.MX8QM Shenwei Wang
2025-08-23 19:25 ` Andrew Lunn
2025-08-23 19:53 ` Shenwei Wang
2025-08-23 20:44 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a360fadc-0cfc-4d4a-9028-f63e2105634d@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=imx@lists.linux.dev \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®