Re: [PATCH v7 5/6] gpio: max77759: add Maxim MAX77759 gpio driver

["André Draszik" <andre.draszik@linaro.org>]

Hi Bartosz,

On Mon, 2025-04-28 at 13:43 +0200, Bartosz Golaszewski wrote:
> On Mon, Apr 28, 2025 at 1:36 PM André Draszik <andre.draszik@linaro.org> wrote:
> > 
> > The Maxim MAX77759 is a companion PMIC for USB Type-C applications and
> > includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C
> > Port Controller (TCPC), NVMEM, and a GPIO expander.
> > 
> > This driver supports the GPIO functions using the platform device
> > registered by the core MFD driver.
> > 
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > Signed-off-by: André Draszik <andre.draszik@linaro.org>
> > ---
> 
> [snip]
> 
> > +
> > +       chip->gc.names = max77759_gpio_line_names;
> > +       chip->gc.ngpio = MAX77759_N_GPIOS;
> > +       chip->gc.get_direction = max77759_gpio_get_direction;
> > +       chip->gc.direction_input = max77759_gpio_direction_input;
> > +       chip->gc.direction_output = max77759_gpio_direction_output;
> > +       chip->gc.get = max77759_gpio_get_value;
> > +       chip->gc.set = max77759_gpio_set_value;
> 
> Please use the set_rv variant now, the old set is deprecated. Until
> that's changed, my Ack is revoked.

Thanks Bartosz for pointing this out, will update.

Cheers,
Andre'