From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Li Zhong <floridsleeves@gmail.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<intel-wired-lan@lists.osuosl.org>
Cc: <jesse.brandeburg@intel.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
Subject: Re: [PATCH net-next v2] drivers/net/ethernet: check return value of e1e_rphy()
Date: Mon, 29 Aug 2022 15:07:42 -0700 [thread overview]
Message-ID: <a3668c54-b5fb-6bf5-28d3-12818d46153b@intel.com> (raw)
In-Reply-To: <20220826065627.1615965-1-floridsleeves@gmail.com>
On 8/25/2022 11:56 PM, Li Zhong wrote:
nit: Could you mention the driver name in the commit title
e.g.
e1000e: check return value of e1e_rphy()
Thanks,
Tony
> e1e_rphy() could return error value, which needs to be checked and
> reported for debugging and diagnose.
>
> Signed-off-by: Li Zhong <floridsleeves@gmail.com>
> ---
> drivers/net/ethernet/intel/e1000e/phy.c | 20 +++++++++++++++++---
> 1 file changed, 17 insertions(+), 3 deletions(-)
next prev parent reply other threads:[~2022-08-29 22:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 6:56 Li Zhong
2022-08-29 22:07 ` Tony Nguyen [this message]
[not found] ` <3226a822-b8be-b712-737a-f8cc523ebed1@intel.com>
2022-08-30 7:05 ` [Intel-wired-lan] " Li Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3668c54-b5fb-6bf5-28d3-12818d46153b@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=floridsleeves@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®