From: "David.Wu" <david.wu@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linus.walleij@linaro.org, huangtao@rock-chips.com,
dianders@chromium.org, linux-rockchip@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] pinctrl: rockchip: Add iomux-route switching support for rk3228
Date: Fri, 26 May 2017 11:38:57 +0800 [thread overview]
Message-ID: <a36f756f-9454-adf7-18aa-3e46c3d79cde@rock-chips.com> (raw)
In-Reply-To: <3063930.sJt1b8WyHP@phil>
Hi Heiko,
在 2017/5/26 5:12, Heiko Stuebner 写道:
> Requiring developers to calculate this pin-bit-value for each bank
> is cumbersome and error-prone. With the routes-struct known in
> the driver (see above and below), you can keep the the value element
> in rockchip_pin_bank, but calculate the per-bank value dynamically
> when the bank gets created.
>
> For example in rockchip_pinctrl_get_soc_data just parse the route-struct
> and calculate that value when the driver probes.
>
> This reduces possible errors and also spares us the clutter of all the
> additional PIN_BANK_* defines.
It is good to calculate the per-bank value dynamically, Thanks.☺
next prev parent reply other threads:[~2017-05-26 3:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 13:12 [PATCH 0/4] Add iomux-route switching support David Wu
2017-05-25 13:12 ` [PATCH 1/4] pinctrl: rockchip: " David Wu
2017-05-25 13:12 ` [PATCH 2/4] pinctrl: rockchip: Add iomux-route switching support for rk3228 David Wu
2017-05-25 21:12 ` Heiko Stuebner
2017-05-26 3:38 ` David.Wu [this message]
2017-05-25 13:12 ` [PATCH 3/4] pinctrl: rockchip: Add iomux-route switching support for rk3328 David Wu
2017-05-25 13:12 ` [PATCH 4/4] pinctrl: rockchip: Add iomux-route switching support for rk3399 David Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a36f756f-9454-adf7-18aa-3e46c3d79cde@rock-chips.com \
--to=david.wu@rock-chips.com \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®