From: "Simmons, James A." <simmonsja@ornl.gov>
To: "'Tolga Ceylan'" <tolga.ceylan@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"HPDD-discuss@lists.01.org" <HPDD-discuss@ml01.01.org>,
Tina Johnson <tinajohnson.1234@gmail.com>,
Greg Donald <gdonald@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Al Viro <viro@zeniv.linux.org.uk>,
aybuke ozdemir <aybuke.147@gmail.com>,
Joe Perches <joe@perches.com>,
"Ben Evans (bevans@cray.com)" <bevans@cray.com>
Subject: RE: [HPDD-discuss] [PATCH 1/1] staging: lustre/lustre/llite: get rid of incorrect type warning
Date: Fri, 12 Jun 2015 16:04:15 +0000 [thread overview]
Message-ID: <a3712e0101004aed909d42404cd25050@EXCHCS32.ornl.gov> (raw)
In-Reply-To: <CALmu+SynXVXvb=6E10K5z8kwGHs6Y9G6mkOUZXAYjqXPQS+wrA@mail.gmail.com>
>>On Wed, Jun 10, 2015 at 5:48 PM, Greg Kroah-Hartman
><gregkh@linuxfoundation.org> wrote:
>>
>> Are you sure all of these are correct? The kernel/user api for lustre
>> is a complex beast, and just casting away the pointer types isn't
>> usually the proper thing to do in order to resolve the issues here.
>>
>> thanks,
>>
>> greg k-h
>
>I'm not 100% sure, but the pointers that I added the annotation to end
>up being used as user memory. (eg. passed to copy_to_user, etc.)
>Sometimes these pointers are passed to functions that already have
>__user annotation in their signatures (eg. ll_getname, copy_and_ioctl,
>ll_fid2path, etc.).
Using these simple cast are not the proper fix. We had a lot of issues with user
land tools breaking due to leakage of kernel space stuff and other problems.
Some work went into cleaning that up in the OpenSFS branch but it is not totally
complete yet. Evans you wanted something challenging to work on well this is
up your alley. I would recommend looking at JIRA ticket LU-6401 and all its sub
tickets. You could start the port of those to the upstream client. At the same
time we can finish the cleanup in the OpenSFS branch as well.
next prev parent reply other threads:[~2015-06-12 16:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 23:01 Tolga Ceylan
2015-06-11 0:48 ` Greg Kroah-Hartman
2015-06-11 8:08 ` Tolga Ceylan
2015-06-12 16:04 ` Simmons, James A. [this message]
2015-06-11 9:11 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3712e0101004aed909d42404cd25050@EXCHCS32.ornl.gov \
--to=simmonsja@ornl.gov \
--cc=HPDD-discuss@ml01.01.org \
--cc=Julia.Lawall@lip6.fr \
--cc=aybuke.147@gmail.com \
--cc=bevans@cray.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tinajohnson.1234@gmail.com \
--cc=tolga.ceylan@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome