From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99128EB8FAD for ; Wed, 6 Sep 2023 08:09:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234729AbjIFIJg (ORCPT ); Wed, 6 Sep 2023 04:09:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229613AbjIFIJe (ORCPT ); Wed, 6 Sep 2023 04:09:34 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 579BFCF0 for ; Wed, 6 Sep 2023 01:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693987712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jpgfei2mfNvSiBZbRRCl7P6mieU8IYIrOksXh8s484g=; b=PWEhUvHwAMI2jAggA2m0GAjhWmJ7ObBOk8MJxIyoCLo9xXeuzNXeGoa2l5KbsMZJFpLFhM guIASIf9oqy+rAXjc1xZPfqjlasmwbU4ojY6qjMXRccks3J/ruqWUmdKP//wIhkWhQEvZx RIqO7T8I4z/EWnZyOT/nbrtetSqqZzQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-135-c-1e24ASN6iMthTlA_1eWw-1; Wed, 06 Sep 2023 04:08:31 -0400 X-MC-Unique: c-1e24ASN6iMthTlA_1eWw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fef5403093so3077255e9.0 for ; Wed, 06 Sep 2023 01:08:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693987710; x=1694592510; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jpgfei2mfNvSiBZbRRCl7P6mieU8IYIrOksXh8s484g=; b=hULIxWfpk12y5sRNbrq04dkzj01oLtYCzZaTZDBELTYRSjd2koHZhuhb3CzDfsPK05 BDOcsviW3OyWslMVF3UbehTZxG5BLTCA+fRqIlwoyILfF5MT7Tvfv0eGnWmHSCtafxtl Z2T+XeDPmVNQyUlpUsJU3M/Z1MlujVced8ctIvRAiU8Bfz4mXD6LqLoKRSUg8Owsi6Nu rx22q+rCi+RhHYkhDS7o8VcZZIuizz6EJmhXe4B5C64dbHjP9eZVvyRPrhnn2xPB8jnE 8I1KaBbaP6J0iExrmazD5agw7Bp4XWhdmMA2bvQ8+uQAuzflDgis1EAGvffMnGdQj/+J hHRw== X-Gm-Message-State: AOJu0YzjRb0oPu6HzAO+JibMwpj43Eotvt+mQWTNP+COVOX4oQQVnFs7 wCcjKOg/RB1TCmrAQLyIeyaTHa8eZ2n+UVe4yENm6L7kO4eLgwGg6b3jjXxbcl9bIUK9JG+H1Kf Q33Z8OijA5mxZ5IQQzD4lr7uJ1gWTozY+ X-Received: by 2002:a7b:c3d4:0:b0:401:b0f2:88d3 with SMTP id t20-20020a7bc3d4000000b00401b0f288d3mr1770330wmj.19.1693987709929; Wed, 06 Sep 2023 01:08:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFgKRZGg24VAJlwi+mt8CWKv31c7AYMp2iY70qBNPHox6O/y3ikwfE9JXwExw0xYtzhhTh2sQ== X-Received: by 2002:a7b:c3d4:0:b0:401:b0f2:88d3 with SMTP id t20-20020a7bc3d4000000b00401b0f288d3mr1770306wmj.19.1693987709595; Wed, 06 Sep 2023 01:08:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c70c:6c00:92a4:6f8:ff7e:6853? (p200300cbc70c6c0092a406f8ff7e6853.dip0.t-ipconnect.de. [2003:cb:c70c:6c00:92a4:6f8:ff7e:6853]) by smtp.gmail.com with ESMTPSA id p6-20020adfce06000000b0031ad2f9269dsm19826639wrn.40.2023.09.06.01.08.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Sep 2023 01:08:29 -0700 (PDT) Message-ID: Date: Wed, 6 Sep 2023 10:08:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] LoongArch: add p?d_leaf() definitions Content-Language: en-US To: Hongchen Zhang , Huacai Chen , WANG Xuerui , Andrew Morton , "Mike Rapoport IBM)" , Feiyang Chen , Qi Zheng , "Matthew Wilcox Oracle)" , Kefeng Wang Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn References: <20230905064955.16316-1-zhanghongchen@loongson.cn> <4a06f415-281f-b76f-ed03-211b07ccd6a4@loongson.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: <4a06f415-281f-b76f-ed03-211b07ccd6a4@loongson.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06.09.23 10:06, Hongchen Zhang wrote: > Hi David, > > On 2023/9/6 pm 3:42, David Hildenbrand wrote: >> On 05.09.23 08:49, Hongchen Zhang wrote: >>> When I do LTP test, LTP test case ksm06 caused panic at >>>     break_ksm_pmd_entry >>>       -> pmd_leaf (Huge page table but False) >>>       -> pte_present (panic) >>> >> >> Probably there are other problematic bits without that can trigger that? >> I suspect walk_page_range*() callers might be affected, > I rechecked the code and found that other architectures that support > THP have defined pmd_leaf. > So there is not problem on other architectures. I meant other walk_page_range*() callers on loongarch might similarly be affected. IOW, KSM might not be the only bit being able to trigger such panics on loongarch. -- Cheers, David / dhildenb