mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mihai Carabas <mihai.carabas@oracle.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
	rdunlap@infradead.org, bobo.shaobowang@huawei.com
Subject: Re: [PATCH v2 1/3] misc/pvpanic: split-up generic and platform dependent code
Date: Fri, 12 Feb 2021 12:29:49 +0200	[thread overview]
Message-ID: <a37c9549-14e1-6a80-7163-3a56414ff3f7@oracle.com> (raw)
In-Reply-To: <YCZVvxxHI8mMEwTC@kroah.com>

..snip
>> -};
>> -module_platform_driver(pvpanic_mmio_driver);
>> diff --git a/drivers/misc/pvpanic/Kconfig b/drivers/misc/pvpanic/Kconfig
>> new file mode 100644
>> index 00000000..0dce6ef
>> --- /dev/null
>> +++ b/drivers/misc/pvpanic/Kconfig
>> @@ -0,0 +1,12 @@
>> +config PVPANIC
>> +	bool "pvpanic device support"
>> +	help
>> +	  This option enables pvpanic device driver.
> No it doesn't, it allows you to _select_ a specific pvpanic driver, on
> its own, it is not a driver, right?

Yes. I will update the comment.


>> +
>> +config PVPANIC_MMIO
>> +	tristate "pvpanic MMIO device support"
>> +	depends on HAS_IOMEM && (ACPI || OF) && PVPANIC
>> +	help
>> +	  This driver provides support for the pvpanic device.  pvpanic is
>> +	  a paravirtualized device provided by QEMU; it lets a virtual machine
>> +	  (guest) communicate panic events to the host.
>> diff --git a/drivers/misc/pvpanic/Makefile b/drivers/misc/pvpanic/Makefile
>> new file mode 100644
>> index 00000000..9ea3355
>> --- /dev/null
>> +++ b/drivers/misc/pvpanic/Makefile
>> @@ -0,0 +1,2 @@
>> +obj-$(CONFIG_PVPANIC_MMIO)	+= pvpanic-mmio.o
>> +pvpanic-mmio-objs := pvpanic-common.o mmio.o
> You put the "common" logic in the mmio driver?  How is that going to
> work for the PCI driver?
>
> Why is there not a pvpanic.ko that contains the "core" code only?

My intention was to put the code in both drivers. There is no generic 
module as it will complicate things: the generic module would have to 
have its own state (e.g. pvpanic_probe would have to create a queue of 
base addresses).

Do you want to see a generic module pvpanic.ko with its own state?

Thank you,
Mihai


  reply	other threads:[~2021-02-12 10:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12  9:17 [PATCH v2] add support for pci in the pvpanic driver Mihai Carabas
2021-02-12  9:17 ` [PATCH v2 1/3] misc/pvpanic: split-up generic and platform dependent code Mihai Carabas
2021-02-12 10:12   ` Arnd Bergmann
2021-02-12 10:17   ` Greg KH
2021-02-12 10:29     ` Mihai Carabas [this message]
2021-02-12 11:00       ` Greg KH
2021-02-12 12:26   ` kernel test robot
2021-02-12  9:17 ` [PATCH v2 2/3] misc/pvpanic: add PCI driver Mihai Carabas
2021-02-12 10:15   ` Arnd Bergmann
2021-02-12 10:18   ` Greg KH
2021-02-12 10:23     ` Arnd Bergmann
2021-02-12  9:17 ` [PATCH v2 3/3] misc/pvpanic: add license Mihai Carabas
2021-02-12 10:13   ` Arnd Bergmann
2021-02-12 10:15   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a37c9549-14e1-6a80-7163-3a56414ff3f7@oracle.com \
    --to=mihai.carabas@oracle.com \
    --cc=arnd@arndb.de \
    --cc=bobo.shaobowang@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®