From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11354C43217 for ; Tue, 22 Nov 2022 09:25:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232243AbiKVJZK (ORCPT ); Tue, 22 Nov 2022 04:25:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232500AbiKVJZI (ORCPT ); Tue, 22 Nov 2022 04:25:08 -0500 Received: from out30-45.freemail.mail.aliyun.com (out30-45.freemail.mail.aliyun.com [115.124.30.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB7D53FB9A; Tue, 22 Nov 2022 01:25:06 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R531e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0VVRfUdC_1669109100; Received: from 30.221.132.69(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0VVRfUdC_1669109100) by smtp.aliyun-inc.com; Tue, 22 Nov 2022 17:25:02 +0800 Message-ID: Date: Tue, 22 Nov 2022 17:24:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [External] : [RFC PATCH v2 1/6] perf vendor events arm64: Add topdown L1 metrics for neoverse-n2 To: John Garry , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Will Deacon , James Clark , Mike Leach , Leo Yan , Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andrew Kilroy , Shuai Xue , Zhuo Song References: <1667214694-89839-1-git-send-email-renyu.zj@linux.alibaba.com> <1668411720-3581-2-git-send-email-renyu.zj@linux.alibaba.com> <590ff032-d271-48ee-a4d8-141cc070c335@oracle.com> <75c4f0e6-3f28-a748-e891-7be6016ca28e@oracle.com> From: Jing Zhang In-Reply-To: <75c4f0e6-3f28-a748-e891-7be6016ca28e@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/11/22 上午1:55, John Garry 写道: > On 21/11/2022 15:17, Jing Zhang wrote: >> I'm sorry that I misunderstood the purpose of putting metric as arch_std_event at first, >> and now it works after the modification over your suggestion. >> >> But there are also a few questions: >> >> 1. The value of the slot in the topdownL1 is various in different architectures, for example, >> the slot is 5 on neoverse-n2. If I put topdownL1 metric as arch_std_event, then I need to >> specify the slot to 5 in n2. I can specify slot values in metric like below, but is there any >> other concise way to do this? >> >> diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json >> index 8ff1dfe..b473baf 100644 >> --- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json >> +++ b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json >> @@ -1,4 +1,23 @@ >> [ >> +       { >> +               "MetricExpr": "5", >> +               "PublicDescription": "A pipeline slot represents the hardware resources needed to process one uOp", >> +               "BriefDescription": "A pipeline slot represents the hardware resources needed to process one uOp", >> +               "MetricName": "slot" > > Ehhh....I'm not sure if that is a good idea. Ian or anyone else have an opinion on this? It is possible to reuse metrics, so it should work, but... > > One problem is that "slot" would show up as a metric, which you would not want. > > Alternatively I was going to suggest that you can overwrite specific std arch event attributes. So for example of frontend_bound, you could have: > > + b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json > @@ -0,0 +1,30 @@ > [ >     { >     "ArchStdEvent": "FRONTEND_BOUND", >         "MetricExpr": "(stall_slot_frontend - cpu_cycles) / (5 * cpu_cycles)", >     }, > >> +       } >> +       { >> +               "ArchStdEvent": "FRONTEND_BOUND" >> +       }, >> +       { >> +               "ArchStdEvent": "BACKEND_BOUND" >> +       }, >> +       { >> +               "ArchStdEvent": "WASTED" >> +       }, >> +       { >> +               "ArchStdEvent": "RETIRING" >> +       }, >> >> >> 2. Should I add the topdownL1 metric to tools/perf/pmu-event/recommended.json, >> or create a new json file to place the general metric? > > It would not belong in recommended.json as that is specifically for arch-recommended events. It would really just depend on where the value comes from, i.e. arm arm or sbsa. > Thanks for your suggestion, I will send next patchset as you suggested.