From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Muchun Song <smuchun@gmail.com>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
zhaowuyun@wingtech.com
Subject: Re: [PATCH] driver core: Fix use-after-free and double free on glue directory
Date: Sun, 28 Apr 2019 13:10:19 +0300 [thread overview]
Message-ID: <a37e7a49c3e7fa6ece2be2b76798fef3e51ade4e.camel@kernel.crashing.org> (raw)
In-Reply-To: <CAPSr9jHhwASv7=83hU+81mC0JJyuyt2gGxLmyzpCOfmc9vKgGQ@mail.gmail.com>
On Thu, 2019-04-25 at 23:44 +0800, Muchun Song wrote:
> I agree with you that the looking up of the glue dir and creation of its child
> should be protected by the same lock of gdp_mutex. So, do you agree with
> the fix of the following code snippet?
The basic idea yes, the whole bool *locked is horrid though. Wouldn't it
work to have a get_device_parent_locked that always returns with the mutex held,
or just move the mutex to the caller or something simpler like this ?
Ben.
next prev parent reply other threads:[~2019-04-28 10:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 14:32 Muchun Song
2019-04-25 9:24 ` Benjamin Herrenschmidt
2019-04-25 15:44 ` Muchun Song
2019-04-28 10:10 ` Benjamin Herrenschmidt [this message]
2019-04-28 14:49 ` Muchun Song
2019-05-02 6:25 ` Benjamin Herrenschmidt
2019-05-04 14:47 ` Muchun Song
2019-05-04 15:34 ` Greg KH
2019-05-09 14:38 ` Gaurav Kohli
2019-05-09 23:22 ` Benjamin Herrenschmidt
2019-05-10 3:31 ` Gaurav Kohli
2019-05-14 10:56 ` Mukesh Ojha
2019-05-14 10:59 ` Prateek Sood
2019-05-14 11:51 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a37e7a49c3e7fa6ece2be2b76798fef3e51ade4e.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=smuchun@gmail.com \
--cc=zhaowuyun@wingtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome