mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: K Prateek Nayak <kprateek.nayak@amd.com>
To: John Stultz <jstultz@google.com>, Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Christian Loehle <christian.loehle@arm.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Joel Fernandes <joelagnelf@nvidia.com>,
	Qais Yousef <qyousef@layalina.io>, Ingo Molnar <mingo@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Valentin Schneider <vschneid@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>,
	Zimuzo Ezeozue <zezeozue@google.com>,
	Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>,
	Boqun Feng <boqun.feng@gmail.com>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Metin Kaya <Metin.Kaya@arm.com>,
	Xuewen Yan <xuewen.yan94@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Suleiman Souhlal <suleiman@google.com>,
	Andrea Righi <arighi@nvidia.com>,
	kuyo chang <kuyo.chang@mediatek.com>, hupu <hupu.gm@gmail.com>,
	<kernel-team@android.com>
Subject: Re: [RESEND][PATCH v31 1/9] sched/deadline: Ignore proxy-exec sched_yield()
Date: Tue, 11 Aug 2026 11:40:46 +0530	[thread overview]
Message-ID: <a382c862-3c60-436e-954c-621c68452418@amd.com> (raw)
In-Reply-To: <76bf6fb3-2406-4a01-a37d-1626ef34ae18@amd.com>

On 8/11/2026 9:25 AM, K Prateek Nayak wrote:
> P.S. I dropped this patch and added the following on top of this
> series on top of tip:sched/core and nothing has crashed (yet):
> 
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index a3003b0f4522..797cb316fcd1 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -101,7 +101,11 @@ static inline struct sched_dl_entity *pi_of(struct sched_dl_entity *dl_se)
>  
>  static inline bool is_dl_boosted(struct sched_dl_entity *dl_se)
>  {
> -	return false;
> +	struct dl_rq *dl_rq = dl_rq_of_se(dl_se);
> +	struct rq *rq = rq_of_dl_rq(dl_rq);
> +
> +	return sched_proxy_exec() && rq->donor != rq->curr && dl_task_of(dl_se) == rq->donor;
> +
>  }
>  #endif /* !CONFIG_RT_MUTEXES */
>  
> ---

Nevermind, I had CONFIG_RT_MUTEXES enabled and on doing:

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 97d6dc039e9b..909174e332ca 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -94,7 +94,7 @@ static inline bool is_dl_boosted(struct sched_dl_entity *dl_se)
 	struct dl_rq *dl_rq = dl_rq_of_se(dl_se);
 	struct rq *rq = rq_of_dl_rq(dl_rq);
 
-	return (pi_of(dl_se) != dl_se) || (sched_proxy_exec() && rq->donor != rq->curr && dl_task_of(dl_se) == rq->donor);
+	return (pi_of(dl_se) != dl_se) || (sched_proxy_exec() && rq->donor != rq->curr);
 }
 #else /* !CONFIG_RT_MUTEXES: */
 static inline struct sched_dl_entity *pi_of(struct sched_dl_entity *dl_se)
@@ -107,7 +107,7 @@ static inline bool is_dl_boosted(struct sched_dl_entity *dl_se)
 	struct dl_rq *dl_rq = dl_rq_of_se(dl_se);
 	struct rq *rq = rq_of_dl_rq(dl_rq);
 
-	return sched_proxy_exec() && rq->donor != rq->curr && dl_task_of(dl_se) == rq->donor;
+	return sched_proxy_exec() && rq->donor != rq->curr;
 
 }
 #endif /* !CONFIG_RT_MUTEXES */
---

I see only a bunch of SCHED_OTHER tasks proxying so clearly that doesn't
work but I think proxy should do something similar how rt_mutex handle
this under PI.

-- 
Thanks and Regards,
Prateek


  reply	other threads:[~2026-08-11  6:11 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07  3:52 [RESEND][PATCH v31 0/9] Sleeping Owner Handling for Proxy Execution (v31) John Stultz
2026-08-07  3:52 ` [RESEND][PATCH v31 1/9] sched/deadline: Ignore proxy-exec sched_yield() John Stultz
2026-08-10 15:56   ` Peter Zijlstra
2026-08-10 19:25     ` John Stultz
2026-08-11  3:55       ` K Prateek Nayak
2026-08-11  6:10         ` K Prateek Nayak [this message]
2026-08-11  8:33         ` Juri Lelli
2026-08-07  3:52 ` [RESEND][PATCH v31 2/9] sched/core: Don't steal a proxy-exec donor John Stultz
2026-09-02  7:55   ` [tip: sched/core] " tip-bot2 for Vasily Gorbik
2026-08-07  3:52 ` [RESEND][PATCH v31 3/9] sched/core: Avoid migrating blocked_on tasks John Stultz
2026-09-02  7:55   ` [tip: sched/core] " tip-bot2 for John Stultz
2026-08-07  3:52 ` [RESEND][PATCH v31 4/9] sched/core: Don't proxy-exec unmatched cookie lock owners John Stultz
2026-09-02  7:55   ` [tip: sched/core] " tip-bot2 for Vasily Gorbik
2026-08-07  3:52 ` [RESEND][PATCH v31 5/9] sched: Switch rq->next_class in proxy_reset_donor() John Stultz
2026-09-02  7:54   ` [tip: sched/core] " tip-bot2 for John Stultz
2026-08-07  3:52 ` [RESEND][PATCH v31 6/9] sched: Break out core of attach_tasks() helper into sched.h John Stultz
2026-09-02  7:54   ` [tip: sched/core] " tip-bot2 for John Stultz
2026-08-07  3:52 ` [RESEND][PATCH v31 7/9] sched: Migrate whole chain in proxy_migrate_task() John Stultz
2026-09-02  7:54   ` [tip: sched/core] " tip-bot2 for John Stultz
2026-08-07  3:52 ` [RESEND][PATCH v31 8/9] sched: Add deactivated (sleeping) owner handling to find_proxy_task() John Stultz
2026-08-11 19:08   ` Atul Kumar Pant
2026-08-11 19:56     ` John Stultz
2026-08-12  2:21       ` Atul Kumar Pant
2026-08-13 13:48   ` Peter Zijlstra
2026-08-13 14:24     ` Peter Zijlstra
2026-08-13 14:40   ` Peter Zijlstra
2026-08-07  3:52 ` [RESEND][PATCH v31 9/9] sched: Distinguish proxy activations from wakeups John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a382c862-3c60-436e-954c-621c68452418@amd.com \
    --to=kprateek.nayak@amd.com \
    --cc=Metin.Kaya@arm.com \
    --cc=arighi@nvidia.com \
    --cc=boqun.feng@gmail.com \
    --cc=bsegall@google.com \
    --cc=christian.loehle@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=hupu.gm@gmail.com \
    --cc=joelagnelf@nvidia.com \
    --cc=jstultz@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=kernel-team@android.com \
    --cc=kuyo.chang@mediatek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=qyousef@layalina.io \
    --cc=rostedt@goodmis.org \
    --cc=suleiman@google.com \
    --cc=tglx@linutronix.de \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=will@kernel.org \
    --cc=xuewen.yan94@gmail.com \
    --cc=zezeozue@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®