From: Markus Elfring <Markus.Elfring@web.de>
To: Kent Overstreet <kent.overstreet@linux.dev>,
linux-bcachefs@vger.kernel.org
Cc: Liao Yuanhong <liaoyuanhong@vivo.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bcachefs: Simplify kzalloc usage
Date: Thu, 31 Jul 2025 22:00:31 +0200 [thread overview]
Message-ID: <a3860880-acfb-41cc-98dd-0d878d9b37dd@web.de> (raw)
In-Reply-To: <ztnjjzlx3a2cvmxnc3jx2umwlh2faetdy6rzhmuc746vppmuns@lzn33bv2smpz>
>>> Use the shorter variants will improves further maintainability.
>>> Convenient for subsequent code updates or refactoring.
>>
>> Please improve such a change description.
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16#n45
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.16#n941
>
> The commit message is reasonable, it communicates the intent.
* I would wonder about the relevance of a shorter item here.
* Would you like to avoid wording weaknesses?
Another example for previous contributions:
https://lore.kernel.org/all/?q=%22Improve%20size%20determinations%22
> I haven't decided if I want to apply it; the dereference approach is
> better in principle but it's very far off into the weeds of "things that
> will never, ever cause an actual problem".
Have you got development views which might be in contradiction
to the preferred Linux coding style?
Regards,
Markus
next prev parent reply other threads:[~2025-07-31 20:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 13:15 Liao Yuanhong
2025-07-31 18:52 ` Markus Elfring
2025-07-31 19:19 ` Kent Overstreet
2025-07-31 20:00 ` Markus Elfring [this message]
2025-08-01 2:28 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3860880-acfb-41cc-98dd-0d878d9b37dd@web.de \
--to=markus.elfring@web.de \
--cc=kent.overstreet@linux.dev \
--cc=liaoyuanhong@vivo.com \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®