From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECEB32E7BD0; Mon, 8 Sep 2025 11:07:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757329668; cv=none; b=b7KCgJmoEfFv5GYduCRjBmYpI1xGEyfFsB1U67tWqnqV+GwuySamz3Jc9gUULoahTfZV7sNK+TMo/wugv8YZc9cXRtgLdZnFEu4K96/YRH5sXrPAJ8On7Y/tubtWtu+uSDJRjnzZ2uX5D/1Gre9lOIrS1IrCKbXfNr6EX0futOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757329668; c=relaxed/simple; bh=1FslJBhOV4oLwBBRKYVHO5hLWyRrnGhIX3Sjj2LP/A0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=D9N874HE/BzxNZ9UFwwtCDg6TARYff8+6gjWrUNcsX50PPSp6T/ou31l3O7+Ofgeyptf63V2bnvk+kMKe7xhbUkzQDj7ih6F2weMbGojVVpgoVdnXupdExM/q+drkBkKGAvZFo9bDDeIqF7TmSjAhth17kc+VdPJBkZIStpIHl4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hhpeDntA; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hhpeDntA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1757329667; x=1788865667; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=1FslJBhOV4oLwBBRKYVHO5hLWyRrnGhIX3Sjj2LP/A0=; b=hhpeDntApiBesqkM6MQ35aAvW69Jrrbb07K6DOKm4XRMa88cQQMlHgVi PqVmcA49oAv0onJBarfKZufzy4RFKAe2aUF8x23fNSh76WWrwv4qRnr3G qhOrmNh7J3KqxmKOy/QGY1sB2GKlh3nDUjMO4ZGa76lXd1f224elNNyFE giWoutV9gFqwyDVn449H6w/OFadm2u7iO5H998c6o1oPPwdBD9R4E4fCr Pi6CjcA23L35CuMhtoKqkFpSXZjIrPZacj67yzurm55YFEgnGBVNTym3t C93utALyQAn0MiOStDeotL9DH8FZjrcsKLmqPZlYOwkDFkF1I9inpjwhD Q==; X-CSE-ConnectionGUID: aes1/SAXRkmlUdd+XAGeuw== X-CSE-MsgGUID: vbfmdkmQTL6PQOulc348jg== X-IronPort-AV: E=McAfee;i="6800,10657,11531"; a="59652801" X-IronPort-AV: E=Sophos;i="6.17,312,1747724400"; d="scan'208";a="59652801" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2025 04:07:46 -0700 X-CSE-ConnectionGUID: slWKUjoPSwi6xW6amKTnKw== X-CSE-MsgGUID: 4mtX+1hdQsSvW6PGnq5dHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,248,1751266800"; d="scan'208";a="177121172" Received: from carterle-desk.ger.corp.intel.com (HELO localhost) ([10.245.246.204]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2025 04:07:41 -0700 From: Jani Nikula To: syyang , robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, yangsunyun1993@gmail.com, syyang Subject: Re: [PATCH v1 2/2] This patch adds a new DRM bridge driver for the Lontium LT9611C chip. In-Reply-To: <20250903123825.1721443-3-syyang@lontium.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250903123825.1721443-1-syyang@lontium.com> <20250903123825.1721443-3-syyang@lontium.com> Date: Mon, 08 Sep 2025 14:07:38 +0300 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, 03 Sep 2025, syyang wrote: > +static int i2c_write_byte(struct lt9611c *lt9611c, u8 reg, u8 val) > +static int i2c_read_byte(struct lt9611c *lt9611c, u8 reg, u8 *val) > +static int i2c_read_write_flow(struct lt9611c *lt9611c, u8 *params, > + unsigned int param_count, u8 *return_buffer, > + unsigned int return_count) include/linux/i2c.h provides a plethora of i2c_ prefixed functions and types. I think it's bad practice to reuse the prefix of a very common kernel interface, even if in static functions. You might get collisions later, but the reader of the code is mislead to believe this is something in i2c.h. BR, Jani. -- Jani Nikula, Intel