From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 625681A23A6 for ; Mon, 4 May 2026 13:05:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777899907; cv=none; b=DKAT8qXTjeuP7KqS+JvKKdOLPRp3EqcI/VvIghhWEZ1Hu8fLJSC4iU8L3ZYgNdRcSfsO2a1xaT9ntTzGSiQhAobMeYI6AkGkPwdY28Ql1WOQXTvJjihJse5TeG6hxAJUZBCSRFIJcYNbhkXljPgWXLiO98XukvIkqNpl7rXoSwU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777899907; c=relaxed/simple; bh=8/qYV9GNS+6nij6A5YaKpMRHxcuDhEeiDUgJC3C0OvA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C9z/k4K7yK2B44uODasbf4WMsszQduaHJdIawO07ALc2XsawsWOPwrc+n8yAGkkFv2q5o1NCQxedfq++jzq6VhbUS0oAdfMPJDrMk0a4fTu+9Q+dI75ZGalZbxWAkk+tSB6Vn4MlpZ0iWTWH3/j74tGmPKbJQSDn8yhSKTw6bG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TFSLLzAb; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TFSLLzAb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777899905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lCpIucwug7LQBxR+zBCSrNGWbfwlTlZlRpoANQyu5ws=; b=TFSLLzAbJ4u9vQq0u4RsI+C5jXNrb59aLu/FBj6yav9wopmoNjzKdzZgH9Y+vtRwZHNaVM Ze+GsPAqtvpfI3x9GEC1xD2nOok//vctLK1K4wFypWu8hptRukzMmjD6Ecn5HL3r6OVT3E ZxCckwG62G+HHd4/A4Lmu7O08T9seIY= Received: from mail-oa1-f72.google.com (mail-oa1-f72.google.com [209.85.160.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-93-W93295kqPaGGO6I6yQNMAg-1; Mon, 04 May 2026 09:05:02 -0400 X-MC-Unique: W93295kqPaGGO6I6yQNMAg-1 X-Mimecast-MFC-AGG-ID: W93295kqPaGGO6I6yQNMAg_1777899902 Received: by mail-oa1-f72.google.com with SMTP id 586e51a60fabf-415e1e9aa5dso6244854fac.0 for ; Mon, 04 May 2026 06:05:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777899901; x=1778504701; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lCpIucwug7LQBxR+zBCSrNGWbfwlTlZlRpoANQyu5ws=; b=L+yNDBbFfU2u4iBCkNS6q0Cg1s8WL8uM84MA732puhWpQ2Q/6OHc/xhX6qL33voWgI XG+PSf+W+HcpCgmte7ODe8PORRGoItje6OMu9KGaJ1FUzmGgYXtDAs29dI7s9igZ8m0H Z1BnPkaaR5jrZyUzxi1kWDa0OjUOjpa0oQabUhttlxj2i7GzGA0C/49mndTK2P0B8rmC V6FR98VCE4d4y4Sr9a5NezDtdIhjewxHrx+XFxentUMvzvX8uID5feq5E9Z5L7ruo1t4 LKzOduBPBK5Bh+641sQM4QegdAdT3PgtNsz0uq6M/JV9Fik4fFuE8nIug18RMB2Zxj30 j0LA== X-Forwarded-Encrypted: i=1; AFNElJ+YGPu1r7MIHita+QdVddMLZegX+cbxZ5Dtpnl+AKuHiF7HCSTrPn5mDvpJHwEPyj5cd3JVDzOMG8L4igg=@vger.kernel.org X-Gm-Message-State: AOJu0YzUwsK61Eyo5wj/pGeo5uSl8Xh2Y/LjVUGqlDrbh+Rc6hY1/Grn /4j12QM/A0C94H78Vq+dt4UFE0YYZyCAJtda8IEZKQkIhMbI/w/ghVmp9+P5d8FJ4oXsBR511Ju YRJFybDkipdR7B2kTpgUx35iK/LWY7R9GYfkR5VWE7Zx5yFn/O8WOSO6tCNb+vcjaQg== X-Gm-Gg: AeBDiesPyWl59O1O/Dfyjk5tE+h83N40on67HPDKWCUt3pbUWhO77nreyb2D/KHwBcw CdWVUsLggAmTciBYUDdMSv7dgG/kVLJO4tHilSrg4nkF8bLX7oZ0MnaPqCEOTPcig8UZZ3OTdJy FyDqcDg7XjaL+aQWYHC7nD5fMeEhn7ye1u++5914ok3UmtOjpJzH71L9bogeyWrPgzB18vOjMp0 3o/BOt5aBUmp4mKX+rI9KDXdxh/qsH7yc3QO0gR5hhz7Wk0zyyvQKttv6ygMaCLPvCmRkDNJoma 0UXS5K5xh/suVOqjQWG9JHKKVxRvsd2+gnAqtA1gVJrvLFOpUR+sAvi5hw8j4tdDd9gSO47mNqp F62nLIQaL1lWE79tQo+kmNfqpqDIkWluBaUo= X-Received: by 2002:a05:6870:1687:b0:42c:259c:6c8a with SMTP id 586e51a60fabf-43475f95c61mr4835371fac.6.1777899901309; Mon, 04 May 2026 06:05:01 -0700 (PDT) X-Received: by 2002:a05:6870:1687:b0:42c:259c:6c8a with SMTP id 586e51a60fabf-43475f95c61mr4835140fac.6.1777899899273; Mon, 04 May 2026 06:04:59 -0700 (PDT) Received: from [192.168.2.110] ([70.53.202.134]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51040b5e8b4sm106472551cf.23.2026.05.04.06.04.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2026 06:04:58 -0700 (PDT) Message-ID: Date: Mon, 4 May 2026 09:04:47 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 27/54] selftests/mm: hugepage_settings: add APIs for HugeTLB setup and teardown To: Mike Rapoport Cc: Andrew Morton , David Hildenbrand , Baolin Wang , Barry Song , Dev Jain , Donet Tom , Jason Gunthorpe , John Hubbard , "Liam R. Howlett" , Lance Yang , Leon Romanovsky , Lorenzo Stoakes , Mark Brown , Michal Hocko , Nico Pache , Peter Xu , Ryan Roberts , Sarthak Sharma , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , Zi Yan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org References: <20260428204240.1924129-1-rppt@kernel.org> <20260428204240.1924129-28-rppt@kernel.org> <2f443474-4448-462e-bc1e-55bc657d70ba@redhat.com> <22b1cadc-4b0d-4e2a-987c-e7a7bc2265eb@redhat.com> Content-Language: en-US, en-CA From: Luiz Capitulino In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-05-02 00:36, Mike Rapoport wrote: > On Fri, May 01, 2026 at 03:30:18PM -0400, Luiz Capitulino wrote: >> On 2026-05-01 11:25, Mike Rapoport wrote: >>>>> return mode == 1 || mode == 3; >>>>> } >>>>> +#define HUGETLB_MAX_NR_PAGESIZES 10 >>>>> +struct hugetlb_settings { >>>>> + unsigned long free_hugepages[HUGETLB_MAX_NR_PAGESIZES]; >>>> >>>> It looks like we don't actually use this in the API or maybe I'm missing >>>> something? >>> >>> Yes, it's used only in later patches. >> >> I don't see it, the patch below builds fine (again, sorry in advance if >> I'm missing something obvious): > > You are right, I misunderstood you comment and I thought you referred to > entire API being unused in this patch. > > free_hugepages is not used and it should not be a part of the saved state. Thanks, I'll try to be more specific next time. > >> diff --git a/tools/testing/selftests/mm/hugepage_settings.c b/tools/testing/selftests/mm/hugepage_settings.c >> index 097ba085f423..a023cfeb69c5 100644 >> --- a/tools/testing/selftests/mm/hugepage_settings.c >> +++ b/tools/testing/selftests/mm/hugepage_settings.c >> @@ -341,7 +341,6 @@ bool thp_is_enabled(void) >> #define HUGETLB_MAX_NR_PAGESIZES 10 >> struct hugetlb_settings { >> - unsigned long free_hugepages[HUGETLB_MAX_NR_PAGESIZES]; >> unsigned long nr_hugepages[HUGETLB_MAX_NR_PAGESIZES]; >> unsigned long sizes[HUGETLB_MAX_NR_PAGESIZES]; >> unsigned long default_size; >> @@ -509,7 +508,6 @@ static void __hugetlb_save_settings(void) >> if (!sz) >> continue; >> - settings->free_hugepages[i] = hugetlb_free_pages(sz); >> settings->nr_hugepages[i] = hugetlb_nr_pages(sz); >> } >> >>> I felt it would be too churny to add users in this patch. >>>> Otherwise, the API looks great to me. But if you allow me to bikeshed :) >>>> >>>> I think I'd do: >>>> >>>> struct hugetlb_state { >>>> unsigned long nr_hugepages; >>>> unsigned long size; >>>> }; >>>> >>>> struct hugetlb_settings { >>>> struct hugetlb_state hstate[HUGETLB_MAX_PAGESIZES]; >>>> unsigned long default_size; >>>> int nr_sizes; >>>> }; >>> >>> It might be slightly nicer abstraction but ... >>>>> +static void __hugetlb_save_settings(void) >>>>> +{ >>>>> + struct hugetlb_settings *settings = &hugetlb_saved_settings; >>>>> + int nr_sizes; >>>>> + >>>>> + settings->default_size = default_huge_page_size(); >>>>> + if (!settings->default_size) >>>>> + return; >>>>> + >>>>> + nr_sizes = detect_hugetlb_page_sizes(settings->sizes, >>>>> + HUGETLB_MAX_NR_PAGESIZES); >>> >>> ... this immediately becomes more complex. >>> >>>>> + if (!nr_sizes) { >>>>> + settings->default_size = 0; >>>>> + return; >>>>> + } >>>>> + >>>>> + for (int i = 0; i < nr_sizes; i++) { >>>>> + unsigned long sz = settings->sizes[i]; >>>>> + >>>>> + if (!sz) >>>>> + continue; >>>>> + >>>>> + settings->free_hugepages[i] = hugetlb_free_pages(sz); >>>>> + settings->nr_hugepages[i] = hugetlb_nr_pages(sz); >>> >>> And this as well. >> >> We'd need a little more code to handle those cases, may or may not be >> worth it. But enough bikesheding from my side :) the series is great as >> is. >> >> >