From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752687AbdDKRR3 (ORCPT ); Tue, 11 Apr 2017 13:17:29 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:21161 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751695AbdDKRR0 (ORCPT ); Tue, 11 Apr 2017 13:17:26 -0400 Subject: Re: [PATCH] net: phy: micrel: KSZ9031: fix crash when statistic requested To: Andrew Lunn References: <20170410233324.1178-1-grygorii.strashko@ti.com> <050b6778-276b-7094-36e1-1ccd06364766@ti.com> <20170411163628.GL27307@lunn.ch> CC: Florian Fainelli , "David S. Miller" , , Sekhar Nori , From: Grygorii Strashko Message-ID: Date: Tue, 11 Apr 2017 12:17:16 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170411163628.GL27307@lunn.ch> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.83.96] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/11/2017 11:36 AM, Andrew Lunn wrote: >> I've considered all this option, honestly, but I do not know if this >> phys (issue should affect KSZ886X, KSZ8873MLL, KSZ9031, KSZ9021, KSZ8061, KS8737) >> support fetching statistics or not and was hoping to get feedback from community. > > Hi Grygorii > > Microchip are one of the good guys. All there datesheets are open. So > you should be able to check this. Below is what i've found 0xa 0x15 action KS8737 - + remove stats? - reg 10(0xa) reserved KSZ8061MNX/MNG - + remove stats? - reg 10(0xa) reserved KSZ9021GN + + add .probe() KSZ9031 + + add .probe() KSZ8873MLL/FLL/RLL - - remove stats KSZ886X/KSZ8862 - - remove stats The kszphy_probe() can be reused as .probe() callback as it seems not phy specific. -- regards, -grygorii