From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752734AbdK3MWn (ORCPT ); Thu, 30 Nov 2017 07:22:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46972 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157AbdK3MWm (ORCPT ); Thu, 30 Nov 2017 07:22:42 -0500 Subject: Re: [PATCH v3 8/9] KVM: x86: Disable Intel Processor Trace when VMXON in L1 guest To: Luwei Kang , kvm@vger.kernel.org Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, rkrcmar@redhat.com, linux-kernel@vger.kernel.org, joro@8bytes.org References: <1511814242-12949-1-git-send-email-luwei.kang@intel.com> <1511814242-12949-9-git-send-email-luwei.kang@intel.com> From: Paolo Bonzini Message-ID: Date: Thu, 30 Nov 2017 13:22:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1511814242-12949-9-git-send-email-luwei.kang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 30 Nov 2017 12:22:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/11/2017 21:24, Luwei Kang wrote: > > + if (pt_mode == PT_MODE_HOST_GUEST) { > + vmx->pt_desc.guest.ctl &= ~RTIT_CTL_TRACEEN; > + pt_disable_intercept_for_msr(FALSE); > + vmcs_write64(GUEST_IA32_RTIT_CTL, vmx->pt_desc.guest.ctl); > + } > + Using vmx_set_msr would be nicer. Alternatively, extract this: + pt_disable_intercept_for_msr(data & RTIT_CTL_TRACEEN); + vmcs_write64(GUEST_IA32_RTIT_CTL, data); + vmx->pt_desc.guest.ctl = data; into a new function vmx_set_rtit_ctl(vcpu, data), and call it here. Thanks, Paolo