From: Frieder Hannenheim <git@fhannenheim.net>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Robert Oscilowski" <drgitx@gmail.com>,
"Jean-François Bobier" <jf.bobier@gmail.com>,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: oneplus-kebab: new device
Date: Sat, 17 Oct 2026 20:14:50 +0200 [thread overview]
Message-ID: <a39ab904-261b-4b2a-b0d8-8d921deee61b@fhannenheim.net> (raw)
In-Reply-To: <20261017-lively-trout-of-hail-8fbaed@quoll>
On 17.10.26 18:46, Krzysztof Kozlowski wrote:
> On Thu, Oct 15, 2026 at 02:32:37PM +0200, Frieder Hannenheim wrote:
>> Add initial device-tree for the OnePlus 8T. Downstream reference is [1].
>>
>> [1] https://github.com/LineageOS/android_kernel_oneplus_sm8250/blob/lineage-23.2/arch/arm64/boot/dts/vendor/oplus/kona-kebab-overlay.dts
>>
>> Signed-off-by: Frieder Hannenheim <git@fhannenheim.net>
>> Co-developed-by: Robert Oscilowski <drgitx@gmail.com>
>> Signed-off-by: Robert Oscilowski <drgitx@gmail.com>
>
> Your SoB is the last. Please follow closely submitting patches document.
>
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.
>
> Best regards,
> Krzysztof
Hi Krzysztof,
thanks for pointing this out. I will put my SoB last. I have run
checkpatch (see the output below) and it has shown me no warnings that I
deem actionable. (MAINTAINERS does not seem to contain other dt
maintainers and wrapping the link would break it).
Kind regards,
Frieder
$ ./scripts/checkpatch.pl -g HEAD-3 --strict
> -------------------------------------------------------------------
> Commit 3b78f6c36076 ("dt-bindings: arm: qcom: Document OnePlus 8T")
> -------------------------------------------------------------------
> total: 0 errors, 0 warnings, 0 checks, 7 lines checked
>
> Commit 3b78f6c36076 ("dt-bindings: arm: qcom: Document OnePlus 8T") has no obvious style problems and is ready for submission.
> ------------------------------------------------------------------------
> Commit 485091777ce8 ("arm64: dts: qcom: Add sm8250-oneplus-common.dtsi")
> ------------------------------------------------------------------------
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #18:
> new file mode 100644
>
> total: 0 errors, 1 warnings, 0 checks, 607 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace.
>
> Commit 485091777ce8 ("arm64: dts: qcom: Add sm8250-oneplus-common.dtsi") has style problems, please review.
> -------------------------------------------------------------------
> Commit 72db2e5d2c06 ("arm64: dts: qcom: oneplus-kebab: new device")
> -------------------------------------------------------------------
> WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> #8:
> [1] https://github.com/LineageOS/android_kernel_oneplus_sm8250/blob/lineage-23.2/arch/arm64/boot/dts/vendor/oplus/kona-kebab-overlay.dts
>
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #32:
> new file mode 100644
>
> total: 0 errors, 2 warnings, 0 checks, 137 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace.
>
> Commit 72db2e5d2c06 ("arm64: dts: qcom: oneplus-kebab: new device") has style problems, please review.
>
> NOTE: If any of the errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
next prev parent reply other threads:[~2026-10-17 18:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 12:32 [PATCH v2 0/2] Add OnePlus 8T Frieder Hannenheim
2026-10-15 12:32 ` [PATCH v2 1/2] arm64: dts: qcom: Add sm8250-oneplus-common.dtsi Frieder Hannenheim
2026-10-16 8:25 ` Konrad Dybcio
2026-10-16 19:17 ` Frieder Hannenheim
2026-10-15 12:32 ` [PATCH v2 2/2] arm64: dts: qcom: oneplus-kebab: new device Frieder Hannenheim
2026-10-16 8:23 ` Konrad Dybcio
2026-10-17 16:46 ` Krzysztof Kozlowski
2026-10-17 18:14 ` Frieder Hannenheim [this message]
[not found] <c14fe062-2e87-4040-b9a8-7d90a04d7a8c@fhannenheim.net>
2026-10-16 16:38 ` Frieder Hannenheim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a39ab904-261b-4b2a-b0d8-8d921deee61b@fhannenheim.net \
--to=git@fhannenheim.net \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=drgitx@gmail.com \
--cc=jf.bobier@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®