From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B735D3815C0 for ; Mon, 30 Mar 2026 09:36:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774863417; cv=none; b=RgC6PHMNjhqEihSLnMt5Mjoo8rw5dmHKBMo371rFiJHIKnHRIMklRJnqNomrhuVHhaue8n9cz0akFKxwEhinQLlBMl3Twi+5TgS3ogy8T/bzR2vdolnzFcH2v6zJCrccvHGXkAPBfRAcXE5diyXR7J1eOyTuBw3Qu04F7kjodvw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774863417; c=relaxed/simple; bh=ow+j/FbhJNpyJ4jd32OsvrK0BH4YUa2nELDDf6A2lz0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U2Ih4/71mKZBa3c1AnMakdZDVTG3oUGxxelhe7Ecc/ztOJzbBtZzYKDe8lFIw3HYjOlSZrnTq39oYYtpMNHn8F6K6/8t1NgiWXEhiZTxja/esZrg6wu7HYZY/8MyNZxmaw6WjLIgu3E56ZEnuPTK16wn8jD/DZqftV9NdarKyqM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GpSMTQL0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ip7Kmp5i; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GpSMTQL0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ip7Kmp5i" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62U8Q04g2458393 for ; Mon, 30 Mar 2026 09:36:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Y829VMWcjmy2e+KlsWr0uhjRtCYBw0ZDjtDzMWwnIiE=; b=GpSMTQL0MDvPBO1w Qo0d8XFfBeVfuOcVtzpwHNSz/Np6+C2puYTJNBy+u5/iSoppkEx8AMwgsrT5nUjF ZJvRfgw0fsBkZRDBsNmajUvjpnaWYEkEBZMh13YNnv8/39NLdSYS+V2PT17fjU5X MacRQRfcPXbbT+RQSp5oaVwjagF8Ps4nEG2VlN7gsxnh44g2ikrtlSP+8jOvM9IK ABI6Drhu5NfRINiPiPmYS4XCS8IWPhQ2w+c1p9KDMD1xV6XAP70Ipj7HTJYJoWS9 nL5hvTD2SOebM/XTXrxYj8qtgl9encn2YPpchgWANayA66drgVbediT6CLIjuDjU c/cg1A== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7nnmra0k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 09:36:55 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35c1ef3c379so1248172a91.2 for ; Mon, 30 Mar 2026 02:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774863414; x=1775468214; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y829VMWcjmy2e+KlsWr0uhjRtCYBw0ZDjtDzMWwnIiE=; b=Ip7Kmp5iHHOUNF+CNEQHpcDNN5+C5Z+uJiU0qmA7Th2NnRoCVjRU5mciRYHK3zArP8 kVPnmrf9gyUfSLW/h4BaajOTFDNLIs5T8OqgsB+SUpXmu0fH0ClbKCF7lY9AF2KkiX9X rRBwJ86hMe40EuWOGh7CPMiM2Etgn95oqzO2Ixso/+IJw00SO79noDBXKmq2fU0p8BBN qUR+u+cuepoWXboED/qshXXDEvXEHTZZEJlSmoz4dTbzp8DLRQC4E88tnETa0i6pkoQ+ AcyC/zIXlpKLilE7uBZcvs4Te9VN4/Fftufds1YnTVnq+jB389WBkrWa0SShK9ZSOo3b QqmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774863414; x=1775468214; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y829VMWcjmy2e+KlsWr0uhjRtCYBw0ZDjtDzMWwnIiE=; b=afZO0g90CVFIcj8E1AmYiI7PNh1TO9InBShOg1YPJNOCCflj3xZ36FEyTg+YbZfqU7 Bw5Fhva5oo0qEyP5G0llETHX/8MKbdZPOBqcvDnx3NrMFydJey6k/yZZZJlcyrSr2FR3 +1NhsyReJytFcno/YoL1w+aRRzrhe4EoSpkk67EDpiFLzn+v5LkPzZmc4TIB+BjxIdXq bu9XnkSTYo3MzBKyDNT16Dp28tIpvR+t+Yjm7U7O9dECoWZ2X5icZC5Jt7x4PU4cfOhZ Fo4S4yj5QYlNy5izoWDE3XyhTEo1ZIk6eSEBVExC8pWIZIB0Gu6SxQ0F9L0AKfWgNGwp +yjg== X-Forwarded-Encrypted: i=1; AJvYcCU2ZV5eMxW5Vmm8RXLNpX0+dX8vEA4+aN5AO5RznjrLhXjMBz2aqb5IX8fd1KpRafp1rvv/+IVm5W5wgvQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyVJ1YLrx9OvkJTqwzYDFTQcB/dzcOv+pTwLLIzln3e3gb/EtZE E5nqrFnPkOBxuMwK52n920eV19oolL1xlfhmkKJp1jTeKidodGHRvaa0KIerhBmm8WTJ2SdtmQN VbDtralp4hrJ2WOjyzUBXmTh8W71lV4GRI8UE4ZWQdHudX7lr7L1evkqfuWyE1mtnIdAvuwQzgt 4= X-Gm-Gg: ATEYQzx6EWnfjhecvz8iRzgZ3wyvYIWw513TUKmqk6qN6K0pOD3BTpNw9Oo1DtnJ9Fz fjldxFjDDWpIqeNlW9fFR5q7pxs2OeFkUAabnbzr7X72rHIojCET78VNDztT66xMqfqGFm6tDL0 iI4ojyGJwuuJKO+yX1XfB8m3KRoCXNoEdi54LnLH37i5qMCUoV7fN1iU2f5Dw6/6As3vjzgJb+3 hC7xDwL7ij9Vo5TO91X6wfKSUMftK1FYOUBAkC8H/4CEGRcltEXNLYE0GsHnwcsrkr4Qy2RJqVB pzWSsyooMr3csD/maxIHTpgTv+zoT4daZ3irwb75KTH/5DMUw2IvAuOzHbiBhJHk51AmyKEdBfV W0c/pN+/21MXMR3ed79OMGjFs226r6Zy8Gg71kTCLob7cDYp0Yg== X-Received: by 2002:a17:90a:b396:b0:35d:92e4:c0aa with SMTP id 98e67ed59e1d1-35d92e4dc2dmr3259277a91.6.1774863413926; Mon, 30 Mar 2026 02:36:53 -0700 (PDT) X-Received: by 2002:a17:90a:b396:b0:35d:92e4:c0aa with SMTP id 98e67ed59e1d1-35d92e4dc2dmr3259262a91.6.1774863413472; Mon, 30 Mar 2026 02:36:53 -0700 (PDT) Received: from [10.218.41.33] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c2ec27da0sm3709913a91.8.2026.03.30.02.36.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 02:36:52 -0700 (PDT) Message-ID: Date: Mon, 30 Mar 2026 15:06:48 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Add monaco-evk-ac-sku support To: Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260328-monaco-evk-ac-sku-v1-0-79d166fa5571@oss.qualcomm.com> <20260328-monaco-evk-ac-sku-v1-1-79d166fa5571@oss.qualcomm.com> <20260329-accelerated-pigeon-of-joy-c6c903@quoll> <7f5bfeb8-7d91-419b-981d-1f0f568f01d2@kernel.org> Content-Language: en-US From: Umang Chheda In-Reply-To: <7f5bfeb8-7d91-419b-981d-1f0f568f01d2@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA3NSBTYWx0ZWRfX1+5L3idTI3Ow 5g/taU+JmPFDLcpYYrMdI8pBJjgTQcK717En4GeGN5Qfkja6Op5V/olN1wE8AFtC93YvPBIgUXC p7eajT5m5sAhflq8AGrxGNX8xTlGGN2SvSzWBMiVqqhFY7+tgC96lJyDPWtlhKEOZ7NHKNx896F Lv3O71nzei8MVGnUw/++SAQ3NxS3mOgIBXGBYTKWco9n3icC4d9J/03odY8ldq3xvGpvwAb8rYe fLVQ46gZmH2BD8g6W1K9puDNhaasK1oXjbkAOgsDgKZysJ41sFpPDP1247C3zhOAgj57mikgOf2 nDk5doqjrzTv9qEAjqkP2zY5RSH/xuc8jMNF4MQ2rm2CUHwUZNguu6uwRZJj7QtE3DUYknyIsIu o4M1gR/oXYXoJQFgzPJBBlVTtxGAzA4PCj6GD7o6OevgSbCOh/miqlGjRSa6ZjxM48u4MNSmw7z Xc0X0wzvAusOfIAuLLA== X-Authority-Analysis: v=2.4 cv=M4FA6iws c=1 sm=1 tr=0 ts=69ca4437 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=TMvvwhOKWeLxbQ7R-5UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: yKKV9wsCh3YPdbCtA1XrXPqnOTgfxIwy X-Proofpoint-ORIG-GUID: yKKV9wsCh3YPdbCtA1XrXPqnOTgfxIwy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 malwarescore=0 adultscore=0 impostorscore=0 bulkscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300075 Hello Krzysztof, On 3/30/2026 12:24 PM, Krzysztof Kozlowski wrote: > On 30/03/2026 08:50, Umang Chheda wrote: >> Hello Krzysztof, >> >> On 3/29/2026 3:22 PM, Krzysztof Kozlowski wrote: >>> On Sat, Mar 28, 2026 at 05:11:17PM +0530, Umang Chheda wrote: >>>> Introduce new bindings for the monaco-evk-ac-sku, >>>> an IoT board based on the QCS8300-AC variant SoC. >>> Please wrap commit message according to Linux coding style / submission >>> process (neither too early nor over the limit): >>> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 >> >> >> Ack >> >>> >>>> Signed-off-by: Umang Chheda >>>> --- >>>> Documentation/devicetree/bindings/arm/qcom.yaml | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >>>> index ca880c105f3b..07053cc2ac1c 100644 >>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >>>> @@ -918,6 +918,7 @@ properties: >>>> - enum: >>>> - arduino,monza >>>> - qcom,monaco-evk >>>> + - qcom,monaco-evk-ac-sku >>> Why adding name 'sku' to the compatible? What's the meaning here? >> >> >> Monaco SoC has 2 variants  - monaco-aa and monaco-ac -- "monaco-evk" board uses monaco-aa variant of SoC and this new > > so ac? or ac-sku? Decide. > >> introduced board uses the monaco-ac variant SoC. Hence added the compatible as "monaco-evk-ac-sku" to differentiate it from >> monaco-evk board. > > Wrap your emails. Ack > > "ac" differentiates. Why do you need to say that a variant is a > "-variant"? > The intent for using "-sku" here was to match the existing upstream practice where boards that are otherwise identical but differ in H/W configuration (SoC variant, storage etc) are represented as separate SKUs. For Example: - sc7180-trogdor-*-sku.dtsi - sc7280-herobrine-*-sku.dtsi - mt8183-kukui-jacuzzi-*-sku.dts Hence to follow the above convention and practice - Added "-sku" in the end. Please let me know your preference ? if it is okay dropping "-sku" - I will re-spin v2 with suggested changes. > Best regards, > Krzysztof Thanks, Umang