From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F1EC433CE for ; Wed, 16 Oct 2024 07:33:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729063983; cv=none; b=DkS4E8N5e4lG1XwYbwA4LQyLwhIZg1d2DPFI+BDxCU0YBBCZ9Rw2BmXJdnpeRMKjt4Gwga+nkAsrI9Ms4BHpqG124W2VqGCS7fy5Vy8oemq5JlYT1NmHKegY4JkHp8B5M2+IegcV+vkY5H/+6Ix2Fy6OXQ9RFnUf0HbdR0vO+40= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729063983; c=relaxed/simple; bh=T6awPUxcRV2/CBK1A8EemWwI0ARo5KzSn4uao/fe2u0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KS8fChlnGBwykiVoROpU20ymfEmdAXUoA/Fn0VN3lM6/pGN/UJpLC1fmrPP7OR2NGRB1ZjK0EE25p0FTOh52XdUZzFHbqzx820EeMEOTTNc3LyZaaCrryALmPGJ4YPCxQQ8g7L5YWMNAmEuQcGmgrESdazDpmbXpy3rL+WDER1Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org; spf=none smtp.mailfrom=blackwall.org; dkim=pass (2048-bit key) header.d=blackwall-org.20230601.gappssmtp.com header.i=@blackwall-org.20230601.gappssmtp.com header.b=ya9mJeOv; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=blackwall.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=blackwall-org.20230601.gappssmtp.com header.i=@blackwall-org.20230601.gappssmtp.com header.b="ya9mJeOv" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5c95a962c2bso5336349a12.2 for ; Wed, 16 Oct 2024 00:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall-org.20230601.gappssmtp.com; s=20230601; t=1729063980; x=1729668780; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UkmfvI37fM4cCea1RGGGm3CHgsjq8A6c8nzfgUsjx54=; b=ya9mJeOvwk0CpZGQz2aP96T12HXczo66JC2acv3d/FrFmgj1jmcUuq7zjJqByNvMIW Ij91SSlSxU3066XrYgYTaWNxf5zgfV2HUAgz9etFnQNj8Mn+YzyRpPmzUnGL+gDLp89l Tct6IWOgVkArSXbl9GNQBF9CCaQr86/Mh6TnhxxatBydnNbuNgWCBfXRzUw1RuIPm7pL lkhwzwE/+CQL9dlGSBQXhC/2zVPIHoiuiF9m9oXIsnprhYy91IU5gwiGoI5mh7eLYMoy XiI5kNk3fWwOMdt3+vbTowylMW3nfv/CWzDTl+UqkDcIt+yontWtmIHxRIlFew2s33N/ 4E9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729063980; x=1729668780; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UkmfvI37fM4cCea1RGGGm3CHgsjq8A6c8nzfgUsjx54=; b=ZbLlFBLxq5e8wzNFHTkKGitksWifZkrN1FM5iUFlY+RwhSQIj9YYqrRbOmAHMkgU3v TuBzyeC48PMhCqTcTgEfuGa9D+bhEA9Vfi4IHv5fNt9X6B9+cjsghGEeicP+a64UOfOk 8ZYTNjDknCN2UbIx7DYyFoY5brd8XSSV5Ai/tFUsr5hcYhYr6WYeNorO4rZFKtv11hNo 1ikNia7hUqzHFoAKbe9SZgOCHWdkyWLbbl+2rhBnOP7krRpCIARrFZMbNVv58em8NdlL IW9mUhDxYy/sanQGrlz1XquJWFPjf+Xo96+0cLvynnp7HVkppyD+HXrRND1pbs41d717 /5wA== X-Forwarded-Encrypted: i=1; AJvYcCU7uXkgbjUbvsW7au7r0hiCs+bENc2jsf/34p2dff2MqodlOkEhz3/ATMUPnhsp9lHJxxNOx+zr6vpqCXc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9CF1wY5n/kPte250opqqGryGy4joVQdR6okDu3j/BOV65uFrA OQCQLTMNnVnbQTqOyDXDW+UE8X9mfzKgCIo3Qzg46NkvwJnzSuojrdNRZVuzgXk= X-Google-Smtp-Source: AGHT+IHdXqZrS9hSsS2s7NntKAPcw8a41BekSqDPVCDbv+ZB5PWjzoKqEeITzxy3aBK+d5Kbo/3BOA== X-Received: by 2002:a17:907:96a3:b0:a99:fa97:8c2f with SMTP id a640c23a62f3a-a99fa978da4mr1186891466b.53.1729063980451; Wed, 16 Oct 2024 00:33:00 -0700 (PDT) Received: from [192.168.0.245] ([62.73.69.208]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a3f41ab35sm28582666b.180.2024.10.16.00.32.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2024 00:33:00 -0700 (PDT) Message-ID: Date: Wed, 16 Oct 2024 10:32:58 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/3] bonding: use correct return value To: Hangbin Liu , netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Jiri Pirko , Sebastian Andrzej Siewior , Lorenzo Bianconi , Andrii Nakryiko , Jussi Maki , Jay Vosburgh , Andy Gospodarek , Jonathan Corbet , Andrew Lunn , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org References: <20241016031649.880-1-liuhangbin@gmail.com> <20241016031649.880-3-liuhangbin@gmail.com> Content-Language: en-US From: Nikolay Aleksandrov In-Reply-To: <20241016031649.880-3-liuhangbin@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/10/2024 06:16, Hangbin Liu wrote: > When a slave already has an XDP program loaded, the correct return value > should be -EEXIST instead of -EOPNOTSUPP. > > Fixes: 9e2ee5c7e7c3 ("net, bonding: Add XDP support to the bonding driver") > Signed-off-by: Hangbin Liu > --- > drivers/net/bonding/bond_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index f0f76b6ac8be..6887a867fe8b 100644 > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c > @@ -5699,7 +5699,7 @@ static int bond_xdp_set(struct net_device *dev, struct bpf_prog *prog, > if (dev_xdp_prog_count(slave_dev) > 0) { > SLAVE_NL_ERR(dev, slave_dev, extack, > "Slave has XDP program loaded, please unload before enslaving"); > - err = -EOPNOTSUPP; > + err = -EEXIST; > goto err; > } > Reviewed-by: Nikolay Aleksandrov