From: Valentin Schneider <valentin.schneider@arm.com>
To: Quentin Perret <qperret@google.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
peterz@infradead.org, vincent.guittot@linaro.org,
Dietmar.Eggemann@arm.com, morten.rasmussen@arm.com,
stable@vger.kernel.org
Subject: Re: [PATCH v2] sched/topology: Allow sched_asym_cpucapacity to be disabled
Date: Tue, 15 Oct 2019 11:58:34 +0100 [thread overview]
Message-ID: <a3a1a3d9-5d3a-3ab3-0eaf-e63e0c401c99@arm.com> (raw)
In-Reply-To: <20191015104010.GA242992@google.com>
On 15/10/2019 11:40, Quentin Perret wrote:
>> @@ -2124,8 +2124,17 @@ static void detach_destroy_domains(const struct cpumask *cpu_map)
>> int i;
>>
>> rcu_read_lock();
>> +
>> + if (static_key_enabled(&sched_asym_cpucapacity)) {
>> + unsigned int cpu = cpumask_any(cpu_map);
>> +
>> + if (rcu_dereference(per_cpu(sd_asym_cpucapacity, cpu)))
>> + static_branch_dec_cpuslocked(&sched_asym_cpucapacity);
>
> Lockdep should scream for this :)
Bleh, yes indeed...
>> + }
>> +
>> for_each_cpu(i, cpu_map)
>> cpu_attach_domain(NULL, &def_root_domain, i);
>> +
>> rcu_read_unlock();
>> }
>>
>> --
>> 2.22.0
>>
next prev parent reply other threads:[~2019-10-15 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 10:29 Valentin Schneider
2019-10-15 10:40 ` Quentin Perret
2019-10-15 10:58 ` Valentin Schneider [this message]
2019-10-15 11:49 ` Valentin Schneider
2019-10-15 11:56 ` Quentin Perret
2019-10-15 12:57 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3a1a3d9-5d3a-3ab3-0eaf-e63e0c401c99@arm.com \
--to=valentin.schneider@arm.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=stable@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome