From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC7D818A95E; Fri, 14 Feb 2025 18:06:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739556394; cv=none; b=jkCgrtfgQ9EHDeSuiJRzuOaQBi2v+L4e/Ck0FvO/5lZESvjNtu7oyKogr/MhFYmgzaElgmJYD97/HgWnRpkzlSreh4980Z9zMwaEKnvOHUHP5gI0nLB+vZ4YKEmHsWn0aIeK5n7MI0ICdBncKmmaEtMen6s/eiNpOSO89L4LZIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739556394; c=relaxed/simple; bh=nwJkCdu5aYASX2I9rQY1aemjO5APAP4C13JnuAkuHmU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dD1U7ECXxbMSVy8vjhizoXCzf8dvl1HR8RqaDYkSwGCM88Ms2ilzTdyyLoafgFnMA3BlmryfODTtufYuzi349jExR3ghUWQzJChSPMHPe+B5ZzH6/m0Kc6n/c6TlxE1b5e+EEel3ks80OoRpuKPa1Esm6ZSfAYR5LCzYGZdMRGc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=Pxdeg6e6; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Pxdeg6e6" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=BfqA5i2k2ih3KhcB7eyqPSoEHZ9WVOsd3W+6RqLEdV8=; b=Pxdeg6e6YfNeOi2C3fUWQX7C0v OGuZedY5YrRh4P2fVKKAOH28D2SvrEzwWWzk5xUdy0j0nDrEVxawcTWyRXQtXYAIAgjRGsfjxDoBK RRHxIyC0rE+xfE9DMGTAUPdk53jOeho2tztyzemWcXuHJ+jSjuQjmL0v/eaapCcAcU5g=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1tj050-00E98D-IH; Fri, 14 Feb 2025 19:06:22 +0100 Date: Fri, 14 Feb 2025 19:06:22 +0100 From: Andrew Lunn To: Dimitri Fedrau Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Niklas =?iso-8859-1?Q?S=F6derlund?= , Gregor Herburger , Stefan Eichenberger , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 3/3] net: phy: marvell-88q2xxx: enable temperature sensor in mv88q2xxx_config_init Message-ID: References: <20250214-marvell-88q2xxx-cleanup-v1-0-71d67c20f308@gmail.com> <20250214-marvell-88q2xxx-cleanup-v1-3-71d67c20f308@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250214-marvell-88q2xxx-cleanup-v1-3-71d67c20f308@gmail.com> On Fri, Feb 14, 2025 at 05:32:05PM +0100, Dimitri Fedrau wrote: > Temperature sensor gets enabled for 88Q222X devices in > mv88q222x_config_init. Move enabling to mv88q2xxx_config_init because > all 88Q2XXX devices support the temperature sensor. > > Signed-off-by: Dimitri Fedrau The change itself looks fine: Reviewed-by: Andrew Lunn but is the sensor actually usable if the PHY has not yet been configured? Architecturally, it seems odd to register the HWMON in probe, and then enable it in config_init. Andrew